Stack Overflow
Stack Overflow

Questions tagged [github-codereviews]

Questions which are related to the GitHub pull request reviews functionality.

GitHub pull request reviews functionality. See https://help.github.com/articles/about-pull-request-reviews/

42 questions
1
vote
1 answer

How to use Phabricator only as a code review tool？

Our team currently uses gitlab as a code repository. Now we want to integrate a code review tool, but we hope that the code is still submitted directly to gitlab and the Phabricator just use for code review. What can i do? Are there any related…
Baiye
  • 11
  • 1
1
vote
0 answers

How to review pull requests revisions?

Let's say Joe is working on a big task. He submits an initial revision of his work in a big PR with 20 commits. Now other developers spend a long time reviewing that PR and ask for a few changes/fixes. Joe now amends his commits with the requested…
Juan
  • 23
  • 4
1
vote
1 answer

Is it possible to get all my GitHub code review comments?

GitHub provides quite a convenient API (REST, v3) to see everything on repository level. To see one's comments on code review, I need to know which repositories were reviewed by him/her and crawl all PRs in these repositories. However, sometimes I…
Ilya Palachev
  • 196
  • 1
  • 1
  • 12
1
vote
2 answers

Making changes to branch after code review in git

I have a branch feature/my-changes which I have made changes to. I pushed these changes, created a pull request, and have gotten feedback on my changes through a code review. My question is: Now that I see the changes I need to make in github (from…
Isaac Perez
  • 503
  • 1
  • 11
  • 22
1
vote
1 answer

Don't require accepts for commits to develop branch with certain name pattern

In our GitHub repository we've recently enabled Require pull request reviews before merging rule for develop branch. Also, we have a little bash script that creates a new version that does the following: update version in pom.xml git commit create…
htshame
  • 4,702
  • 3
  • 22
  • 41
1
vote
2 answers

How to set up a code review workflow using gitlab,jenkins,git?

So my question is that i want to set up a code review flow , the tools i have are : git,gitlab,jenkins.. my idea is like to have a kind of forms or checklists that a member of the team need to fill whenever other member want to merge some new code ,…
Nawfal Nawfal
  • 29
  • 3
1
vote
1 answer

Pull request review from user without access to repo

I've been getting frequent emails saying something like... Hello, please review and approve this PR (link) ...only to be served a 404 from octobiwan. Inevitably I'll reply... I don't seem to have access to this repo, can you make sure you've…
Peter Vandivier
  • 421
  • 4
  • 20
1
vote
1 answer

How do I get my code reviewed if I am owner of Github repository?

I have created a repository(of which I am the owner). My repository has about 5 contributors. We are able to review the code submitted by the contributors when they submit their pull request. What I need to know is there a way other than me opening…
ashish2199
  • 343
  • 1
  • 11
1
vote
2 answers

Append gerrit patch-set if commits were done locally

The issue I'm having is this: I have a git repository I was committing to locally via Pycharm's git plugin (not sure if that part of it is relevant). I pushed those changes to a gitlab repository. Now, I have to do codereview. Someone sends me a git…
frei
  • 429
  • 3
  • 15
1
vote
1 answer

GitHub Api check number of approvals on protected branch

I'm writing a server that should connect to GitHub and merge pull requests, but only if the required number of approvals is met. For my purpose it's not good enough to automatically merge the branch, I need to be able to track and record the number…
Forrest Keppler
  • 305
  • 2
  • 12
1
vote
1 answer

Comment, Approve, Request Changes in Gihtub Pull Requests

Last week Gihtub introduced the Reviews functionality for Pull Requests. It was announced in the Github Blog. It seems to be very useful, except I am unable to find the options for requesting changes, commenting or approving changes in a Pull…
jvrsgsty
  • 538
  • 4
  • 16
1
vote
0 answers

Posting Github CodeReview Comments to Private Slack Messages

I want to connect GitHub and Slack in a very specific way. When a comment to a Github CodeReview is written, the user who has committed the code should get the comment as private message. Now I can do is to integrade slack and github with normal…
Boas Enkler
  • 11,465
  • 12
  • 61
  • 128
0
votes
1 answer

What is the purpose of non-collaborator reviews in GitHub?

GitHub documentation states: After a pull request is opened, anyone with read access can review and comment on the changes it proposes. In public GitHub repositories, what is the point of allowing people other than the repository owner or…
Miroslav Policki
  • 71
  • 3
  • 10
0
votes
1 answer

Any one used Sonarqube to review loadrunner scripts?

I would like to use Sonarqube to review LoadRunner/Jmeter scripts to check the code quality, are followed standards and best practice during test design. any one used Sonarqube to do that before?
AmarjeetM
  • 1
  • 1
  • 3
0
votes
0 answers

GitHub code review: check resolution of each item

On GitHub, I've reviewed a pull request and requested changes from a coworker. They've made changes and added them to the pull request. Now I want to check two things: I want to see each new change (as unrelated changes may have been done). I want…
Timo
  • 6,027
  • 4
  • 38
  • 52
1
2
3