Stack Overflow
Stack Overflow

Questions tagged [github-codereviews]

Questions which are related to the GitHub pull request reviews functionality.

GitHub pull request reviews functionality. See https://help.github.com/articles/about-pull-request-reviews/

42 questions
38
votes
2 answers

How to un-approve github review after new commits automatically

Once a pull request is approved, if there are further commits: The Pull request should go to un-approved state automatically. Can this be done?
Anurag
  • 836
  • 2
  • 8
  • 21
7
votes
0 answers

How to request a code review on a committed master branch within GitHub?

I have read postings and performed code reviews on pull requests, for example: "How to create and review a GitHub pull request" GitHub Question: You (as a solo contributor) have been working on a body of code you have been committing to GitHub for…
Jeff Tanner
  • 899
  • 6
  • 24
5
votes
0 answers

Viewing/Recovering pending code reviews in Github

When I start a code review, I can add multiple comments with a 'pending' status review and then submit them all at once instead of one-by-one. If I close the review and come back to it, those pending comments are saved, but it requires me going back…
Bricky
  • 1,879
  • 9
  • 23
4
votes
1 answer

git mv and changes and similarity index

When a file is renamed with git mv, the commit will show rename from and rename to, and in pull request shows the same, which is good. But when a file is git mved then changed, it looks there is a certain threshold that when number of lines changed…
fluter
  • 11,341
  • 7
  • 44
  • 77
4
votes
1 answer

How to review git pull requests (hosted on bticuket) in intelliJ?

Wants to review the git pull requests in intelliJ Idea (2018.3) and check the compile time, test run impact and other IDE features before approving or rejecting?
joonpradeep
  • 51
  • 4
4
votes
2 answers

GitHub pull request reviews line comments behaviour

Recently GitHub introduced some new features including Pull Request Reviews. In the past, line comments in Pull Requests would collapse like this after the line was changed in further commits: Since the launch of the new feature, line comments no…
rink.attendant.6
  • 36,468
  • 57
  • 89
  • 143
3
votes
1 answer

Internal review before raising PR

Background: The GitHub belongs to the client. We have some newbies in the team, who sometimes miss basic naming convention and other coding protocols. So, if any senior wants to review internally there is no other way but to create a PR. But then…
paul
  • 3,639
  • 13
  • 53
  • 106
3
votes
1 answer

Github pull requests history

Is the history of the pull-requests preserved forever? I could not find anywhere for how long the pull-requests history is being saved.
Oron Ben-David
  • 1,391
  • 2
  • 14
  • 30
2
votes
0 answers

How can I make a github PR requesting review of entire files?

There is this issue which is related, to allow commenting on parts of code OUTSIDE the change set. I'm just wondering if anyone has clever work arounds or a process to achieve something similar, maybe simpler. So I have a different sets of files…
Marvin
  • 1,590
  • 12
  • 22
2
votes
0 answers

Github code review shows blank lines after, how to remove them?

Here is my work flow: git pull origin master git checkout -b test Make some changes git add . git commit -m"Add changes" git push origin test Then in code review, I saw some empty lines, so instead of change formatting line by line, I reset that…
ForeverYang
  • 61
  • 5
2
votes
1 answer

How to initiate a pull-request for an old piece of code in a `git` medium?

I have a repository that I have developed over a period of time. It includes a series of files that I would like to get peer-reviewed via Pull-request. One pull-request for each file in this repo will be exactly what I need. In the past, I have…
Rotail
  • 854
  • 12
  • 31
2
votes
2 answers

github: initiate code review without pull request?

it is a bad way to do code reviews after pull request has been initiated. sometimes we want to do code reviews before the whole thing is ready for integration. is there any tools out there that will allow code review without pull request? I prefer…
user2584960
  • 445
  • 5
  • 16
1
vote
1 answer

Require Github PR approvals from multiple groups

I'm using the codeowners file to require PR approvals before they can be merged. What I'd like to do is: Require all PRs to have at least one approval from a group of code owners (engineers) Require all PRs to have at least one approval from a…
Brady Dowling
  • 3,296
  • 2
  • 22
  • 43
1
vote
1 answer

How do I review an entire codebase on github?

I would like to review all of the code in a single branch of a git repo on GitHub. (I am a professor, and the code is part of a student's thesis.) Any single commit affects only a small portion of the code. How can I perform a review that allows me…
Ellen Spertus
  • 5,875
  • 9
  • 47
  • 82
1
vote
2 answers

How to structure related pull requests

I'm working on a large section of a web app and have a several jira tickets assigned to me to complete it step by step: e.g. Task 1: create the main page of the section displaying a list of items Task 2: create a page with detailed item…
Dmitry Oleinik
  • 628
  • 1
  • 6
  • 15
1
2 3