How to make this JS code executed only if statement is true? Set cookies

Question

Please help me to find a sutable solution for below in js:

1) I have a URL from referrer that contains two variables

http://example.com/?pdid=xxxx&puid=yyyy

2) I have to catch pdid and puid variables form URL and set cookies with name POKUPON_DID and POKUPON_UID and their values

3) The main problem that cookies are set to undefined if URL does not contain this variables. I need your help with corect IF statement. The code should preform only once and if variables in URL are exist...

function getUrlVars()
{
    var vars = [], hash;
    var hashes = window.location.href.slice(window.location.href.indexOf('?') + 1).split('&');
    for(var i = 0; i < hashes.length; i++)
    {
        hash = hashes[i].split('=');
        vars.push(hash[0]);
        vars[hash[0]] = hash[1];
    }
    return vars;
}

var $POKUPON_DID = getUrlVars()["pdid"];
var $POKUPON_UID = getUrlVars()["puid"];
 
if($POKUPON_DID != emty){
    
function setCookie(cname,cvalue,exdays) {
    var d = new Date();
    d.setTime(d.getTime() + (exdays*24*60*60*1000));
    var expires = "expires=" + d.toGMTString();
    document.cookie = cname+"="+cvalue+"; "+expires;

}

setCookie("POKUPON_DID",$POKUPON_DID,30);
setCookie("POKUPON_UID",$POKUPON_UID,30);
}

Thank you a lot in advance!

score 0 · Accepted Answer · edited May 23 '17 at 12:14

0

You need to be checking for undifiend read up on this: How to check for "undefined" in JavaScript?

function getUrlVars()
{
    var vars = [], hash;
    var hashes = window.location.href.slice(window.location.href.indexOf('?') + 1).split('&');
    for(var i = 0; i < hashes.length; i++)
    {
        hash = hashes[i].split('=');
        vars.push(hash[0]);
        vars[hash[0]] = hash[1];
    }
    return vars;
}
function setCookie(cname,cvalue,exdays) {
    var d = new Date();
    d.setTime(d.getTime() + (exdays*24*60*60*1000));
    var expires = "expires=" + d.toGMTString();
    document.cookie = cname+"="+cvalue+"; "+expires;

}

var $POKUPON_DID = getUrlVars()["pdid"];
var $POKUPON_UID = getUrlVars()["puid"];
 console.log($POKUPON_DID);
 console.log($POKUPON_UID);

if(typeof $POKUPON_DID != 'undefined'){
setCookie("POKUPON_DID",$POKUPON_DID,30);
setCookie("POKUPON_UID",$POKUPON_UID,30);
}

edited May 23 '17 at 12:14

Community

1
1

answered Aug 30 '15 at 10:16

vimes1984

1,675
2
25
54

I agree completly but as he asked: ". I need your help with corect IF statement. The code should preform only once and if variables in URL are exist..." and I've helped him with just that the if statement, God only knows why he's defining the function inside the if it's not like it creates scope anyway... – vimes1984 Aug 30 '15 at 10:23
but by all means rewrite it for him :D – vimes1984 Aug 30 '15 at 10:24
Thank you for reply, but every time I go to another page without variables in the URL - cookies become UNDEFINED again :( – Danil Mihnevich Aug 30 '15 at 10:28
what if you console.log($POKUPON_UID); just below the definition? – vimes1984 Aug 30 '15 at 10:30
And yes, I am not a programmer so your help is valuable as never :) – Danil Mihnevich Aug 30 '15 at 10:30
what file do you have the javascript defined in? – vimes1984 Aug 30 '15 at 10:34
the script is placed in woorpa trigger – Danil Mihnevich Aug 30 '15 at 10:35
run script if url contains pdid an url contains puid – Danil Mihnevich Aug 30 '15 at 10:36
I mean this is an external script – Danil Mihnevich Aug 30 '15 at 10:38
christ what are you using there?? – vimes1984 Aug 30 '15 at 10:39
actually almost everything works. I can read variables from URL and set them too cookie but when I jump to another page - cookies values are undefined again( – Danil Mihnevich Aug 30 '15 at 10:46
check my updated snippet that seems to work for me here – vimes1984 Aug 30 '15 at 10:52
Thank you for your patience.. I added a script in between – Danil Mihnevich Aug 30 '15 at 11:02
you have something else removing the cookie..... if you run it in the console after the page load it sets it then the cookies are there when i navigate somewhere else... – vimes1984 Aug 30 '15 at 11:09
how are you chking the cookies? – vimes1984 Aug 30 '15 at 11:15
Do you have any ideas what it could be? main.html now is only one file where the code is placed... – Danil Mihnevich Aug 30 '15 at 11:15
it could be a thousand different things.. without seeing the source code it's realllly hard to tell – vimes1984 Aug 30 '15 at 11:18
the code above does work though... if you could accept the answer that would be great :D – vimes1984 Aug 30 '15 at 12:31

How to make this JS code executed only if statement is true? Set cookies

1 Answers1