772

I'm trying to follow PEP 328, with the following directory structure:

pkg/
  __init__.py
  components/
    core.py
    __init__.py
  tests/
    core_test.py
    __init__.py

In core_test.py I have the following import statement

from ..components.core import GameLoopEvents

However, when I run, I get the following error:

tests$ python core_test.py 
Traceback (most recent call last):
  File "core_test.py", line 3, in <module>
    from ..components.core import GameLoopEvents
ValueError: Attempted relative import in non-package

Searching around I found "relative path not working even with __init__.py" and "Import a module from a relative path" but they didn't help.

Is there anything I'm missing here?

Philip
  • 296
  • 3
  • 13
skytreader
  • 10,673
  • 5
  • 39
  • 57
  • 19
    I was also very confused by the various ways of structuring `unittest` projects, so I wrote this [fairly exhaustive sample project](https://github.com/cod3monk3y/PyImports) that covers deep nesting of modules, relative and absolute imports (where the work and don't), and relative and absolute referencing from within a package, as well as single, double, and package-level import of classes. Helped clear things *right up* for me! – cod3monk3y Dec 05 '14 at 21:55
  • 1
    I could not get your tests to work. Keep getting `no module named myimports.foo` when I run them. – Blairg23 Nov 22 '15 at 02:28
  • @Blairg23 I'm guessing the intended invocation is to `cd` into `PyImports`, and run `python -m unittest tests.test_abs`, for example. – duozmo Jan 19 '16 at 23:40
  • 7
    I agree with Gene. I wish there was a mechanism for debugging the importing process that was a little more helpful. In my case, I have two files in the same directory. I am trying to import one file into the other file. If I have an __init__.py file in that directory, I get a ValueError: Attempted relative import in non-package error. If I remove the __init__.py file, then I get an error no module named 'NAME' error. – Jeff Silverman Mar 23 '17 at 19:23
  • In my case, I have two files in the same directory. I am trying to import one file into the other file. If I have an __init__.py file in that directory, I get a ValueError: Attempted relative import in non-package error. If I remove the __init__.py file, then I get an error no module named 'NAME' error. What is really frustrating is that I had this working, and then I shot myself in the foot by deleting the .bashrc file, which set the PYTHONPATH to something, and now it is not working. – Jeff Silverman Mar 23 '17 at 19:29
  • @user1928764: These errors are indeed frustrating. I assume you meant "`__init__.py` file." – Tom Russell Sep 22 '17 at 07:27
  • Have a look at this: https://stackoverflow.com/a/14132912/11573842 – Yatin Apr 22 '21 at 10:55

20 Answers20

663

To elaborate on Ignacio Vazquez-Abrams's answer:

The Python import mechanism works relative to the __name__ of the current file. When you execute a file directly, it doesn't have its usual name, but has "__main__" as its name instead. So relative imports don't work.

You can, as Igancio suggested, execute it using the -m option. If you have a part of your package that is meant to be run as a script, you can also use the __package__ attribute to tell that file what name it's supposed to have in the package hierarchy.

See http://www.python.org/dev/peps/pep-0366/ for details.

John Strood
  • 1,391
  • 2
  • 22
  • 35
BrenBarn
  • 210,788
  • 30
  • 364
  • 352
  • 58
    Took a while for me to realize you can't run `python -m core_test` from within the `tests` subdirectory - it has to be from the parent, or you have to add the parent to the path. – Aram Kocharyan Feb 18 '13 at 08:31
  • So can I therefore use __package__ to ensure executable script files are able to relative import from the rest of the system regardless of their level in the hierarchy? This would be very useful indeed. – Danny Staple Jul 08 '13 at 13:39
  • 3
    @DannyStaple: Not exactly. You can use `__package__` to ensure executable script files can relatively import other modules from within the same package. There's no way to relatively import from "the whole system". I'm not even sure why you'd want to do this. – BrenBarn Jul 08 '13 at 17:46
  • 2
    I mean if the `__package__` symbol is set to "parent.child" then you'd be able to import "parent.other_child". Perhaps I didn't phrase it so well. – Danny Staple Jul 09 '13 at 22:12
  • 5
    @DannyStaple: Well, how it works is described in the linked documentation. If you have a script `script.py` in package `pack.subpack`, then setting it's `__package__` to `pack.subpack` will let you do `from ..module import something` to import something from `pack.module`. Note that, as the documentation says, you still have to have the top-level package on the system path. This is already the way things work for imported modules. The only thing `__package__` does is let you use that behavior for directly-executed scripts as well. – BrenBarn Jul 10 '13 at 01:51
  • There is no sample code in the PEP-0366 linked documentation @BrenBarn. Where can I find sample code? – Alison S May 17 '16 at 02:22
  • @AlisonS: Sample code to do what? There is a small snippet in the PEP that explains how to set `__package__`. – BrenBarn May 17 '16 at 02:25
  • But there is no context to where that snippet belongs @BrenBarn. Does it go in the file you're importing? In the file that is doing the import? Where in the relevant file does it go? – Alison S May 17 '16 at 02:30
  • @AlisonS: It says right there: "To allow relative imports when the module is executed directly, boilerplate similar to the following would be needed before the first relative import statement". I think that is pretty clear that you put it in the module you are executing directly, before that module attempts any relative imports. – BrenBarn May 17 '16 at 02:36
  • 3
    I use `__package__` in the script which is executed directly but Unfortunately, I get the the following error: "Parent module 'xxx' not loaded, cannot perform relative import" – mononoke Oct 13 '17 at 04:53
458

Yes. You're not using it as a package.

python -m pkg.tests.core_test
Ignacio Vazquez-Abrams
  • 699,552
  • 132
  • 1,235
  • 1,283
  • 52
    A gotcha: Note that there is no '.py' at the end! – mindthief Dec 07 '12 at 01:39
  • 522
    I'm not either of the downvoters, but I feel this could use *quite a bit* more detail, given the popularity of this question and answer. Noting stuff like from what directory to execute the above shell command, the fact that you need `__init__.py`s all the way down, and the `__package__`-modifying trickery (described below by BrenBarn) needed to allow these imports for executable scripts (e.g. when using a shebang and doing `./my_script.py` at the Unix shell) would all be useful. This whole issue was quite tricky for me to figure out or find concise and understandable documentation on. – Mark Amery Jan 13 '14 at 17:31
  • 5
    There is a [nicely elaborated recent answer below](http://stackoverflow.com/a/27876800/838992) with a link to the docs as suggested by the upvoted comment. – J Richard Snape Jul 28 '15 at 10:59
  • 18
    Note: you need to be outside of the directory `pkg` at the point where you call this line from the CLI. Then, it should work as expected. If you are inside `pkg` and you call `python -m tests.core_test`, it will not work. At least it didn't for me. – Blairg23 Nov 23 '15 at 06:35
  • 5
    This does not work if you run the script inside components dir for example – Ville Miekk-oja Dec 17 '15 at 12:40
  • 1
    I coupled this with `cd`ing into the project's parent directory. `cd /path/to/project && python -m project.module.submodule`. You may want to add `&& cd ~` in the end if you are testing this out multiple times on local system. – shad0w_wa1k3r Dec 23 '15 at 20:44
  • 1
    When they designed the language, why didn't they just make "python pkg/test/core_test.py" do the same thing as "python -m pkg.test.core_test"? Why do they deliberately break relative imports whenever you run anything as a script? – Jonathan Ray Apr 08 '16 at 00:15
  • @JonathanRay: Because having them do the same thing makes execution ambiguous; what sense does it make for `python /usr/share/someapp/somescript.py` to be `usr.share.someapp.somescript`? – Ignacio Vazquez-Abrams Apr 08 '16 at 00:40
  • 98
    Seriously, can you explain whats going on in your answer? – Charlie Parker Jun 22 '16 at 06:33
  • 19
    @MarkAmery Almost lost my mind trying to grok how all this works, relative imports within a project with subdirectories with py files that have `__init__.py` files yet you keep getting the `ValueError: Attempted relative import in non-package` error. I would pay really good money for someone, somewhere, to finally explain in plain English how all of this works. – AdjunctProfessorFalcon Aug 20 '16 at 22:34
  • 6
    Contrary to the answer for an FAQ in Python this answer gives no clue what is happening and from where to execute this command – Prahalad Deshpande Dec 28 '16 at 15:10
  • for running on jupyter notebook %run -m – Eswar Dec 20 '18 at 11:21
  • 1
    I'm not sure how running it as a module helps @skytreader 's import problem from within another script... – user2589273 Apr 02 '19 at 11:15
  • 2
    Maybe I don't really understand the cultural norms around the wiki-like features on SO, but it's notable that no one pointing out how Ignacio's answer could be improved actually improved it in-place. (Mind you, I agree 100% with the comments that an explanation would be extremely helpful.) – Philip Jun 01 '19 at 17:37
  • `-m` flag is used to run the file as a script. It indicates the module name and starts from the parent module and goes deeper in the directory to run the script. – subtleseeker Sep 04 '19 at 15:32
210

You can use import components.core directly if you append the current directory to sys.path:

if __name__ == '__main__' and __package__ is None:
    from os import sys, path
    sys.path.append(path.dirname(path.dirname(path.abspath(__file__))))
Miles Erickson
  • 2,294
  • 1
  • 16
  • 17
ihm
  • 2,233
  • 1
  • 12
  • 5
  • 36
    `sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))` this will also work – ajay Oct 18 '13 at 13:46
  • 27
    `from os import sys` looks like cheating :) – flying sheep Nov 30 '13 at 11:30
  • 2
    @ajay And yours is better because of what? – Piotr Dobrogost Jan 28 '14 at 15:05
  • 3
    @Piotr: It's might be considered better because it slightly shows more clearly what is being being appended to `sys.path` -- the parent of the directory the current file is in. – martineau Mar 05 '14 at 20:42
  • 2
    @martineau I think you are [right](https://github.com/pfmoore/pip/commit/87418e05bb55ea64476653dd41e2f4db785f02c0#commitcomment-5418772) :) – Piotr Dobrogost Mar 05 '14 at 20:51
  • 2
    @Piotr: Ah, yes, I would have to agree that `sys.path.append(path.dirname(path.dirname(__file__)))` would be even more clear -- and with a comment, perfect. – martineau Mar 05 '14 at 21:06
  • 8
    @flyingsheep: Agreed, I'd just use a regular `import sys, os.path as path`. – martineau Mar 05 '14 at 21:08
  • 10
    FYI, to use this in an ipython notebook, I adapted this answer to: `import os; os.sys.path.append(os.path.dirname(os.path.abspath('.')))`. Then a straight `import components.core` works for me, importing from the notebook's parent directory as desired. – Racing Tadpole May 27 '14 at 01:41
  • Great things for nested usage of `dirname` function. Haven't seen that before. – andy Apr 29 '15 at 07:09
  • How does `from os import sys` work? `os` is a module outside the `sys` module. – Stefan Monov Jul 20 '16 at 17:21
  • 1
    May I add another trick... I tried every advise that I could find on SO regarding a similar issue and finally found that I had some old .pyc files that were causing conflicts. So if anyone tries the above solution and it fails, check if you need to delete your .pyc files. – Jabb Nov 09 '17 at 12:10
  • 1
    doing sys.path.append is not cool to do because generating a standalone installer with pyinstall... fails miserably. I switched to file system links – mhstnsc Jul 04 '19 at 15:01
203

It depends on how you want to launch your script.

If you want to launch your UnitTest from the command line in a classic way, that is:

python tests/core_test.py

Then, since in this case 'components' and 'tests' are siblings folders, you can import the relative module either using the insert or the append method of the sys.path module. Something like:

import sys
from os import path
sys.path.append( path.dirname( path.dirname( path.abspath(__file__) ) ) )
from components.core import GameLoopEvents

Otherwise, you can launch your script with the '-m' argument (note that in this case, we are talking about a package, and thus you must not give the '.py' extension), that is:

python -m pkg.tests.core_test

In such a case, you can simply use the relative import as you were doing:

from ..components.core import GameLoopEvents

You can finally mix the two approaches, so that your script will work no matter how it is called. For example:

if __name__ == '__main__':
    if __package__ is None:
        import sys
        from os import path
        sys.path.append( path.dirname( path.dirname( path.abspath(__file__) ) ) )
        from components.core import GameLoopEvents
    else:
        from ..components.core import GameLoopEvents
Paolo Rovelli
  • 8,082
  • 1
  • 52
  • 37
  • 3
    what shall i do if i am trying to use the pdb for debugging? since you use `python -m pdb myscript.py` to launch the debugging session. – danny Aug 04 '15 at 02:23
  • 1
    @dannynjust -- That's a good question since you can't have 2 main modules. Generally when debugging, I prefer to drop into the debugger manually at the first point where I want to start debugging. You can do that by inserting a `import pdb; pdb.set_trace()` into the code (inline). – mgilson Aug 10 '15 at 16:49
  • 3
    Is it better to use `insert` instead of `append`? That is, `sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))` – SparkAndShine Mar 23 '16 at 16:18
  • 2
    Using insert is a better match for the relative import semantics, where local package names take precedence over installed packages. Especially for tests, you usually want to test the local version, not the installed one (unless your test infrastructure installs the code under test, in which case relative imports are unneeded and you won't have this problem). – Alex Dupuy Aug 20 '16 at 14:14
  • 1
    you should also mention that you can't be in the directory containing core_test when you run as a module (that would be too easy) – Joseph Garvin Oct 16 '16 at 20:36
29

In core_test.py, do the following:

import sys
sys.path.append('../components')
from core import GameLoopEvents
Allan Mwesigwa
  • 870
  • 8
  • 13
11

If your use case is for running tests, and it seams that it is, then you can do the following. Instead of running your test script as python core_test.py use a testing framework such as pytest. Then on the command line you can enter

$$ py.test

That will run the tests in your directory. This gets around the issue of __name__ being __main__ that was pointed out by @BrenBarn. Next, put an empty __init__.py file into your test directory, this will make the test directory part of your package. Then you will be able to do

from ..components.core import GameLoopEvents

However, if you run your test script as a main program then things will fail once again. So just use the test runner. Maybe this also works with other test runners such as nosetests but i haven't checked it. Hope this helps.

deepak
  • 1,823
  • 18
  • 34
10

My quick-fix is to add the directory to the path:

import sys
sys.path.insert(0, '../components/')
v4gil
  • 630
  • 7
  • 15
  • 6
    Your approach wont work in all cases because '../' part is resolved from directory from which you run your script(core_test.py). With your approach you are forced to cd to 'tests' before running the core_test.py scritp. – xyman Dec 10 '16 at 20:06
9

Issue is with your testing method,

you tried python core_test.py

then you will get this error ValueError: Attempted relative import in non-package

Reason: you are testing your packaging from non-package source.

so test your module from package source.

if this is your project structure,

pkg/
  __init__.py
  components/
    core.py
    __init__.py
  tests/
    core_test.py
    __init__.py

cd pkg

python -m tests.core_test # dont use .py

or from outside pkg/

python -m pkg.tests.core_test

single . if you want to import from folder in same directory . for each step back add one more.

hi/
  hello.py
how.py

in how.py

from .hi import hello

incase if you want to import how from hello.py

from .. import how
Mohideen bin Mohammed
  • 14,471
  • 7
  • 86
  • 95
  • In the example `from .. import how`, how do you import a specific class / method from the 'how' file. when I do the equivalent of `from ..how import foo` then I get "attempted relative import beyond top-level package" – James Hulse May 05 '20 at 16:52
  • @JamesHulse Does `from .. import how` work but the second statement not? I would have assumed that both statements won't work, if the folder that contains the hi folder does not contain an _ _ init _ _.py file. In other words, if there is only an init file in the hi folder, then the hi folder is the top level package and you cannot address beyond it. – Isi Sep 25 '20 at 13:32
4

As Paolo said, we have 2 invocation methods:

1) python -m tests.core_test
2) python tests/core_test.py

One difference between them is sys.path[0] string. Since the interpret will search sys.path when doing import, we can do with tests/core_test.py:

if __name__ == '__main__':
    import sys
    from pathlib import Path
    sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
    from components import core
    <other stuff>

And more after this, we can run core_test.py with other methods:

cd tests
python core_test.py
python -m core_test
...

Note, py36 tested only.

zhengcao
  • 341
  • 2
  • 3
3

Old thread. I found out that adding an __all__= ['submodule', ...] to the __init__.py file and then using the from <CURRENT_MODULE> import * in the target works fine.

Laurent
  • 4,904
  • 4
  • 36
  • 64
3

You can use from pkg.components.core import GameLoopEvents, for example I use pycharm, the below is my project structure image, I just import from the root package, then it works:

enter image description here

Jayhello
  • 3,887
  • 3
  • 34
  • 44
3

This approach worked for me and is less cluttered than some solutions:

try:
  from ..components.core import GameLoopEvents
except ValueError:
  from components.core import GameLoopEvents

The parent directory is in my PYTHONPATH, and there are __init__.py files in the parent directory and this directory.

The above always worked in python 2, but python 3 sometimes hit an ImportError or ModuleNotFoundError (the latter is new in python 3.6 and a subclass of ImportError), so the following tweak works for me in both python 2 and 3:

try:
  from ..components.core import GameLoopEvents
except ( ValueError, ImportError):
  from components.core import GameLoopEvents
Rick Graves
  • 137
  • 1
  • 10
2

Try this

import components
from components import *
1

If someone is looking for a workaround, I stumbled upon one. Here's a bit of context. I wanted to test out one of the methods I've in a file. When I run it from within

if __name__ == "__main__":

it always complained of the relative imports. I tried to apply the above solutions, but failed to work, since there were many nested files, each with multiple imports.

Here's what I did. I just created a launcher, an external program that would import necessary methods and call them. Though, not a great solution, it works.

1

As you have already marked everything as a module, there's no need to use the relative reference if you launch as python module.

Instead of

from ..components.core import GameLoopEvents

simply

from pkg.components.core import GameLoopEvents

When you run from the parent of pkg, use the following

python -m pkg.tests.core_test
suriyanto
  • 945
  • 9
  • 16
1

For me only this worked: I had to explicitly set the value of package to the parent directory, and add the parent directory to sys.path

from os import path
import sys
if __package__ is None:
    sys.path.append( path.dirname( path.dirname( path.abspath(__file__) ) ) )
    __package__= "myparent"

from .subdir import something # the . can now be resolved

I can now directly run my script with python myscript.py.

Kai Aeberli
  • 1,019
  • 7
  • 18
0

Here's one way which will piss off everyone but work pretty well. In tests run:

ln -s ../components components

Then just import components like you normally would.

0

This is very confusing, and if you are using IDE like pycharm, it's little more confusing. What worked for me: 1. Make pycharm project settings (if you are running python from a VE or from python directory) 2. There is no wrong the way you defined. sometime it works with from folder1.file1 import class

if it does not work, use import folder1.file1 3. Your environment variable should be correctly mentioned in system or provide it in your command line argument.

0

python <main module>.py does not work with relative import

The problem is relative import does not work when you run a __main__ module from the command line

python <main_module>.py

It is clearly stated in PEP 338.

The release of 2.5b1 showed a surprising (although obvious in retrospect) interaction between this PEP and PEP 328 - explicit relative imports don't work from a main module. This is due to the fact that relative imports rely on __name__ to determine the current module's position in the package hierarchy. In a main module, the value of __name__ is always '__main__', so explicit relative imports will always fail (as they only work for a module inside a package).

Cause

The issue isn't actually unique to the -m switch. The problem is that relative imports are based on __name__, and in the main module, __name__ always has the value __main__. Hence, relative imports currently can't work properly from the main module of an application, because the main module doesn't know where it really fits in the Python module namespace (this is at least fixable in theory for the main modules executed through the -m switch, but directly executed files and the interactive interpreter are completely out of luck).

To understand further, see Relative imports in Python 3 for the detailed explanation and how to get it over.

mon
  • 8,766
  • 4
  • 52
  • 87
-2

Because your code contains if __name__ == "__main__", which doesn't be imported as a package, you'd better use sys.path.append() to solve the problem.

rosefun
  • 1,348
  • 10
  • 21
  • 3
    I don't think having `if __name__ == "__main__"` in your file makes a difference to anything related to importing. – user48956 Dec 23 '19 at 16:38