Blacklist and preg_match

Question

I thought I had this figured out, but I'm running into an issue. I'm creating a URL blacklist in my application. I need to block all subdomains, directories, etc from an array of domains. Below is the array I have:

$blacklist = array(
'/\.google\./',
'/\.microsoft\./',
);

Here is where I'm checking:

    $host = parse_url($url, PHP_URL_HOST);
    $blackList = $GLOBALS['blacklist'];
    foreach($blackList as $stop) {
        if (preg_match($host === $stop)) {
            die('blacklisted');
            }
        }

When I run this, it doesn't die as intended.

**There may be an appropriate time to use `$GLOBALS`, but I haven't encountered it yet**. For more see [Are global variables in PHP considered bad practice? If so, why?](http://stackoverflow.com/questions/1557787/are-global-variables-in-php-considered-bad-practice-if-so-why) — rdlowrey, Jan 17 '12 at 07:35

score 2 · Accepted Answer · answered Jan 17 '12 at 07:34

2

Your foreach loop should be like this:

foreach($blacklist as $stop) {
        if (preg_match($stop, $host)) {
            die("blacklisted\n");
        }
}

You had 2 problems:

array variable was named as blacklist but you were using blackList in foreach loop.
preg_match was being used incorrectly, it needs at least 2 arguments like in my answer.

answered Jan 17 '12 at 07:34

anubhava

664,788
59
469
547

See it working here: http://ideone.com/fdmTo and print your variable `$url` using `var_dump($url);` to investigate. – anubhava Jan 17 '12 at 08:03
Thanks for the help! Everything you posted looks good. I did a `print_r($blackList)` and it returned an empty array. I guess that's my problem. – Paul Dessert Jan 17 '12 at 08:20

score 0 · Answer 2 · answered Oct 13 '19 at 08:48

0

Without foreach:

if(preg_match('/'.implode('|', array_map('preg_quote', $blacklist)).'/i', $string))
{
   die("blacklisted");
}

answered Oct 13 '19 at 08:48

tsamu

21
2

score 0 · Answer 3 · answered Jan 17 '12 at 07:34

0

You're using preg_match wrong!

$host = parse_url($url, PHP_URL_HOST);

foreach ($blacklist as $pattern){
  $matches = array();
  preg_match($pattern, $host, $matches);
  if (count($matches)) die('blacklisted');
}

answered Jan 17 '12 at 07:34

Juicy Scripter

25,035
5
70
90

Blacklist and preg_match

3 Answers3