1

I'm trying to create a small automation script in Javascript that I want to run with a site using Opera's User Script feature to define external scripts to run. I have used this feature before to run scripts I wrote with external sites, to nice effect.

I need to wait till the page loads for the script to run, but I can't seem to get this to work. The code currently is: 

if (addEventListener in document) { // use W3C standard method
    document.addEventListener('load', meerfirst(), false);
} else { // fall back to traditional method
    document.onload = meerfirst();
}

function meerfirst(){
    nameForm = document.forms['aspnetForm'];
    nameForm.elements('ctl00$CPH1$NewQuoteView$TitlesView$DropDownListTitles').value = 'MR:TRUE:MR';
    nameForm.elements('ctl00$CPH1$NewQuoteView$TextBoxFirstName').value = 'James';
 }

This is my own function with the addition of the if statement found via another question here. I have also tried window.onload, but it still didn't work.

Strangely Opera doesn't really seem to execute the script at all, as if I set a breakpoint on the if statement it never actually breaks on it. Could the site have a anti-userscript feature built-in? Or is there possible something I'm doing wrong to stop this executing?

Flatlyn
  • 1,890
  • 5
  • 39
  • 65
  • It's calling meerfirst immediately, not on load. See here: http://jsfiddle.net/ThinkingStiff/6ajFz/. Remove the parens, as @missingo mentioned below. It appears not to be calling meerfirst because nameForm is returning undefined when it first calls it before the page is loaded. – ThinkingStiff Nov 05 '11 at 22:13

4 Answers4

5

Pass the function itself as the callback

addEventListener('load', meerfirst, false);
                  // no parens! ^^

by putting the parentheses you instead call the function immediately (before things load) and pass its (useless, non-function) return value to addEventListener.

BTW, since you already know what browser you will use the code on, why are you doing that feature testing in the start?

hugomg
  • 63,082
  • 19
  • 144
  • 230
3

This code has several issues:

if (addEventListener in document) { // use W3C standard method
    document.addEventListener('load', meerfirst(), false);
} else { // fall back to traditional method
    document.onload = meerfirst();
}

  1. You need to put quotes around addEventListener in the if statement. You're looking for a property name in document, so the name needs to be a string: if( 'addEventListener' in document )

  2. You want to refer to the function by name in the addEventListener statement, not call it immediately. You should remove the parentheses - use just meerfirst instead of meerfirst().

  3. Assigning to document.onload has no effect. See my answer to window.onload vs document.onload and use window.onload instead.

  4. After changing the assignment to window.onload you also need to remove the parentheses. Again, you're just referring to the function by name and don't want it to actually be called at this point.

  5. Finally, I recommend listening for DOMContentLoaded rather than load - unless you are going to run some code that needs to wait until all images are loaded.

Community
  • 1
  • 1
hallvors
  • 5,603
  • 1
  • 20
  • 37
  • 1
    I also recommend putting `var ` in front of the first line where you define nameform. This makes 'nameform' a local variable instead of a global one. – hallvors Nov 08 '11 at 12:34
2

Try:

window.onload = function() 
{

meerfirst();

};
ThinkingStiff
  • 62,391
  • 29
  • 139
  • 237
  • I've previously tried window.onload method with no avail. As mentioned in above comment, I'm thinking more and more it has to do with the scripting never being executing which raises the questions why, – Flatlyn Nov 05 '11 at 22:07
  • The parens that @missingno mentioned are the issue with your addEventListener call. – ThinkingStiff Nov 05 '11 at 22:09
2

Your answer is nested nicely within O'Reilly's "Javascript: the Definitive Guide"

// Register the function f to run when the document finishes loading.
// If the document has already loaded, run it asynchronously ASAP.
function onLoad(f) {
    if (onLoad.loaded) // If document is already loaded
        window.setTimeout(f, 0); // Queue f to be run as soon as possible
    else if (window.addEventListener) // Standard event registration method
        window.addEventListener("load", f, false);
    else if (window.attachEvent) // IE8 and earlier use this instead
        window.attachEvent("onload", f);
}
// Start by setting a flag that indicates that the document is not loaded yet.
onLoad.loaded = false;
// And register a function to set the flag when the document does load.
onLoad(function() { onLoad.loaded = true; });

This will not only run when the browser finishes loading but it will also handle cross-browser discrepancies. Enjoy :)

Marlin
  • 751
  • 4
  • 8