Why do I get a NullReferenceException when checking for null in the view

Question

I have the following code to display a list of account numbers to the user.

View Model:

Sometimes the list will be null as there will be no accounts to display.

public class AccountsViewModel
{
    public List<string> Accounts { get; set; }
}

View:

@model AccountsViewModel

using (@Html.BeginForm())
{
    <ul>
        @*if there are accounts in the account list*@
        @if (Model.Accounts != null)
        {
            foreach (string account in Model.Accounts)
            {
                <li>Account number* <input type="text" name="account" value="@account"/></li>
            }
        }

        @*display an additional blank text field for the user to add an additional account number*@
        <li>Account number* <input type="text" name="account"/></li>

    </ul>


    ...
}

Everything compiles fine but when I run the page I get a NullReferenceException was unhandled at the line:

@if (Model.Accounts != null)

Why am I getting a null reference exception on a check for a null reference? What am I missing?

I think @ZachJohnson hit it, but also it's standard practice to make any kind of collection default to an empty set. It saves you headaches down the road and from testing null with every use. — Brad Christie, Oct 13 '11 at 14:18
OffTopic: Model.Accounts != null isn't really checking if there arent any account object in the list.. It checks if the list itself is null.. — Rob, Oct 13 '11 at 14:19
See http://stackoverflow.com/questions/4660142/what-is-a-nullreferenceexception-in-net — John Saunders, Oct 13 '11 at 14:19

score 10 · Accepted Answer · edited Jan 13 '17 at 13:33

10

because Model is null and not the property Accounts.

You should check also if Model is not null

Example:

if(Model != null && Model.Accounts != null)
{

}

edited Jan 13 '17 at 13:33

Binarian

11,710
8
50
82

answered Oct 13 '11 at 14:17

fixagon

5,336
19
25

score 3 · Answer 2 · answered Oct 13 '11 at 14:17

3

Obviously Model is null, you've to change condition to

Model != null && Model.Accounts != null

answered Oct 13 '11 at 14:17

sll

56,967
21
100
149

score 2 · Answer 3 · answered Oct 13 '11 at 14:17

2

Your model is probably null

@if (Model != null && Model.Accounts != null)

answered Oct 13 '11 at 14:17

hunter

58,834
17
108
112

score 1 · Answer 4 · answered Oct 13 '11 at 14:18

1

Without seeing the Action method, I'm assuming your Model is null (which is the only way you would get that error on that line). Just need an extra check:

if(Model != null && Model.Accounts != null)

answered Oct 13 '11 at 14:18

Justin Niessner

229,755
35
391
521

Why do I get a NullReferenceException when checking for null in the view

4 Answers4

Example: