Notification passes old Intent Extras

Question

i am creating a notification inside a BroadcastReceiver via this code:

String ns = Context.NOTIFICATION_SERVICE;
        NotificationManager mNotificationManager = (NotificationManager) context.getSystemService(ns);
        int icon = R.drawable.ic_stat_notification;
        CharSequence tickerText = "New Notification";
        long when = System.currentTimeMillis();

        Notification notification = new Notification(icon, tickerText, when);
        notification.defaults |= Notification.DEFAULT_VIBRATE;
        long[] vibrate = {0,100,200,200,200,200};
        notification.vibrate = vibrate;
        notification.flags |= Notification.FLAG_AUTO_CANCEL;

        CharSequence contentTitle = "Title";
        CharSequence contentText = "Text";
        Intent notificationIntent = new Intent(context, NotificationActivity.class);
        notificationIntent.putExtra(Global.INTENT_EXTRA_FOO_ID, foo_id);
PendingIntent contentIntent = PendingIntent.getActivity(context, 0, notificationIntent, 0);

        notification.setLatestEventInfo(context, contentTitle, contentText, contentIntent);

        int mynotification_id = 1;

        mNotificationManager.notify(mynotification_id, notification);

When I click on the notification, it opens the NotificationActivity and inside the Activity i can retrieve the foo_id from the Intent-Bundle (e.g. 1)

However if another notification is triggered and i click on it again, the activity still receives the "old" value (1) from the Intent-Bundle. I've tried to clear the bundle with clear(), but am receiving the same effect. I think sth is wrong with my code..

please can you tell me how do you get the data from pending intent — user49557, Nov 02 '15 at 06:18
to realise that it was sending old extras, made my triaging easier. — Utsav Gupta, Dec 13 '16 at 15:17

score 281 · Accepted Answer · answered Sep 10 '11 at 08:06

281

You are sending the same request code for your pending intens. Change this:

PendingIntent contentIntent = PendingIntent.getActivity(context, 0, notificationIntent, 0);

To:

PendingIntent contentIntent = PendingIntent.getActivity(context, UNIQUE_INT_PER_CALL, notificationIntent, 0);

intents are not created if you send the same params. They are reused.

answered Sep 10 '11 at 08:06

IncrediApp

10,083
2
29
24

1

so the UNIQUE_INT_PER_CALL is an Integer I have to provide? or is this a static variable declared somewhere? – BrianM Sep 10 '11 at 08:17
23

android gotcha #147 - so an `Intent` that has *different* extras (via `putExtra`) are considered the same and re-used because i did not provide a unique id to some pending intent call - terrible api – wal Nov 30 '16 at 07:07
you know what, I were so careless. Just thinking how could it remain 0 in one block (in my case) :( – Exigente05 Jan 27 '17 at 15:31
3

This was incredibly useful for me, just a tip for others, it is likely that you are building your notification in the same method, and so you can just set the id for the new pending intent to the same as the one you are going to use for the notifications unique id! – James McNee Jan 31 '17 at 15:39
1

@IncrediApp, is it same with PendingIntent.getBroadcast(); ? – Shruti Apr 20 '17 at 06:54

score 144 · Answer 2 · answered Feb 17 '12 at 14:38

144

Alternatively, you can use the following code to generate your PendingIntent:

PendingIntent contentIntent = PendingIntent.getActivity(context, 0, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);

From the doc for PendingIntent.FLAG_UPDATE_CURRENT:

If the described PendingIntent already exists, then keep it but replace its extra data with what is in this new Intent. This can be used if you are creating intents where only the extras change, and don't care that any entities that received your previous PendingIntent will be able to launch it with your new extras even if they are not explicitly given to it.

answered Feb 17 '12 at 14:38

ChristophK

3,009
2
22
28

Thanks...perfectly working for this flag which is add "PendingIntent.FLAG_UPDATE_CURRENT" :) – NAP Developer Nov 12 '14 at 08:57
1

Worked for me, using pending intent to transfer state from setting an alarm to the broadcast receiver. – William T. Mallard Mar 26 '15 at 20:45
I just wish i knew about what these flags really did before I sent notifications out to my users(!) Glad this resolves my woes... – James Andrew May 19 '17 at 23:51

score 43 · Answer 3 · edited Jul 20 '18 at 07:58

43

You are passing the same ID. In this kind of situation, make a unique id from time like this:

int iUniqueId = (int) (System.currentTimeMillis() & 0xfffffff);

And put it as this:

PendingIntent contentIntent = PendingIntent.getActivity(getApplicationContext(),iUniqueId, intentForNotification, 0);

edited Jul 20 '18 at 07:58

Rishabh Maurya

1,272
3
19
37

answered Aug 17 '12 at 06:29

hderanga

1,229
12
12

3

why not use new Random().nextInt() – exloong Dec 05 '16 at 05:58
@hderanga what does adding "& 0xfffffff" do to the int above? – AJW May 23 '18 at 19:54
3

@AJW `System.currentTimeMillis()` returns a long, while the `requestId` parameter of `PendingIntent.getActivity()` takes an int. `0xffffffff` is a bitmask. While there's a bit more to it, the simple explanation is that doing `long & 0xffffffff' gives the lowest 32-bits from the long and discards the highest 32-bits, leaving you with essentially a 32-bit int. This is better than simply casting to an int because it won't muck up the sign bit (if you cast a long that is bigger than an int to an int the sign bit will overflow and you'll potentially wind up with a negative value) – Jordan Dec 12 '18 at 22:57

Gentle · Answer 4 · 2019-11-09T03:01:00.483

9

For anyone looking for the best approach after a long time all, you need to pass the PendingIntent.FLAG_UPDATE_CURRENT as the last argument as shown below

PendingIntent contentIntent = PendingIntent.getActivity(context, 0, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);

you don't even need to provide a new unique id.

You need to do this for next time onwards not for the first time

edited Nov 09 '19 at 03:01

answered Mar 11 '17 at 12:29

Gentle

428
6
11

1

That doesn't work, i got here because thats what i was doing. – Brill Pappin May 09 '18 at 22:04
You need to do this for next times not for the first time, it will work. – Gentle May 16 '18 at 09:40

score 0 · Answer 5 · answered Feb 04 '18 at 09:03

0

Your request code is 0 for all the notification. Change following line:

PendingIntent contentIntent = PendingIntent.getActivity(context, 0, notificationIntent, 0);

With:

PendingIntent contentIntent = PendingIntent.getActivity(context, new Random().nextInt(), notificationIntent, 0);

answered Feb 04 '18 at 09:03

Faisal Shaikh

3,131
2
34
66

1

Is there any benefit to using "new Random().nextInt()" rather than "System.currentTimeMillis()"? – AJW May 23 '18 at 19:56
using random can easily regenerate the same integer value again on accident, thus causing a very hard to find bug of old intents being passed. – Sam May 30 '18 at 16:36
@AJW there was in my case. I created 2 different notifications in exact same millisecond, so one of them got wrong extras. – artman Jul 23 '18 at 09:47

score 0 · Answer 6 · answered Aug 29 '19 at 23:18

0

Just wanted to add another option

 PendingIntent.getBroadcast(context, 0, intent, PendingIntent.FLAG_ONE_SHOT | PendingIntent.FLAG_IMMUTABLE);

answered Aug 29 '19 at 23:18

pellucide

2,868
2
18
23

Notification passes old Intent Extras

6 Answers6

Linked