When I try to read from a file, the first and third words of the file are skipped for some reason

Question

In my program I'm trying to read from some files, store the data into structs, and sort/display the data for an assignment. However, it wasn't quite working right, and after some troubleshooting I noticed that from every read file, the first and third words are skipped for some reason.

The relevant code:

void fillArray(string filename, string arr[])
{
    ifstream ifile(filename);
    int count = 0;
    while (getline(ifile, arr[count++]))
    {
        getline(ifile, arr[count]);
        count++;
    }
    ifile.close();
}

The relevant files are structured that after every word there's a newline, so getline only gets and stores one word per iteration. Also, it may be relevant as well that the files being read from are entered as arguments via the command prompt.

This loop makes no sense ar all. If you have one word per line, you just do `while(getline(ifile, arr[count++]));` Why both `>>` and `getline` to the same destination? — n. 'pronouns' m., Nov 24 '20 at 05:49
Haha, I'm still pretty new. I'll edit it and see if that helps. — Davin Duran, Nov 24 '20 at 05:52
Related: [Why does std::getline skip input after a formatted extraction?](https://stackoverflow.com/questions/21567291/) — Remy Lebeau, Nov 24 '20 at 05:53

score 0 · Accepted Answer · answered Nov 24 '20 at 06:00

0

   while (ifile >> arr[count])
    {
        getline(ifile, arr[count]);
        count++;
    }

ifile >> arr[count] reads a word & without count being incremented, getline reads the rest of the line & overwrites what was read by ifile >> arr[count]

That may be the cause of some words being skipped - the words read by >> are overwritten.

answered Nov 24 '20 at 06:00

user93353

12,985
7
50
106

So I tried replacing `ifile >> arr[count]` with `getline(ifile, arr[count++])` in the condition and it works now! Thanks a ton. – Davin Duran Nov 24 '20 at 06:09

When I try to read from a file, the first and third words of the file are skipped for some reason

1 Answers1