Avg/Max from ArrayList

Question

I've had a ton of issues with this program, added a while hasNextInt, multiple other things and i've finally got the code working, but my output is just the first input, instead of max/avg of the inputs. Could somebody let me know where i'm messing up?


public class LabProgram {
   public static void main(String[] args) {
        Scanner scnr = new Scanner(System.in);
        int count = 0, max = 0, total = 0;

        int num = scnr.nextInt();
        
            if (num >= 0) {
               count++;
               total += num;
               max = Math.max(max, num);
               num = scnr.nextInt();
         }

        int avg = count == 0 ? 0 : total/count;
        System.out.println(avg + " " + max);
    }
}

Also you need to do `num = scnr.nextInt();` before you use the value of `num` in your `max` calculation — Scary Wombat, Oct 08 '20 at 01:13
Also your `avg` will be wrong due to http://stackoverflow.com/questions/4685450/why-is-the-result-of-1-3-0 — Scary Wombat, Oct 08 '20 at 01:14

score 1 · Answer 1 · answered Oct 08 '20 at 01:25

you are not using a loop to get numbers from the console. Also, logic for avg may result in the wrong answer. find below solution.

 Scanner scnr = new Scanner(System.in);
 int count = 0, max = 0, total = 0;

 System.out.println("Enter any other characters expect numbers to terminate:");

while(scnr.hasNextInt()) {
   int num = scnr.nextInt();
   if (num >= 0) {
       count++;
       total += num;
       max = Math.max(max, num);
   }
   }
  double avg = count == 0 ? 0 : (double)total/(double)count; // to print correct  avg
  System.out.println(avg + " " + max);

sample Output:

Enter any other characters expect numbers to terminate:
3
3
34
a
13.333333333333334 34

OP had better test for divide by zero as well. – Scary Wombat Oct 08 '20 at 01:41 — Scary Wombat, Oct 08 '20 at 01:41

Avg/Max from ArrayList

1 Answers1