Programme is terminating in c++;

Question

I have written the code which will print the slope from the coordinates of a line and then print it. but when I give input, my code is terminating. what is the problem?

#include<bits/stdc++.h>
using namespace std;

int main()
{
    int x1,y1,x2,y2,m;

    cin>>x1>>y1>>x2>>y2;

    m=(y1-y2)/(x1-x2);

    cout<<m;
}

https://stackoverflow.com/questions/31816095/why-should-i-not-include-bits-stdc-h/31816096#31816096 — Werner Henze, May 25 '20 at 17:55
What is your input? Why don't you check that the input could really be read? — Werner Henze, May 25 '20 at 17:56
[Why should I not #include ?](https://stackoverflow.com/q/31816095/5910058) — Jesper Juhl, May 25 '20 at 18:00
[Why is "using namespace std;" considered bad practice?](https://stackoverflow.com/q/1452721/5910058) — Jesper Juhl, May 25 '20 at 18:01
With that sample input you end up dividing by zero --> KaBoom! — Jesper Juhl, May 25 '20 at 18:03

score 4 · Answer 1 · answered May 25 '20 at 18:01

4

Problem is probably here m=(y1-y2)/(x1-x2);. When x1==x2 you have division by zero, please add some checks.

answered May 25 '20 at 18:01

ufoq

103
2
6

score 1 · Answer 2 · answered May 25 '20 at 18:11

Consider adding more corner tests, also note when x1 is equal to x2 you will face division by zero error, so you should modify your program with if statement to check that they are not equal.

so you should add this to your code:

if(x1==x2){
  cout<<"Error division by zero"<<endl;
  return 1;
}

score -1 · Answer 3 · answered May 25 '20 at 17:58

-1

The program works fine:

g++ x.cpp
./a.out
1 2 3 4 5
1⏎

answered May 25 '20 at 17:58

Ludwig Schulze

1,775
13
31

Try it with the first and third numbers the same! – Dipstick May 25 '20 at 18:00
1

if they are the same then you'll have division by zero, that's your problem – ufoq May 25 '20 at 18:00
@Dipstick giving 1 1 2 3 results in 2 – Ludwig Schulze May 25 '20 at 18:01
@Ludwig "terminated by signal SIGFPE (Floating point exception)" - Right, so the program does *not* "work fine". – Jesper Juhl May 25 '20 at 18:09
Can the moderator who deleted my comment (to which JesperJuhl responded) and deleted the one by @Dispstick (where Dipstick told my they had updated their comment) please explain what they expect me to do? Should I delete my response? Should I update it (and make the surviving comments meaningless)? – Ludwig Schulze Jun 21 '20 at 21:27
Maybe @JesperJuhl have any insights regarding my previous comment (1 minute ago)? – Ludwig Schulze Jun 21 '20 at 21:29

score -1 · Answer 4 · answered May 25 '20 at 18:00

-1

I tested your code using c++ compiler online and it worked.

You may have a compiler error or something else.

answered May 25 '20 at 18:00

omri klein

138
6

The program does *not* work for all input. It's trivial to provide input that causes it to divide by zero. That's not what I would call a "working" program. – Jesper Juhl May 25 '20 at 19:43
Not handling extreme cases does not mean the program is not working. The question didn't tell about the input that makes the program terminate. I also said that the error can be something else (for example, input), but it generally works. – omri klein May 25 '20 at 19:54
Passing two identical numbers to something that subtracts them and then does a division is hardly an *extreme* case. – Jesper Juhl May 25 '20 at 19:55

Programme is terminating in c++;

4 Answers4