572

In Ruby some methods have a question mark (?) that ask a question like include? that ask if the object in question is included, this then returns a true/false.

But why do some methods have exclamation marks (!) where others don't?

What does it mean?

dreftymac
  • 27,818
  • 25
  • 108
  • 169
Lennie
  • 9,525
  • 5
  • 20
  • 13
  • 22
    synonym: bang, exclamation mark – prusswan Jul 03 '12 at 06:12
  • 17
    The accepted answer should be changed to http://stackoverflow.com/a/612653/109618. See http://www.wobblini.net/bang.txt and http://www.ruby-forum.com/topic/176830#773946 -- "The bang sign means "the bang version is more dangerous than its non bang counterpart; handle with care"" -Matz – David J. Jul 30 '12 at 20:09
  • 3
    The bang method would be a great design choice if **only** and **all** bang methods were dangerous. Sadly they are not, and so it becomes a frustrating exercise in memorising what is and isn't mutable. – Damien Roche Sep 03 '14 at 22:18

10 Answers10

653

In general, methods that end in ! indicate that the method will modify the object it's called on. Ruby calls these as "dangerous methods" because they change state that someone else might have a reference to. Here's a simple example for strings:

foo = "A STRING"  # a string called foo
foo.downcase!     # modifies foo itself
puts foo          # prints modified foo

This will output:

a string

In the standard libraries, there are a lot of places you'll see pairs of similarly named methods, one with the ! and one without. The ones without are called "safe methods", and they return a copy of the original with changes applied to the copy, with the callee unchanged. Here's the same example without the !:

foo = "A STRING"    # a string called foo
bar = foo.downcase  # doesn't modify foo; returns a modified string
puts foo            # prints unchanged foo
puts bar            # prints newly created bar

This outputs:

A STRING
a string

Keep in mind this is just a convention, but a lot of Ruby classes follow it. It also helps you keep track of what's getting modified in your code.

inanc
  • 16,581
  • 8
  • 70
  • 83
Todd Gamblin
  • 54,111
  • 13
  • 87
  • 94
  • 2
    There's also cases like exit versus exit! and (in rails) save versus save! – Andrew Grimm Mar 04 '09 at 22:00
  • 27
    Be very careful - many smaller libraries don't follow this convention. If strange things are happening, often replacing obj.whatever! with obj=obj.whatever! fixes it. Very frustrating. – Sarah Mei Mar 04 '09 at 22:41
  • 107
    bang is also used for methods that raise an exception when the method without does not, e.g.: `save` and `save!` in `ActiveRecord` – ecoologic Oct 04 '11 at 15:22
  • What Save! actually does in Rails? – Abhi Dec 23 '13 at 07:14
  • 4
    @AbhilashAK [save!](http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html#method-i-save-21) raises an error if it cannot save. This is opposed to regular save returning true/false. – BookOfGreg Feb 16 '14 at 15:22
  • 34
    @tgamblin There are lots of methods in Ruby that mutate without bangs. There are even rare methods that do not mutate WITH a bang but do something surprising like raise errors or skip errors. Bangs are used to say this is the more unusual version of the method and I think this should be reflected in your answer since it is marked as correct. – BookOfGreg Feb 16 '14 at 15:24
  • 3
    Ha! I love it. What an obscenely crazy language. – Darth Egregious Sep 17 '14 at 13:49
  • @ecoologic I arrived here after learning of that use of `!` from [here](https://stackoverflow.com/a/20866572/5783745). How can we read more about that use? (and it seems odd to use the same character for two totally different things? - I wonder why that design choice was made) – stevec Sep 09 '20 at 20:41
  • ActiveRecord is a good example of cryptic behaviour (mutability), you need to call `valid?` (save does it) to have the errors filled. The bang is also used for "dangerous" methods throwing exceptions like `save!`. It's a loose convention we can't rely too much on it. I suggest you're clear with the team what you mean the `!` for all projects. – ecoologic Sep 10 '20 at 12:33
151

The exclamation point means many things, and sometimes you can't tell a lot from it other than "this is dangerous, be careful".

As others have said, in standard methods it's often used to indicate a method that causes an object to mutate itself, but not always. Note that many standard methods change their receiver and don't have an exclamation point (pop, shift, clear), and some methods with exclamation points don't change their receiver (exit!). See this article for example.

Other libraries may use it differently. In Rails an exclamation point often means that the method will throw an exception on failure rather than failing silently.

It's a naming convention but many people use it in subtly different ways. In your own code a good rule of thumbs is to use it whenever a method is doing something "dangerous", especially when two methods with the same name exist and one of them is more "dangerous" than the other. "Dangerous" can mean nearly anything though.

Brian Carper
  • 66,618
  • 25
  • 158
  • 164
77

This naming convention is lifted from Scheme.

1.3.5 Naming conventions

By convention, the names of procedures that always return a boolean value usually end in ``?''. Such procedures are called predicates.

By convention, the names of procedures that store values into previously allocated locations (see section 3.4) usually end in ``!''. Such procedures are called mutation procedures. By convention, the value returned by a mutation procedure is unspecified.

Steven Huwig
  • 17,999
  • 8
  • 53
  • 78
24

! typically means that the method acts upon the object instead of returning a result. From the book Programming Ruby:

Methods that are "dangerous," or modify the receiver, might be named with a trailing "!".

jww
  • 83,594
  • 69
  • 338
  • 732
Pesto
  • 23,272
  • 2
  • 67
  • 76
21

It is most accurate to say that methods with a Bang! are the more dangerous or surprising version. There are many methods that mutate without a Bang such as .destroy and in general methods only have bangs where a safer alternative exists in the core lib.

For instance, on Array we have .compact and .compact!, both methods mutate the array, but .compact! returns nil instead of self if there are no nil's in the array, which is more surprising than just returning self.

The only non-mutating method I've found with a bang is Kernel's .exit! which is more surprising than .exit because you cannot catch SystemExit while the process is closing.

Rails and ActiveRecord continues this trend in that it uses bang for more 'surprising' effects like .create! which raises errors on failure.

Community
  • 1
  • 1
BookOfGreg
  • 3,204
  • 37
  • 52
18

From themomorohoax.com:

A bang can used in the below ways, in order of my personal preference.

1) An active record method raises an error if the method does not do what it says it will.

2) An active record method saves the record or a method saves an object (e.g. strip!)

3) A method does something “extra”, like posts to someplace, or does some action.

The point is: only use a bang when you’ve really thought about whether it’s necessary, to save other developers the annoyance of having to check why you are using a bang.

The bang provides two cues to other developers.

1) that it’s not necessary to save the object after calling the method.

2) when you call the method, the db is going to be changed.

http://www.themomorohoax.com/2009/02/11/when-to-use-a-bang-exclamation-point-after-rails-methods

Edward Castaño
  • 587
  • 1
  • 7
  • 14
6

Simple explanation:

foo = "BEST DAY EVER" #assign a string to variable foo.

=> foo.downcase #call method downcase, this is without any exclamation.

"best day ever"  #returns the result in downcase, but no change in value of foo.

=> foo #call the variable foo now.

"BEST DAY EVER" #variable is unchanged.

=> foo.downcase! #call destructive version.

=> foo #call the variable foo now.

"best day ever" #variable has been mutated in place.

But if you ever called a method downcase! in the explanation above, foo would change to downcase permanently. downcase! would not return a new string object but replace the string in place, totally changing the foo to downcase. I suggest you don't use downcase! unless it is totally necessary.

BookOfGreg
  • 3,204
  • 37
  • 52
Mirage
  • 1,429
  • 14
  • 26
2
!

I like to think of this as an explosive change that destroys all that has gone before it. Bang or exclamation mark means that you are making a permanent saved change in your code.

If you use for example Ruby's method for global substitutiongsub!the substitution you make is permanent.

Another way you can imagine it, is opening a text file and doing find and replace, followed by saving. ! does the same in your code.

Another useful reminder if you come from the bash world is sed -i has this similar effect of making permanent saved change.

1

Bottom line: ! methods just change the value of the object they are called upon, whereas a method without ! returns a manipulated value without writing over the object the method was called upon.

Only use ! if you do not plan on needing the original value stored at the variable you called the method on.

I prefer to do something like:

foo = "word"
bar = foo.capitalize
puts bar

OR

foo = "word"
puts foo.capitalize

Instead of

foo = "word"
foo.capitalize!
puts foo

Just in case I would like to access the original value again.

Charles
  • 1,307
  • 11
  • 16
  • 1
    Because your answer was not helpful in any way. "Bottom line: ! methods just change the value of the object they are called upon" is just not true. – Darwin Aug 08 '16 at 12:28
  • @Darwin it _does_ change the value of the object. `!` mutates the object rather than returning a modified copy. – Charles Aug 08 '16 at 19:02
  • So what do you think this does? `User.create!` – Darwin Aug 09 '16 at 07:52
  • @Darwin in what context? ActiveRecord? – Charles Aug 09 '16 at 23:29
  • Yes, ActiveRecord. – Darwin Aug 10 '16 at 07:34
  • Heres a better argument for why your answers is plain wrong. Read Matz comment on bang "!". https://www.ruby-forum.com/topic/176830#773946. Do you still feel that your "Bottom line: ! methods just change the value of the object they are called upon" is true in any way what so ever? – Darwin Aug 10 '16 at 07:38
  • @Darwin: Completely true? No, and I see that now. "In any way whatsoever?" Yes. Modifying its argument, or the object upon which a `!` method is called, is obviously "dangerous" -- that goes without saying; any method that mutates any of its arguments is _dangerous_ because you could lose data. I'll admit: I was taught that `!` modifies its object and I never really questioned that. So I thank you for this. – Charles Aug 11 '16 at 15:16
1

Called "Destructive Methods" They tend to change the original copy of the object you are referring to.

numbers=[1,0,10,5,8]
numbers.collect{|n| puts n*2} # would multiply each number by two
numbers #returns the same original copy
numbers.collect!{|n| puts n*2} # would multiply each number by two and destructs the original copy from the array
numbers   # returns [nil,nil,nil,nil,nil]