createReadStream() throwing RangeError: Maximum call stack size exceeded when uploading file

Question

I am trying to use Apollo Server's Upload scalar to send files to S3 directly. My schema:

const { gql } = require('apollo-server-express')

module.exports = gql`

extend type Mutation {
  createPicture(
    name: String!
    picture: Upload!
  ): Picture!
}

type Picture {
  name: String!
  picture: String!
}
`

Resolver:

const { combineResolvers } = require('graphql-resolvers')
const isAuthenticated = require('./auth')
const { uploadPhoto } = require('../services/picture')

module.exports = {
  Mutation: {
    createPicture: combineResolvers(
      isAuthenticated,
      async (
        parent,
        { name, picture = null },
        { models, me }
      ) => {
        const { createReadStream, filename, mimetype, encoding } = await picture
        // Does not get past this line
        const stream = createReadStream()

        uploadPhoto(stream, filename)

        const pictureModel = models.Picture.create({
           name,
           picture
        })
        return pictureModel
      }
    )
  }
}

But my code errors like this:

internal/util.js:55
  function deprecated(...args) {
                     ^

RangeError: Maximum call stack size exceeded
    at ReadStream.deprecated [as open] (internal/util.js:55:22)
    at ReadStream.open ([truncated]/node_modules/fs-capacitor/lib/index.js:90:11)
    at _openReadFs (internal/fs/streams.js:123:12)
    at ReadStream.<anonymous> (internal/fs/streams.js:116:3)
    at ReadStream.deprecated [as open] (internal/util.js:70:15)
    at ReadStream.open ([truncated]/node_modules/fs-capacitor/lib/index.js:90:11)
    at _openReadFs (internal/fs/streams.js:123:12)
    at ReadStream.<anonymous> (internal/fs/streams.js:116:3)
    at ReadStream.deprecated [as open] (internal/util.js:70:15)
    at ReadStream.open ([truncated]/node_modules/fs-capacitor/lib/index.js:90:11)
    at _openReadFs (internal/fs/streams.js:123:12)
    at ReadStream.<anonymous> (internal/fs/streams.js:116:3)
    at ReadStream.deprecated [as open] (internal/util.js:70:15)
    at ReadStream.open ([truncated]/node_modules/fs-capacitor/lib/index.js:90:11)
    at _openReadFs (internal/fs/streams.js:123:12)
    at ReadStream.<anonymous> (internal/fs/streams.js:116:3)
    at ReadStream.deprecated [as open] (internal/util.js:70:15)
    at ReadStream.open ([truncated]/node_modules/fs-capacitor/lib/index.js:90:11)
    at _openReadFs (internal/fs/streams.js:123:12)
    at ReadStream.<anonymous> (internal/fs/streams.js:116:3)
    at ReadStream.deprecated [as open] (internal/util.js:70:15)
    at ReadStream.open ([truncated]/node_modules/fs-capacitor/lib/index.js:90:11)

Note: I am sure the image was sent correctly, as filename is correct

@jfriend00 From here: https://github.com/jaydenseric/graphql-upload#type-fileupload — W. Reyna, Jan 07 '20 at 01:22

score 10 · Accepted Answer · answered Jan 07 '20 at 01:55

10

Turns out it was this bug in graphql-upload. Downgraded to node 12 and it's fixed (solution listed there did not help me)

answered Jan 07 '20 at 01:55

W. Reyna

594
5
19

don't need this anymore, use this answer instead: https://stackoverflow.com/a/67083012/12411087, worked for me – DaviMendesDev Apr 17 '21 at 17:20
I tried everything but notihng works :-( Can anyone help me pls? – Juliano Costa Apr 22 '21 at 17:18

score 10 · Answer 2 · answered Jun 13 '20 at 01:16

10

Add this to package.json:

"resolutions": {
    "**/**/fs-capacitor":"^6.2.0",
    "**/graphql-upload": "^11.0.0"
  }

source: https://github.com/jaydenseric/graphql-upload/issues/170#issuecomment-641938198

answered Jun 13 '20 at 01:16

Meursault

166
2
7

1

This approach works correctly. – Gabriel Balsa Cantú Jan 14 '21 at 23:41

score 4 · Answer 3 · answered Jun 11 '20 at 04:44

4

This error occured to me in node version 14 too! I solved it as follows:

Install latest version of graphql-upload !

use graphqlUploadExpress middleware to define the maximum file limit.

import { graphqlUploadExpress } from "graphql-upload";
const app = express()
app.use(graphqlUploadExpress({ maxFileSize: 1000000000, maxFiles: 10 }));

Set uploads to false while initializing the ApolloServer

  const server = new ApolloServer({
    uploads: false,
    schema,
  });

answered Jun 11 '20 at 04:44

Ashish Bastola

161
5

could you explain why we need to set the uploads to false? why does the OP need to install a separate library for this to work now? – Johhan Santana Jan 08 '21 at 20:38
1

@JohhanSantana Apollo server bundles inside a clone of graphql-upload that is broken on Node 14. To use the newer fixed graphql-upload package you need to tell apollo not to use it's bundled one. and then use it yourself by registering the body handler with express and adding the upload schema stuff. – Tamir Daniely Feb 28 '21 at 08:14
This answer is really the correct one, just remember to call `app.use(graphqlUploadExpress({ maxFileSize: 1000000000, maxFiles: 10 }));` before applying Apollo sever middleware. – Marek Piechut Mar 30 '21 at 11:25
Hi dude.I did this but now I'm getting another error: "message": "args.file.then is not a function", Here is my code: const singleUpload = (parent, args) => { return args.file.then((file) => { const { createReadStream, filename } = file const fileStream = createReadStream() fileStream.pipe(fs.createWriteStream(`../../assets/img/grid/${filename}`)) return file }) } – Juliano Costa Apr 22 '21 at 13:38

pranav shinde · Answer 4 · 2021-05-06T10:17:26.807

2

Add this to your package.json

 "resolutions": {
    "graphql-upload": "^11.0.0"
  }

then add this inside scripts

"scripts": {
    ....
    "preinstall": "npx npm-force-resolutions", //This one
    ....
}

then you need to do npm install. Done

Source: graphql-upload

edited May 06 '21 at 10:17

answered Feb 15 '21 at 01:00

pranav shinde

352
2
7

Thanks, this saves me a lot – DaviMendesDev Apr 17 '21 at 17:18

score 2 · Answer 5 · answered Apr 13 '21 at 22:08

2

Since it is a bug with fs-capacitor, this would help as we can see in this issue

Worked for me in node 14.16.1 with the following configuration:

"resolutions": {
    "fs-capacitor": "^6.2.0",
    "graphql-upload": "^11.0.0"
}

I needed to add force-resolutions inside "scripts"

"scripts": {
    ....
    "preinstall": "npx npm-force-resolutions"
}

Remove ./node_modules and install dependencies again with npm install.

answered Apr 13 '21 at 22:08

Everton Castro

119
1
8

Thanks, this saves me a lot – DaviMendesDev Apr 17 '21 at 17:18

score 0 · Answer 6 · answered Apr 02 '21 at 13:49

I've been dealing with this problem multiple times

the problem is old graphql-upload more accurately version 8 uses of node open stream function which is deprecated and no longer available in 13.x and older node versions.

so the solution is you can either use nvm to set your node version to 12 or use resolutions in your package.json file. first solution(in your favorite terminal):

nvm install 12; nvm use 12

second solution(in package.json):

"resolutions": {
    "**/**/fs-capacitor":"^6.2.0",
    "**/graphql-upload": "^11.0.0"
  }

also this is a problem I've been dealing with for months and apollo team really doesn't like updating their dependencies I think.

score -2 · Answer 7 · answered Oct 20 '20 at 14:36

-2

Using:

    "apollo-server": "^2.18.2",
    "apollo-server-express": "2.18.2",
    "aws-sdk": "^2.771.0",
    "express-fileupload": "^1.2.0",
    "graphql": "^15.3.0",
    "graphql-upload": "^11.0.0",
    "fs-capacitor": "^6.2.0",

I solve this by installing the latest fs-capacitor as a dependency

yarn add fs-capacitor

answered Oct 20 '20 at 14:36

msroot

781
10
13

Adding fs-capacitor 6.2.0 as a resolution worked for me. – Forrest Wilkins Jan 18 '21 at 18:03

createReadStream() throwing RangeError: Maximum call stack size exceeded when uploading file

7 Answers7

Linked