I'm trying to get the input for variables in private members of a class

Question

this is my code

#include <iostream>
#include <string>
using namespace std;

class Hamoud{
      private: 
      char name[50];
      int yearbirthday;

    public: 
        float tall;
        int age;
        void Getnameandyear(string name)
{
    std::array<char, 50> ;
    cout<<"enter your name: ";
    getline(nama);
    int year;
    year = yearbirthday;
    cout<<"enter your name: ";
    getchar(name);
    cout<<"Enter your year of birth";
    cin>>year;
}
    void display()
{
    cout<<"your name is: "<<name;
    cout<<"your year of birth is : "<<year;

}
};
int main ()
{
    Hamoud info;
    cout<<"enter your tall ";
    cin>>info.tall;
    cout<<"your tall is : "<<info.tall;
    cout<<"enter your age: ";
    cin>>info.age;
    cout<<"your age is: "<<info.age;
    info.Getnameandyear();
    info.display();

}

but i got errors in the function getnameandyear also in display function as well... i know that to access the private members of the class we have to create a function in public that will help us on access then indirectly.... However, I'm getting stuck on the last few steps.. Any idea of how to solve this problem ??

`nama[50] = name[50]` doesn't do what you think. It is actually UB. prefer `std::array` or even `std::string`. — Jarod42, Dec 02 '19 at 09:47
_"i tried std::string"_: show that code, otherwise it's hard to help. Also chosing `nama` and `name` for two different things doesn't help for readability of your code. — Jabberwocky, Dec 02 '19 at 09:51
Please do not post code in comments, [edit] the question instead. — Max Langhof, Dec 02 '19 at 09:57
Why does the function `Getnameandyear(string name)` expect an argument? You are using it without arguments. — Thomas Sablik, Dec 02 '19 at 10:09

Jabberwocky · Answer 1 · 2019-12-02T13:40:45.950

You probably want something like this:

#include <iostream>
#include <string>
using namespace std;

class Hamoud {
private:
  string name;
  int yearbirthday;

public:
  float tall;
  int age;

  void Getnameandyear()
  {
    // no need for std::array<char, 50> or whatever here anyway
    cout << "enter your name: ";
    cin.ignore();   // this clears the input buffer. The exact reason why
                    // we need this is beyond your scope for the moment
    getline(cin, name);

    cout << "Enter your year of birth: ";
    cin >> yearbirthday;
  }

  void display()
  {
    cout << "your name is: " << name << "\n";
    cout << "your year of birth is: " << yearbirthday << "\n";
  }
};

int main()
{
  Hamoud info;
  cout << "enter your tall ";
  cin >> info.tall;
  cout << "your tall is: " << info.tall << "\n";
  cout << "enter your age: ";
  cin >> info.age;
  cout << "your age is: " << info.age << "\n";
  info.Getnameandyear();
  info.display();
}

But anyway, I think you should start reading good beginner's C++ text book.

About the cin.ignore(); before getline: the exact reason is a bit beyond your scope for the moment, but you can find detailed information about this issue in this SO article.

I'm trying to get the input for variables in private members of a class

1 Answers1