Store Function Return Value into a Variable

Question

I have these codes to find the size of an input, and extract the integer from the input:

void getInteger(string s) {

    stringstream str_strm;
    str_strm << s;
    string temp_str;
    int temp_int;
    while (!str_strm.eof()) {
        str_strm >> temp_str;
        if (stringstream(temp_str) >> temp_int) {
            cout << temp_int << "";
        }
        temp_str = "";
    }

}


int main()
{
    string myString;
    int totalChar;
    getline(cin, myString);
    int stringLength = myString.length();
    cout << stringLength << endl;;
    getInteger(myString);

}

How can I store the getInteger value into a variable so that I can compare/sum its value to the integer? For example, the input is:

I love 6

So the code should count the total characters and the integer of the input:

8 + 6 = 14

What do you want the code to do if there are *two* numbers in the string (e.g. "I love 6 and 12")? — Beta, Sep 29 '19 at 18:38
@Beta Assume the input will only have one integer at this moment. — Mohd Fairuz, Sep 29 '19 at 18:43
Then there is no reason to keep scanning after finding the number. Is that enough of a clue? — Beta, Sep 29 '19 at 18:45
See [Why !.eof() inside a loop condition is always wrong.](https://stackoverflow.com/q/5605125/9254539) — David C. Rankin, Sep 29 '19 at 19:05

score 0 · Accepted Answer · answered Sep 29 '19 at 19:59

If you have a function that will extract an integer and include that integer in the output of a sum of the .length() and the integer, form all of your output in the function itself rather than complicating things and losing control of the initial input by doing part of the input in main() and part in your function.

Approaching things in that manner you put complete control over your output in a single function. For example in your case, if there was no integer found how would you "un-output" the length?

Putting those changes in place, your function could be similar to:

void getint (std::string s)
{
    int val,                        /* var to hold int value */
        found = 0;                  /* flag indicating if int was found */
    size_t len = s.length();        /* get length of s */
    std::string tmp;                /* temporary string to read into from ss */
    std::stringstream ss (s);       /* create stringstream from string */

    while (ss >> tmp) {             /* read from ss */
        try {                       /* stoi must have exception handler */
            val = stoi (tmp);       /* attempt conversion */
            found = 1;              /* on success set found flag */
            break;                  /* break loop */
        }
        catch (const std::exception & e) {  /* catch exception get next word */
            continue;
        }
    }
    if (found)  /* if integer found, output your sum */
        std::cout << len << " + " << val << " = " << len + val << '\n';
    else        /* otherwise handle error */
        std::cerr << "error: no integer value in input.\n";
}

(note: the only error handling needed if no conversion takes place is to get the next word. Any output will just add lines between the input and your desired output)

An example program utilizing the function could be:

#include <iostream>
#include <sstream>
#include <string>

void getint (std::string s)
{
    int val,                        /* var to hold int value */
        found = 0;                  /* flag indicating if int was found */
    size_t len = s.length();        /* get length of s */
    std::string tmp;                /* temporary string to read into from ss */
    std::stringstream ss (s);       /* create stringstream from string */

    while (ss >> tmp) {             /* read from ss */
        try {                       /* stoi must have exception handler */
            val = stoi (tmp);       /* attempt conversion */
            found = 1;              /* on success set found flag */
            break;                  /* break loop */
        }
        catch (const std::exception & e) {  /* catch exception get next word */
            continue;
        }
    }
    if (found)  /* if integer found, output your sum */
        std::cout << len << " + " << val << " = " << len + val << '\n';
    else        /* otherwise handle error */
        std::cerr << "error: no integer value in input.\n";
}

int main (void) {

    std::string s;

    if (getline (std::cin, s))
        getint (s);
    else
        std::cerr << "stream error or user canceled.\n";
}

Example Use/Output

$ ./bin/lengthaddition
I love 6
8 + 6 = 14

with no integer in input

$ ./bin/lengthaddition
I love B
error: no integer value in input.

Look things over and let me know if you have further questions.

Store Function Return Value into a Variable

1 Answers1