Evaluating src in javascript

Asked Aug 04 '19 at 07:48

Active Aug 04 '19 at 07:55

Viewed 21 times

I am trying to define the src in eval() but not working !! the eval line is not working. This is google console taking the error. The hyperlink is not working.

<!doctype html>
<html lang="en"> 
<head>
    <meta charset="UTF-8">
    <title>Document</title>
    <link rel="stylesheet" href="style.css">
    <script>
        var num = 1
        img1 = new Image()
        img1.src= "images/slide1.jpg"
        img2 = new Image()
        img2.src= "images/slide2.jpg"
        img3 = new Image()
        img3.src= "images/slide3.jpg"

        function slideShow(){
            num = num + 1
            if(num == 4){
                num = 1
            }
        document.slide.src = eval("img" + num + ".src")//having problem in this line
        }
    </script>
</head>
<body>
    <div class="slider">
        <img src="images/slide1.jpg" alt="">
        <a href="javascript:slideShow();">Click here for next image</a>
    </div>

</body>
</html>

edited Aug 04 '19 at 07:55

asked Aug 04 '19 at 07:48

Jency

Why would you use `eval` there? Better to remove it entirely, it serves no purpose – CertainPerformance Aug 04 '19 at 07:50
what can i use instead ? – Jency Aug 04 '19 at 07:51
Nothing at all, you're already concatenating, you don't need an `eval` call on top of it – CertainPerformance Aug 04 '19 at 07:51
Removing it, console reads: Uncaught TypeError: Cannot set property 'src' of undefined – Jency Aug 04 '19 at 07:56
Indeed, see the linked question – CertainPerformance Aug 04 '19 at 07:56
I haven't learned jquery yet and this single line is hampering the whole code. I will see what I can get from the linked answer. – Jency Aug 04 '19 at 08:01
There's no need at all for jQuery, don't worry – CertainPerformance Aug 04 '19 at 08:01
the problem was actually in the image tag... there should be another attribute: name="slide"... Solved – Jency Aug 04 '19 at 08:06
1

You should be using standard DOM methods to access elements, rather than relying on `document` properties. Use `document.querySelector` to select an element instead – CertainPerformance Aug 04 '19 at 08:07
Yes, that's a better option to choose – Jency Aug 04 '19 at 08:08

Evaluating src in javascript

0 Answers0