Checking image name using javascript

Question

I'm changing the img src on click using javascript.

I'm trying to determine whether to switch on or off.

I'm testing the following:

var img_el = document.getElementById("on_off_img");
if ( img_el.src == 'img/on.png' ) {

  img_el.src = 'img/off.png'
} else {

  img_el.src = 'img/on.png'
}

My problem is that i never get a match - it looks like img_el.src returns the full URL... Is there a function to just test the actual filename instead of the full string to the file?

Or is there a better way to manage the click?

score 5 · Accepted Answer · answered Apr 09 '11 at 07:25

5

use indexOf() instead of comparing the src

e.g

var img_el = document.getElementById("on_off_img");
if ( img_el.src.indexOf('on.png') > -1) {
  img_el.src = 'img/off.png'
} else {

  img_el.src = 'img/on.png'
}

answered Apr 09 '11 at 07:25

Chris Marais

411
2
10

score 2 · Answer 2 · answered Apr 09 '11 at 07:26

2

Yuo can always use indexOf:

if(img_el.src.indexOf('img/on.png') > -1){
  img_el.src = 'img/off.png'
}else{
  img_el.src = 'img/on.png'
}

answered Apr 09 '11 at 07:26

tcooc

18,644
3
34
53

score 1 · Answer 3 · answered Sep 01 '13 at 13:33

1

You can use match statement aswell.

var img_el = document.getElementById("on_off_img");
if ( img_el.src.match("on.png")) 
{
  img_el.src = 'img/off.png'
} else 
{
  img_el.src = 'img/on.png'
}

answered Sep 01 '13 at 13:33

Ganga Raju K

11
1

score 1 · Answer 4 · edited May 23 '17 at 11:43

1

To shorten this even more, you can use a ternary operator:

var img_el = document.getElementById("on_off_img"),
    isOn   = img_el.src.indexOf('on.png')>-1;
img_el.src = isOn ? 'img/off.png' : 'img/on.png';

edited May 23 '17 at 11:43

Community

1
1

answered Apr 09 '11 at 07:52

KooiInc

104,388
28
131
164

score 0 · Answer 5 · answered Apr 09 '11 at 07:58

0

Try using JQuery:

$("#on_off_img").click(function(){
    if($(this)[0].nameProp == "on.png")
        $(this).attr("src","img/off.png");
    else
        $(this).attr("src","img/on.png");         
});

answered Apr 09 '11 at 07:58

Sukhjeevan

3,288
7
41
84

Checking image name using javascript

5 Answers5