41

App.js

import React, { Component } from "react";
import Select from "react-select";

const SELECT_OPTIONS = ["FOO", "BAR"].map(e => {
  return { value: e, label: e };
});

class App extends Component {
  state = {
    selected: SELECT_OPTIONS[0].value
  };

  handleSelectChange = e => {
    this.setState({ selected: e.value });
  };

  render() {
    const { selected } = this.state;
    const value = { value: selected, label: selected };
    return (
      <div className="App">
        <div data-testid="select">
          <Select
            multi={false}
            value={value}
            options={SELECT_OPTIONS}
            onChange={this.handleSelectChange}
          />
        </div>
        <p data-testid="select-output">{selected}</p>
      </div>
    );
  }
}

export default App;

App.test.js

import React from "react";
import {
  render,
  fireEvent,
  cleanup,
  waitForElement,
  getByText
} from "react-testing-library";
import App from "./App";

afterEach(cleanup);

const setup = () => {
  const utils = render(<App />);
  const selectOutput = utils.getByTestId("select-output");
  const selectInput = document.getElementById("react-select-2-input");
  return { selectOutput, selectInput };
};

test("it can change selected item", async () => {
  const { selectOutput, selectInput } = setup();
  getByText(selectOutput, "FOO");
  fireEvent.change(selectInput, { target: { value: "BAR" } });
  await waitForElement(() => getByText(selectOutput, "BAR"));
});

This minimal example works as expected in the browser but the test fails. I think the onChange handler in is not invoked. How can I trigger the onChange callback in the test? What is the preferred way to find the element to fireEvent at? Thank you

user2133814
  • 1,869
  • 1
  • 20
  • 28

7 Answers7

40

In my project, I'm using react-testing-library and jest-dom. I ran into same problem - after some investigation I found solution, based on thread: https://github.com/airbnb/enzyme/issues/400

Notice that the top-level function for render has to be async, as well as individual steps.

There is no need to use focus event in this case, and it will allow to select multiple values.

Also, there has to be async callback inside getSelectItem.

const DOWN_ARROW = { keyCode: 40 };

it('renders and values can be filled then submitted', async () => {
  const {
    asFragment,
    getByLabelText,
    getByText,
  } = render(<MyComponent />);

  ( ... )

  // the function
  const getSelectItem = (getByLabelText, getByText) => async (selectLabel, itemText) => {
    fireEvent.keyDown(getByLabelText(selectLabel), DOWN_ARROW);
    await waitForElement(() => getByText(itemText));
    fireEvent.click(getByText(itemText));
  }

  // usage
  const selectItem = getSelectItem(getByLabelText, getByText);

  await selectItem('Label', 'Option');

  ( ... )

}
momimomo
  • 401
  • 3
  • 3
  • 7
    I personally prefer this solution much more than the accepted answer, because you keep things like they are. On that way you really test things like they would be tested by a user. If you mock `react-select` you even need to test your own mock, which is somehow counterproductive.. also if you use more complex properties which `react-select` provides your mock also gets more complex and also hard to maintain IMHO – ysfaran Oct 24 '19 at 12:02
  • This answer works well and doesn't require mocks. Thanks! – Donn Felker Feb 19 '20 at 11:23
  • 1
    Have you gotten this to work with ant 4? I had a similar solution that worked well, but after upgrading it fails to find the option.. – Per H Mar 06 '20 at 12:18
  • Although I don't see the other solution as intrinsically wrong, I also prefer this solution as it would be closer to the real-world scenario. Thanks for sharing this, this helped me and my colleague solve something we were bumping our heads against for a while with no success in simulating the selection. – Herick Nov 05 '20 at 21:33
30

This got to be the most asked question about RTL :D

The best strategy is to use jest.mock (or the equivalent in your testing framework) to mock the select and render an HTML select instead.

For more info on why this is the best approach, I wrote something that applies to this case too. The OP asked about a select in Material-UI but the idea is the same.

Original question and my answer:

Because you have no control over that UI. It's defined in a 3rd party module.

So, you have two options:

You can figure out what HTML the material library creates and then use container.querySelector to find its elements and interact with it. It takes a while but it should be possible. After you have done all of that you have to hope that at every new release they don't change the DOM structure too much or you might have to update all your tests.

The other option is to trust that Material-UI is going to make a component that works and that your users can use. Based on that trust you can simply replace that component in your tests for a simpler one.

Yes, option one tests what the user sees but option two is easier to maintain.

In my experience the second option is just fine but of course, your use-case might be different and you might have to test the actual component.

This is an example of how you could mock a select:

jest.mock("react-select", () => ({ options, value, onChange }) => {
  function handleChange(event) {
    const option = options.find(
      option => option.value === event.currentTarget.value
    );
    onChange(option);
  }
  return (
    <select data-testid="select" value={value} onChange={handleChange}>
      {options.map(({ label, value }) => (
        <option key={value} value={value}>
          {label}
        </option>
      ))}
    </select>
  );
});

You can read more here.

Community
  • 1
  • 1
Giorgio Polvara - Gpx
  • 12,268
  • 5
  • 53
  • 55
  • 8
    @GiorgioPolvara-Gpx While I get the approach you are suggesting I am curious to know if that goes actually against the guiding principles of Testing Library. The lib encourages to test what the final user actually interacts with (so to me is more an integration/functional test rather that an unit test). In your approach you are mocking the external dependency (which is good for a unit test) but if the dependency gets updated there is the change to have a successful test on a failing software. What are your thoughts about it? – stilllife Aug 27 '19 at 08:20
  • @GiorgioPolvara-Gpx I read your blog and I'm using the `react-select/async` so I used `jest.mock("react-select/async",...` but I get a **Unable to find an element by: [data-testid="select"]** when trying `fireEvent.change(getByTestId("select"), { target: { value: "foo" } });` I have a `render()` and it's like the getByTestId is looking into it instead of the `jest.mock` block. What have I missed ? thx – Jérôme Oudoul Sep 18 '19 at 09:16
  • It looks like you're either not mocking correctly or not rendering the select. Have you tried to run `debug()` to see what's on the page? – Giorgio Polvara - Gpx Sep 18 '19 at 09:44
  • 4
    One should have absolutely no confidence in their component's test if they mock the component to this extent. I highly recommend NOT going with this approach. You're testing a completely different component in this situation. – Kyle Holmberg Sep 18 '19 at 18:07
  • It's a tradeoff between ease of testing and coverage. If your application is for 90% the select don't mock it. But, if you only use the select in some of your pages I don't think spending the time to figure out how to test the select is worth it. Of course ymmv – Giorgio Polvara - Gpx Sep 19 '19 at 09:34
  • I replaced `jest.mock("react-select/async",...` with `jest.mock("../Shared/LocalitySelect.jsx",...` `LocalitySelect.jsx` being my component that renders the react-select/async component itself. Not sure I'm on the right track here but I now get `TypeError: Cannot read property 'map' of undefined` at the beginning of `{loadOptions.map(({ label, value }) => (` Now how/where do I populate `loadOptions` if that makes any sense ?... – Jérôme Oudoul Sep 19 '19 at 15:51
  • 1
    It's hard for me to help you from here. Open a new question either here or on the official Spectrum page – Giorgio Polvara - Gpx Sep 21 '19 at 14:06
  • 5
    @GiorgioPolvara-Gpx i disagree that you should mock the third party library. if that library changes/breaks, i want to know about it (without necessarily reading the changelog/release notes), and tests are how that is going to happen. – mlg87 Dec 12 '19 at 19:01
  • polvara.me/posts/testing-a-custom-select-with-react-testing-library/ – Jacob Dec 24 '20 at 23:21
  • Another big downside of this approach is that it will force you to always have a label and a value in all components, even if your domain model does not require it... This way should not be taken – Giulio Caccin Feb 22 '21 at 11:44
9

Similar to @momimomo's answer, I wrote a small helper to pick an option from react-select in TypeScript.

Helper file:

import { getByText, findByText, fireEvent } from '@testing-library/react';

const keyDownEvent = {
    key: 'ArrowDown',
};

export async function selectOption(container: HTMLElement, optionText: string) {
    const placeholder = getByText(container, 'Select...');
    fireEvent.keyDown(placeholder, keyDownEvent);
    await findByText(container, optionText);
    fireEvent.click(getByText(container, optionText));
}

Usage:

export const MyComponent: React.FunctionComponent = () => {
    return (
        <div data-testid="day-selector">
            <Select {...reactSelectOptions} />
        </div>
    );
};
it('can select an option', async () => {
    const { getByTestId } = render(<MyComponent />);
    // Open the react-select options then click on "Monday".
    await selectOption(getByTestId('day-selector'), 'Monday');
});
Vestride
  • 2,652
  • 1
  • 14
  • 17
9

Finally, there is a library that helps us with that: https://testing-library.com/docs/ecosystem-react-select-event. Works perfectly for both single select or select-multiple:

From @testing-library/react docs:

import React from 'react'
import Select from 'react-select'
import { render } from '@testing-library/react'
import selectEvent from 'react-select-event'

const { getByTestId, getByLabelText } = render(
  <form data-testid="form">
    <label htmlFor="food">Food</label>
    <Select options={OPTIONS} name="food" inputId="food" isMulti />
  </form>
)
expect(getByTestId('form')).toHaveFormValues({ food: '' }) // empty select

// select two values...
await selectEvent.select(getByLabelText('Food'), ['Strawberry', 'Mango'])
expect(getByTestId('form')).toHaveFormValues({ food: ['strawberry', 'mango'] })

// ...and add a third one
await selectEvent.select(getByLabelText('Food'), 'Chocolate')
expect(getByTestId('form')).toHaveFormValues({
  food: ['strawberry', 'mango', 'chocolate'],
})

Thanks https://github.com/romgain/react-select-event for such an awesome package!

Constantin
  • 1,446
  • 10
  • 14
  • works like a charm, eve with Formik and chakra-ui embedded react-select – STEEL Mar 30 '21 at 05:30
  • good stuff react-select-event, I've been struggling with testing react-select properly – KlsLondon Apr 01 '21 at 10:22
  • `react-select` is an awesome package if you want something out of the box. Unfortunately, accessibility and testing are painful. Also, it brings emotion to the project, which is not light, Switched to `downshift` a year ago and will never look back. It requires a little setup, but the result is lighter, easier to test, and accessible out of the box. – Constantin Apr 03 '21 at 03:16
1

This solution worked for me.

fireEvent.change(getByTestId("select-test-id"), { target: { value: "1" } });

Hope it might help strugglers.

  • 2
    `react-select` doesn't pass any `data-testid` to any of its children elements, and you can't do so by providing it by yourself. Your solution works for regular `select` HTML elements, but I'm afraid it won't work for `react-select` lib. – Stanley Sathler Nov 18 '20 at 19:40
  • 1
    @StanleySathler correct, this will not work for `react-select`, but only an HTML `select` – heez Feb 08 '21 at 18:54
0
export async function selectOption(container: HTMLElement, optionText: string) {
  let listControl: any = '';
  await waitForElement(
    () => (listControl = container.querySelector('.Select-control')),
  );
  fireEvent.mouseDown(listControl);
  await wait();
  const option = getByText(container, optionText);
  fireEvent.mouseDown(option);
  await wait();
}

NOTE: container: container for select box ( eg: container = getByTestId('seclectTestId') )

0

An alternative solution which worked for my use case and requires no react-select mocking or separate library (thanks to @Steve Vaughan) found on the react-testing-library spectrum chat.

The downside to this is we have to use container.querySelector which RTL advises against in favour of its more resillient selectors.

jameshelou
  • 65
  • 1
  • 8