Why is my C code not running or running too slow?

Question

My code in c is:

#include <stdio.h>

main()
{
    int fahr, celsius;
    int lower, upper, step;

    lower = 0;  
    upper = 300;    
    step = 20;  

    fahr = lower;
    while (fahr <= upper); {
        celsius = 5 * (fahr - 32) / 9;
        printf("%d\t%d\n", fahr, celsius);
        fahr = fahr + step;
    }
}

I have compiled it with gcc without any errors and am trying to execute it with windows prompt. However, it keeps thinking and doesn't show anything. What is the problem?

Not the problem, but you should be using `int main(void)` as the signature of `main` — Spikatrix, Mar 23 '19 at 14:36
What is this ancient main you are using? Upgrade your compiler and use int main(void) — machine_1, Mar 23 '19 at 14:56
@machine_1 What's the point of using `void` in the argument list? That's not mandatory. — klutt, Mar 23 '19 at 15:14
always read compiler warnings. You'll get something like ":13:26: warning: while loop has empty body [-Wempty-body]". And see [What should main() return in C and C++?](https://stackoverflow.com/q/204476/995714) — phuclv, Mar 23 '19 at 15:15

score 1 · Accepted Answer · answered Mar 23 '19 at 14:36

1

Remove the semicolon after the while statement.

Like this, the while loop is an infinite loop, because the code inside the curly brackets is not considered to be the loop body. The while loop has an empty body and will never terminate.

The code in the curly brackets will never be executed.

answered Mar 23 '19 at 14:36

M. Spiller

2,325
1
6
15

It's worth noting that GCC will warn you about this issue if you enable warnings (-Wall for most of them, but this specific issue is caught by -Wmisleading-indentation). You should pretty much always pass -Wall, especially while you're learning. – nemequ Mar 23 '19 at 14:47

score 0 · Answer 2 · answered Mar 23 '19 at 14:43

Your while loop as written doesn’t do what you intend it to. The mistake is on this line:

while (fahr <= upper); {

The semicolon here prematurely terminates the while statement. This creates an infinite loop, because your program is now continually evaluating fahr <= upper without modifying the value of fahr.

Delete that semicolon and your program will execute as expected.

score 0 · Answer 3 · answered Mar 23 '19 at 14:44

Change

    while (fahr <= upper); {

To

    while (fahr <= upper){

Because of the semicolon after while loop the while loop is not going into the { } portion. So the value of fahr & upper is never changing and the while loop is running forever. Remove the semicolon, your code will work well.

Why is my C code not running or running too slow?

3 Answers3