8

The following snippet should demonstrate the problem quite well:

(function ($) {

    $('.bxslider').each(function() {
        var bxid = $(this).attr("data-bxid");

        var bx = $(this).bxSlider({
            auto: false,
            autoStart: false
        });
    });

})(jQuery);
/* Styles */
#before, #after {
  width:350px;
  height:350px;
  background-color:#ccf;
}

/* BXSlider */
.bx-wrapper {
  position: relative;
  margin-bottom: 60px;
  padding: 0;
  *zoom: 1;
  -ms-touch-action: pan-y;
  touch-action: pan-y;
}

.bx-wrapper img {
  max-width: 100%;
  display: block;
}

.bxslider {
  background-color:#eee;
  margin: 0;
  padding: 0;
  /*fix flickering when used background-image instead of <img> (on Chrome)*/
  -webkit-perspective: 1000;
}

ul.bxslider {
  list-style: none;
  width:100%;
}

ul.bxslider li {
   width:100%;
}

.bx-viewport {
  /* fix other elements on the page moving (in Chrome) */
  -webkit-transform: translateZ(0);
}
<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/bxslider/4.2.15/jquery.bxslider.min.js"></script>
<div id="before"></div>
<ul class="bxslider">
<li><p>If you touch me vertically ...<img src="https://via.placeholder.com/500x350"></li>
<li>... I want to scroll down normally ...<img src="https://via.placeholder.com/500x250"></li>
<li>... but nothing happens <img src="https://via.placeholder.com/500x450"></li>
</ul>
<div id="after"></div>

In the developer tools of your browser window try to scroll down by touch within the running code snippet - it is not possible. However this is not an option as with a fullscreen horizontal bxSlider visitors are loosing the ability to browser the site completely - unacceptable!

bxSlider provides the following setting:

touchEnabled:false

However this is also not an option, because smartphone visitors really should be able to switch slides to the right/to the left with their fingers.

Therefore I need a possibility such that:

  • HORIZONTAL touch move: Go smoothly to the next/previous slide within the slider.
  • VERTICAL touch move: Just keep the normal scrolling of the viewport within the browser.

Unfortunatly I did not find any combinations of bxslider settings how to achieve this yet. Do you know a solution for this (preferrably without modifying the bxslider core file itself)?

Blackbam
  • 12,200
  • 19
  • 71
  • 117
  • 1
    Also created a bxslider ticket here: https://github.com/stevenwanderski/bxslider-4/issues/1219 – Blackbam Sep 05 '18 at 13:45
  • 1
    You might disagree but since its fullscreen I would disable touch altogether and use the next/previous links as navigation arrows. – RiddleMeThis Sep 11 '18 at 14:59
  • 1
    @RiddleMeThis This is exactly the solution I do not want to use for two reasons: First of all it destroys the fancyness of bXSlider. And even worse: The fancyness for the desktop users (where the sliders has max-width) is gone, too. – Blackbam Sep 11 '18 at 15:29

1 Answers1

4

I editted onTouchStart function in jquery.bxslider.js .

Just copy and replace the codes below with original onTouchStart function codes ( that starts from 1103 line ):

   var onTouchStart = function(e) {
      // watch only for left mouse, touch contact and pen contact
      // touchstart event object doesn`t have button property
      if (e.type !== 'touchstart' && e.button !== 0) {
        return;
      }
      var lastScrollTop = 0;
        $(window).scroll(function(event){
            var st = $(this).scrollTop();
            if (st > lastScrollTop){ } else {  e.preventDefault();   }
        });

      //disable slider controls while user is interacting with slides to avoid slider freeze that happens on touch devices when a slide swipe happens immediately after interacting with slider controls
      slider.controls.el.addClass('disabled');

      if (slider.working) {
        slider.controls.el.removeClass('disabled');
      } else {
        // record the original position when touch starts
        slider.touch.originalPos = el.position();
        var orig = e.originalEvent,
        touchPoints = (typeof orig.changedTouches !== 'undefined') ? orig.changedTouches : [orig];
        var chromePointerEvents = typeof PointerEvent === 'function'; 
        if (chromePointerEvents) { 
            if (orig.pointerId === undefined) { 
                return;
            } 
        }
        // record the starting touch x, y coordinates
        slider.touch.start.x = touchPoints[0].pageX;
        slider.touch.start.y = touchPoints[0].pageY;

        if (slider.viewport.get(0).setPointerCapture) {
          slider.pointerId = orig.pointerId;
          slider.viewport.get(0).setPointerCapture(slider.pointerId);
        }
        // store original event data for click fixation
        slider.originalClickTarget = orig.originalTarget || orig.target;
        slider.originalClickButton = orig.button;
        slider.originalClickButtons = orig.buttons;
        slider.originalEventType = orig.type;
        // at this moment we don`t know what it is click or swipe
        slider.hasMove = false;
        // on a "touchmove" event to the viewport
        slider.viewport.on('touchmove MSPointerMove pointermove', onTouchMove);
        // on a "touchend" event to the viewport
        slider.viewport.on('touchend MSPointerUp pointerup', onTouchEnd);
        slider.viewport.on('MSPointerCancel pointercancel', onPointerCancel);
      }
    };

Edit (Fiddle): https://jsfiddle.net/Blackbam/sk2ve907/2/

For testing: https://jsfiddle.net/Blackbam/sk2ve907/2/show

Blackbam
  • 12,200
  • 19
  • 71
  • 117
Fatihd
  • 557
  • 3
  • 11
  • Thanks a lot. It is not a perfect solution as the bxslider core files have to be modified but it is the only answer we have so far and it works according to my manual tests! – Blackbam Sep 14 '18 at 13:55