C++ input file isn't reading my whole file back in to string

Question

I have a program that is taking in a JSON file, of approx 170,000 characters total. I am saving them all to a text file (this part works fine) and then I am trying to read that entire text file back into a string:

json::value historicalData = value;
    ofstream outputFile("test.txt"); //output to file
    outputFile << historicalData; //store JSON into file
    ifstream inputFile("test.txt"); //input from file
    string historicalDataString="";
    string appendTemp;
    while(!inputFile.eof()){
    getline(inputFile,appendTemp); //store value from file into string
    historicalDataString.append(appendTemp);
    }

When I use this code above to read the file back in, I do not get the entire length of the file back. It stops about two thirds of the way, and is appending a "1" onto the end of my string. What am I doing wrong?

Close `outputFile` before reading. Some data is probably still sitting in its buffers. — Igor Tandetnik, Apr 17 '18 at 22:21
Read [Why is `iostream::eof` inside a loop condition considered wrong?](https://stackoverflow.com/questions/5605125/why-is-iostreameof-inside-a-loop-condition-considered-wrong) — molbdnilo, Apr 17 '18 at 22:28

score 1 · Answer 1 · answered Apr 17 '18 at 22:28

1

outputFile.close();

Solved my issues.

answered Apr 17 '18 at 22:28

runesbane

83
7

You can click the check mark next to this answer to mark the question as resolved – Increasingly Idiotic Apr 17 '18 at 22:41

C++ input file isn't reading my whole file back in to string

1 Answers1