React Router v4 Redirecting on form submit

Question

Brand new to react, Attempting to redirect to a "homepage" after clicking submit on a "login" page. Tried to follow the react router tutorial.

When I click the submit button on the form and console log the state and fakeAuth.isAuthenticated, they both return true. However, the redirect is not firing.

Login.js

class Login extends Component {
    constructor(props) {
        super(props);
        this.state = {
            portalId: "",
            password: "",
            redirectToReferrer: false
        }

        this.handleSubmit = this.handleSubmit.bind(this);
    }


    handleSubmit(e) {
        fakeAuth.authenticate(() => {
            this.setState({
                portalId: this.refs.portalId.value,
                password: this.refs.password.value,
                redirectToReferrer: true
            })
        })
        e.preventDefault();
    }


    render() {
        const redirectToReferrer = this.state.redirectToReferrer;
        if (redirectToReferrer === true) {
            <Redirect to="/home" />
        }

Routes.js

export const fakeAuth = {
    isAuthenticated: false,
    authenticate(cb) {
        this.isAuthenticated = true
        setTimeout(cb, 100)
    },
    signout(cb) {
        this.isAuthenticated = false
        setTimeout(cb, 100)
    }
}

const PrivateRoute = ({ component: Component, ...rest }) => (
    <Route {...rest} render={() => (
        fakeAuth.isAuthenticated === true
        ? <Component {...this.props}/>
        : <Redirect to="/" />
    )}/> 
)


export default () => (
    <BrowserRouter>
        <div>
            <Navbar />
            <Switch>
                <Route path="/" exact component={Login} />
                <Route path="/register" exact component={Register} />
                <Route path="/home" exact component={Home} />
            </Switch>
        </div>
    </BrowserRouter>
);

score 26 · Accepted Answer · edited Oct 06 '20 at 08:12

26

You have to return Redirect in render method (otherwise it will not be rendered and as a result redirection will not happen):

  render() {
        const redirectToReferrer = this.state.redirectToReferrer;
        if (redirectToReferrer) {
            return <Redirect to="/home" />
        }
        // ... rest of render method code
   }

edited Oct 06 '20 at 08:12

Chase Shields

38
4

answered Apr 09 '18 at 17:25

Bartek Fryzowicz

5,716
14
23

1

Thank you, this worked. Should have posted earlier instead of spending many hours wasted on this. – Vincent Nguyen Apr 09 '18 at 17:27
@VincentNguyen You're welcome. Please upvote and accept the answer if it helped you :) – Bartek Fryzowicz Apr 09 '18 at 17:29

score 10 · Answer 2 · answered Apr 09 '18 at 17:25

10

I am now able to redirect to the "homepage" by swapping out <Redirect to="/home" /> with this.props.history.push("/home"); using withRouter. Not sure why the first way would not work though.

answered Apr 09 '18 at 17:25

Vincent Nguyen

1,175
3
14
29

Can you give an example of where you added it? @Vincent Nguyen – FabricioG Aug 13 '19 at 06:20
5

There is a useful post on the difference between using `history.push` and `redirect` at: https://tylermcginnis.com/react-router-programmatically-navigate/ – Concrete_Buddha Sep 19 '19 at 13:58

React Router v4 Redirecting on form submit

2 Answers2

Linked