17

I'm trying to migrate a SF 3.3 app to SF 4 with its new directory structure and everything.

I'm struggling on this exception:

The "simplethings_entityaudit.reader" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead.

(This service comes from an external bundle located in /vendor).

Nevertheless, when I bin/console debug:container simplethings_entityaudit.reader you'll see the service exists and is public:

Information for Service "simplethings_entityaudit.reader"
=========================================================

 ----------------- -------------------------------------- 
  Option            Value                                 
 ----------------- -------------------------------------- 
  Service ID        simplethings_entityaudit.reader       
  Class             SimpleThings\EntityAudit\AuditReader  
  Tags              -                                     
  Public            yes                                   
  Synthetic         no                                    
  Lazy              no                                    
  Shared            yes                                   
  Abstract          no                                    
  Autowired         no                                    
  Autoconfigured    no                                    
  Factory Service   simplethings_entityaudit.manager      
  Factory Method    createAuditReader                     
 ----------------- --------------------------------------

This service is currently called in one of my own with $this->container->get('simplethings_entityaudit.reader').

I also tried to inject SimpleThings\EntityAudit\AuditReader into my service constructor, but here's what I get:

Argument "$auditReader" of method "__construct()" references class "SimpleThings\EntityAudit\AuditReader" but no such service exists. It cannot be auto-registered because it is from a different root namespace.

When I add this into my services.yaml it works, but I shouldn't need to do this:

SimpleThings\EntityAudit\AuditReader:
    alias: simplethings_entityaudit.reader

Any ideas?

Ben
  • 695
  • 1
  • 5
  • 16
  • That's ok with the alias, what you can do when external bundle doesn't provide alias for compatibility with Symfony 4. If this is your bundle, add alias inside it. – malcolm Jan 24 '18 at 15:20
  • as it´s not clearly visible from the answer: add property `public:true` as sibling to alias – john Smith Feb 25 '19 at 09:30

3 Answers3

9

In my case, the error appears in a unit test.

I had a single service, which could not be loaded in tests (Symfony 4.2) while all other services in my project worked well.

I've cleared the cache, but it didn't help. Then I created a simple controller with a route and injected the service as method parameter. Afterwards the service worked in my test as well.

Conclusion: If you have a unit test and want to test your service, you must also provide a controller where the service is injected, otherwise it is not available in the test service container. An explicit service configuration might also help.

Hendrik Pilz
  • 99
  • 1
  • 3
  • 3
    This is at least partially incorrect. Adding the controller probably just marked the service as used, so it wasn't pruned during container dumping. – Jean May 10 '19 at 12:44
7

In Symfony 4.0, any service that does not specify its visibility is private, https://github.com/symfony/symfony/pull/24238.

As far as I can see, the service you mention does not specify the visibility: https://github.com/simplethings/EntityAuditBundle/blob/1.0/src/SimpleThings/EntityAudit/Resources/config/auditable.xml#L23-L26, so this is probably the reason for your exception.

If simplethings_entityaudit.reader service cannot be autowired (and this is probably because it uses a factory service), you can inject it into your own service by referencing it with @simplethings_entityaudit.reader notation as per this: https://symfony.com/doc/current/service_container.html#services-manually-wire-args, something like this:

services:
    My\Service:
        arguments:
            $auditReader: @simplethings_entityaudit.reader
Edi Modrić
  • 2,064
  • 1
  • 12
  • 15
  • Hello Edi, I know that indeed, but for whatever reason the service is marked as public when doing `debug:container`. When you say "this is probably because it uses a factory service", where is this behavior documented? Never heard of that. Thank you, Ben – Ben Jan 25 '18 at 09:23
  • Oh, I assumed that the output of `debug:container` command was from Symfony 3.3. On Symfony 4.0, I'm not sure why it should show up as public in the output. As for autowiring and factory service, I don't know if it's documented anywhere, it was an educated guess, because it seems like a valid reason why it couldn't be autowired, since autowiring system wouldn't know how to construct the service. One other potential reason could be that for that service, autowiring simply isn't turned on (since it's not configured in its config file), but these are just guesses. – Edi Modrić Jan 26 '18 at 14:00
  • 2
    It was actually a bug that was fixed in latest Symfony 4.0.x version. – Ben Apr 11 '18 at 08:59
  • 3
    Yes, as you suggest and the docs you posted, one of the options is setting the service visibility using `public: true` – FantomX1 Jun 06 '20 at 01:55
  • I just add this doc because it is helpfull in this case : https://symfony.com/doc/current/service_container/alias_private.html#marking-services-as-public-private – vincent PHILIPPE Aug 20 '20 at 10:14
0

In our case we made a services_test.yml along with .env.test with APP_ENV set to test

then in this services_test.yml we placed

services: _defaults: public: true

so by default all services are public

don't forget to source your .env and .env.test I often have to do that we I restart my VM

Solber
  • 25
  • 1
  • 7