1

Im writing this code below ,a simple register option for the user and when I press the Create my Account button I get: Anyone can figure out why ?Cant figure it out myself. Thanks you everyone in advance

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 12-28 18:38:57.792 3358-3358/gr.aegean.icsd15109.myfitup E/AndroidRuntime: FATAL EXCEPTION: main Process: gr.aegean.icsd15109.myfitup, PID: 3358 java.lang.NullPointerException at gr.aegean.icsd15109.myfitup.RegisterActivity.registerUser(RegisterActivity.java:51) at gr.aegean.icsd15109.myfitup.RegisterActivity$1.onClick(RegisterActivity.java:45) at android.view.View.performClick(View.java:4438) at android.view.View$PerformClick.run(View.java:18422) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5017) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595) at dalvik.system.NativeStart.main(Native Method)

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CODE:

import android.content.Intent;
import android.support.annotation.NonNull;
import android.support.design.widget.TextInputEditText;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.EditText;
import android.widget.TextView;
import android.widget.Toast;

import com.google.android.gms.tasks.OnCompleteListener;
import com.google.android.gms.tasks.Task;
import com.google.firebase.auth.AuthResult;
import com.google.firebase.auth.FirebaseAuth;

import org.w3c.dom.Text;

public class RegisterActivity extends AppCompatActivity {

    private EditText mDisName;
    private EditText mMail;
    private EditText mPass;
    private Button reg;
    private TextView error;
    private FirebaseAuth mAuth;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_register);
        mDisName =(EditText) findViewById(R.id.reg_name);
        mMail = (EditText) findViewById(R.id.reg_mail);
        mPass = (EditText) findViewById(R.id.reg_password);
        reg = (Button) findViewById(R.id.reg_button);
        error = (TextView) findViewById(R.id.textView4);

        reg.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                String disName = mDisName.getText().toString();
                String dmail = mMail.getText().toString();
                String pass = mPass.getText().toString();
                registerUser(disName,dmail,pass);
            }
        });
    }

    public void registerUser(String display_name,String email,String password){
        mAuth.createUserWithEmailAndPassword(email,password).addOnCompleteListener(new OnCompleteListener<AuthResult>() {
            @Override
            public void onComplete(@NonNull Task<AuthResult> task) {
                if(task.isSuccessful()){
                        Intent loginIntent = new Intent(RegisterActivity.this,login.class);
                        startActivity(loginIntent);
                        finish();
                }
                else{
                    Toast.makeText(RegisterActivity.this,"Error with registration!",Toast.LENGTH_LONG).show();
                    error.setText("Error 110! User already exists! \n Please provide different username!");
                }
            }
        });

    }
}

XML CODE:

<?xml version="1.0" encoding="utf-8"?>
<android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    tools:context="gr.aegean.icsd15109.myfitup.account">

    <android.support.design.widget.TextInputLayout
        android:id="@+id/textInputLayout2"
        android:layout_width="330dp"
        android:layout_height="wrap_content"
        android:layout_marginTop="48dp"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent">

        <android.support.design.widget.TextInputEditText
            android:id="@+id/reg_name"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:hint="@string/display_name" />
    </android.support.design.widget.TextInputLayout>

    <android.support.design.widget.TextInputLayout
        android:id="@+id/textInputLayout3"
        android:layout_width="330dp"
        android:layout_height="62dp"
        android:layout_marginEnd="8dp"
        android:layout_marginStart="8dp"
        android:layout_marginTop="20dp"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/textInputLayout2">

        <android.support.design.widget.TextInputEditText
            android:id="@+id/reg_mail"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:hint="@string/email" />
    </android.support.design.widget.TextInputLayout>

    <Button
        android:id="@+id/reg_button"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginEnd="8dp"
        android:layout_marginRight="16dp"
        android:layout_marginTop="56dp"
        android:text="@string/create_account"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/reg_password"
        tools:ignore="RtlHardcoded" />

    <EditText
        android:id="@+id/reg_password"
        android:layout_width="330dp"
        android:layout_height="wrap_content"
        android:layout_marginEnd="8dp"
        android:layout_marginStart="8dp"
        android:layout_marginTop="12dp"
        android:ems="10"
        android:hint="@string/password2"
        android:inputType="textPassword"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintHorizontal_bias="0.526"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/textInputLayout3" />

    <TextView
        android:id="@+id/textView4"
        android:layout_width="262dp"
        android:layout_height="55dp"
        android:layout_marginEnd="8dp"
        android:layout_marginStart="8dp"
        android:layout_marginTop="44dp"
        android:textColor="@android:color/holo_red_dark"
        android:textStyle="bold"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/reg_button" />
</android.support.constraint.ConstraintLayout>
Peter Haddad
  • 65,099
  • 21
  • 108
  • 107
John Luko
  • 49
  • 7
  • 1
    It's easy to debug this. Where does it give you `null` ? – Greggz Dec 28 '17 at 23:59
  • 1
    at RegisterUser() line 51. Tried to debug it but didnt find any solution. First i thought the XML button name was incorrect , checked it was fine. Then checked the Strings if they are passed correctly but again was fine. – John Luko Dec 29 '17 at 00:01
  • 1
    Possible duplicate of [What is a NullPointerException, and how do I fix it?](https://stackoverflow.com/questions/218384/what-is-a-nullpointerexception-and-how-do-i-fix-it) – users at 4325010 Dec 29 '17 at 00:02
  • @JohnLuko The problem isn't about `onClick()` but inside your `registerUser` method – Greggz Dec 29 '17 at 00:06
  • Tried adding fixed strings inside regusterUser method and again the same exception ... Dont know what else may cause the problem 2 hours searching for it – John Luko Dec 29 '17 at 00:13

1 Answers1

1

mAuth in your code is null.. you are not getting its instance

Do this:

In the onCreate() method, initialize the FirebaseAuth instance:

mAuth = FirebaseAuth.getInstance();

then you will be able to use this method:

 mAuth.createUserWithEmailAndPassword(email, password)
    .addOnCompleteListener(this, new OnCompleteListener<AuthResult>() {

for more info check this: https://firebase.google.com/docs/auth/android/start/

Peter Haddad
  • 65,099
  • 21
  • 108
  • 107