Root Navlink always get active class React Router Dom

Question

I am using react-router-dom: 4.2.2. I can add activeClassName to the current URL. But surprisingly the class is always added to root URL.

While visiting a page, for example the error page like the screenshot below, the home navlink also getting the activeClass.

Update: In the above screenshot I have showed that I visited http://localhost:3000/#/error. So, the active-link should be added to the Love Error? NavLink only. But as you can see it is also added to Home NavLink too.

Here is my navbar code:

import React from 'react';
import { NavLink } from 'react-router-dom';

export const NavigationBar = () => (
  <ul className="horizontal-menu">
    <li> <NavLink to = '/' activeClassName="active-link">Home</NavLink> </li>
    <li> <NavLink to = '/about' activeClassName="active-link">About Us</NavLink> </li>
    <li> <NavLink to = '/error' activeClassName="active-link">Love Error?</NavLink> </li>
  </ul>
)

For routing I have used the following Switch:

<Switch>
  <Route exact path = '/' component = {Home} />
  <Route exact path = '/about' component = {AboutUs} />
  <Route exact path = '/error' component = {Error404} />
  <Route path = "/news/:id" component = {NewsDetail} />
  <Route path="*" component={Error404} />
</Switch>

How can I get the expected behavior?

post a sample url that is causing error – Sujit.Warrier Dec 19 '17 at 03:39 — Sujit.Warrier, Dec 19 '17 at 03:39
@Sujit.Warrier, updated my question. Hope it is clear now. – arsho Dec 19 '17 at 03:55 — arsho, Dec 19 '17 at 03:55

score 41 · Accepted Answer · edited Aug 30 '18 at 11:22

41

You have to use isActive={} to add additional verification to ensure whether the link is active.

document

Working jsFiddle. (fiddle is not created by me)

Code you need to add is like below

Example in jsfiddle

<li><NavLink to="/" isActive={checkActive}>Home</NavLink></li>

Change in your code

<li> <NavLink to='/' activeClassName="active-link" isActive={checkActive}>Home</NavLink> </li>

check the isActive prop and "checkActive" is a function.

const checkActive = (match, location) => {
    //some additional logic to verify you are in the home URI
    if(!location) return false;
    const {pathname} = location;
    console.log(pathname);
    return pathname === "/";
}

Another config you can use is "exact" but It is not possible to demonstrate it in a jsFiddle. I think the code would be like

<li> <NavLink exact to='/' activeClassName="active-link">Home</NavLink> </li>

Hope this helps. And let me know if you need more info.

edited Aug 30 '18 at 11:22

vsync

87,559
45
247
317

answered Dec 19 '17 at 04:10

Shashith Darshana

2,097
1
20
27

1

It works like a charm! But I wonder if there is no default method rather than this custom handwritten method. Thank you. – arsho Dec 19 '17 at 04:58
added another usable config hope that will help you – Shashith Darshana Dec 19 '17 at 05:28
4

This answer does work but there is a simple, documented way built in already, [as answered by](https://stackoverflow.com/a/48393110/397122) @digitalh2o – Slobaum Jun 09 '18 at 18:40
2

Adding exact attribute on NavLink worked perfect for me. Thanks! – iChido Sep 12 '18 at 14:27
Adding exact worked for me. But as I am new to reactjs I did not realize I had to add / in front of each path. So just in case someone else has the same problem: ` choose ` – martomstom Dec 15 '18 at 16:35
2

`exact` Worked Like Charm :) – krupesh Anadkat Oct 24 '20 at 11:28

score 39 · Answer 2 · edited Jan 23 '18 at 02:41

39

I've found that adding exact before the first activeClassName works as well. So for example, your set up can be:

export const NavigationBar = () => (
  <ul className="horizontal-menu">
    <li><NavLink to='/' exact activeClassName="active-link">Home</NavLink> 
    </li>
    ....remaining NavLinks
  </ul>
)

edited Jan 23 '18 at 02:41

Pang

8,605
144
77
113

answered Jan 23 '18 at 02:05

digitalh2o

531
4
6

3

This is perfect answer – hassanrazadev Jan 01 '20 at 19:18
3

This is the real answer. – Nyxynyx Apr 13 '20 at 15:34
3

Indeed, this should be the selected answer :) – Adil Aug 18 '20 at 12:48
Sometimes, if you have additional data in the URL for example some filters, then it won't really work. The best solution then is to have a function that will decide about that. That's why the answer above is selected. – nightspite May 11 '21 at 07:45

score 14 · Answer 3 · answered Jan 30 '19 at 13:03

14

You can use exact keyword for active class such as

<NavLink exact to ='/'>Home</NavLink>

it will generate like that

<a href="/" class="active" aria-current="page">Home</a>

and if you will get another page then it will be like that

<a href="/">Home</a>

answered Jan 30 '19 at 13:03

fool-dev

6,960
8
32
49

3

This should be the accepted answer. No extra functions needed. – Pablo Zehle Apr 06 '19 at 16:07
3

I'm using the exact on all my links. However, the home page link is still active. – Erik James Robles May 27 '19 at 01:06
2

@Erik make sure you removed the static active class – fool-dev Nov 19 '19 at 15:06
2

This answer should get more recognition – dondrzzy Dec 11 '20 at 11:12
1

Upvoted! this is straight forward dude, thanks for sharing. – krupesh Anadkat Apr 05 '21 at 07:51

score 2 · Answer 4 · answered Jul 04 '18 at 12:27

2

I recently came across this issue and solved it by simply adding:

import { withRouter } from 'react-router-dom';

and then wrapped the component with:

export default withRouter(Component);

answered Jul 04 '18 at 12:27

Jango17

21
2

score 1 · Answer 5 · answered Feb 06 '20 at 07:31

Change in your code

<li> <NavLink to='/' activeClassName="active-link" isActive={checkActive}>Home</NavLink> </li>

and then

const checkActive = (match, location) => {
  console.log(location);
  if (!location) return false;
  const { pathname } = location;
  const { url } = match;
  return pathname === url ? true : false;
};

note *

const { pathname } = location;
const { url } = match;
return pathname === url ? true : false;

score 0 · Answer 6 · answered Oct 11 '19 at 16:11

I am learning React now and just came across the same problem. I tried the following and it worked for me.

So, I have 3 navigational links.

<li><NavLink to="/home">Home</NavLink></li>
<li><NavLink to="/about">About</NavLink></li>
<li><NavLink to="/contact">Contact</NavLink></li>

But I added 4 routes.

<Route exact path="/" component={Home}></Route>
<Route path="/home" component={Home}></Route>
<Route path="/about" component={About}></Route>
<Route path="/contact" component={Contact}></Route>

I added 2 routes (/ and /home) for the same component (Home). This way, the react-router-dom seems to add the class 'active' only to the link that you click.

score 0 · Answer 7 · answered Dec 25 '20 at 23:26

Working fine for me

<ul className="menu nav navbar-nav">
      <li><NavLink exact to="/" activeClassName="active-link active2">Home</NavLink></li>
      <li><NavLink to="/financial-summary" activeClassName="active-link active2">Financial Summary</NavLink></li>
      <li><NavLink to="/account-statement" activeClassName="active-link active2">Account Statement</NavLink></li>
      <li><NavLink to="/tools" activeClassName="active-link active2">Tools</NavLink></li>
      <li><NavLink to="/service-charges" activeClassName="active-link active2">Service Charges & Important Information</NavLink></li>
    </ul>

css

.active2, .active2 a:link, .active2 a:visited{
    background: #004B8D !important;
    color: #FFFFFF !important;
    border-top-left-radius: 5px;
    border-top-right-radius: 5px;
}

score 0 · Answer 8 · answered Jan 20 '21 at 12:25

If you're trying to use <Navlink> on single page website and anchor-links, make sure to replace <BrowserRouter> with <HashRouter>!

I had to remove the slash to reach my anchor text: <HashRouter hashType='noslash'>

With this setup,

<li><NavLink to="about">About</NavLink></li>

will render

<a href="#about" aria-current="page" class="active">About</a>

Documentation

score 0 · Answer 9 · answered Jan 23 '21 at 13:02

I am using LinkContainer from react-router-bootstrap, I was still having an issue like this. The home link was always active.

I have solved it by using an exact keyword for the path of the link like this. I hope if you will use this and have any issue regarding this, so it can help. cheers.

Header.js component :

  <LinkContainer to="/" exact>
     <Nav.Link>
       <i className="fas fa-home mr-1"></i>Home
     </Nav.Link>
  </LinkContainer>

and App.js component :

 <Route path="/" component={HomeScreen} exact />
 <Route path="/about" component={AboutScreen} exact />
 <Route path="/blogs" component={BlogScreen} exact />

Root Navlink always get active class React Router Dom

9 Answers9