C++ Validate Emails Via Substrings

Question

I'm trying to take the profile info(username, email, etc.) from one directory and put it in another. I've been debugging the code for this program, and while there are no errors, the program won't run, saying that the program "has stopped working". I have already looked on this website and others for any possible answers, and found none.

#include <string>
#include <cstring>
#include <iostream>
#include <istream>
#include <ostream>
#include <fstream>
#include <iomanip>
#include <filesystem>
using namespace std;

class path{
public:
string parent_directory;
string root_directory;
};

class Data{
public:
string userName;
string nickName;
string fName;
string arena_FName;
string lName;
string arena_LName;
string email;
string arenaEmail;

friend std::istream& operator>>(std::istream& input, Data& d);
};
std::istream& operator>>(std::istream& input, Data& d){
std::getline(input, d.userName);
std::getline(input, d.nickName);
//...
std::getline(input, d.arenaEmail);
return input;
}

int main(){

ifstream myfile("myfunk.txt", ios::in);

ofstream arena("arena.txt");

myfile.open("myfunk.txt", ios::in);
if(myfile){
    cout << "Input file open." << endl;
}

arena.open("arena.txt", ios::out | ios::app);
if(arena){
    cout << "Output file open." << endl;
}

cout << "file opening test: success" << endl;

int x = 0;
int y = 4101;       //Total number of users in the directory.
int z = 0;          //For inputting the required lines of info for each profile.
int profile = 0;
bool valid = false;
string role;
//string arenaRole;
bool post = false;
string line;
string p = "This PC/..."; //Path to the folder of the individual pictures.
//myVar.save("...");
string p = "...";
path path1;
path root_directory;
path parent_directory;
//bool is_directory(const std::filesystem::path& p, std::error_code& ec) noexcept; //Checks if current location is a directory.
//bool postPic;
const unsigned int MAXIMUM_DATA = 4100u;
Data database[MAXIMUM_DATA];

cout << "All variables but the filesystem have been accepted!  Please install this program on the network." << endl;

while(x < y){
    cout << "Primary loop functioning" << endl;

    if(post = true){
        getline(myfile, line); //Grab and read next line.
        myfile >> line;
        line = userName[x];
        arena << "Username: " << userName[x] << "\n";
        z++;

        getline(myfile, line);
        myfile >> line;
        line = role[x];
        arena << "Role: " << role[x] << "\n";
        z++;

        getline(myfile, line);
        line = nickName[x];
        myfile >> nickName[x];
        arena << "nickname: " << nickName[x] << "\n";
        z++;

        getline(myfile, line);
        line = fName[x];
        myfile >> fName;
        arena << "First Name: " << fName[x] << "\n";
        z++;

        getline(myfile, line);
        line = lName[x];
        myfile >> lName;
        arena << "Last Name: " << lName[x] << "\n";
        z++;

        getline(myfile, line);
        myfile >> line;
        line = email[x];
        arena << "Email: " << email[x] << "\n";
        getline(myfile, line);
        z = 0; //Next profile...
    }

    int data;
    while(myfile >> data){
        if(nickName[x] = NULL){
            myfile >> "<Error> Some required information is missing! Contact user! </Error> /n";
            valid = false;
            post = false;
            x++;
            }

            if(email[x] != NULL){
                std::string str("@");
                std::string str2(".com");
                std::string str3(".net");
                std::string str4(".edu");
                if(std::size_t found = email[x].find(str) & (std::size_t found = email[x].find(str2) || std::size_t found = email[x].find(str3) || std::size_t found = email[x].find(str4)){
                    valid = true;
                    if(valid = true){
                        post = true;
                    }
                }

                else{
                    valid = false;
                    post = false;
                    x++;
                }
            }
        }
        }
    }

}
x++;
}

    //x++;

myfile.close(); //Closes the file in the directory.
arena.close();  //Closes the file in Arena.

return 0;
}

Answer 1

Let's rework your code.
First, let's create a data structure for the data:

class Data
{
  public:
    string userName;
    string nickName;
    string fName;
    string arena_FName;
    string lName;
    string arena_LName;
    string email;
    string arenaEmail;
};

If you need an array for the data, it would be declared as:

const unsigned int MAXIMUM_DATA = 4100u;
Data database[MAXIMUM_DATA];

Next, let's overload the extraction operator>> to make reading easier:

class Data
{
  public:
    //...
    friend std::istream& operator>>(std::istream& input, Data& d);
};
std::istream& operator>>(std::istream& input, Data& d)
{
  std::getline(input, d.userName);
  std::getline(input, d.nickName);
  //...
  std::getline(input, d.arenaEmail);
  return input;
}

This simplifies your input loop to:

std::vector<Data> database;
Data d;
while (my_file >> d)
{
  database.push_back(d);
}

You can query the amount of data read in by using the std::vector::size() method, i.e. database.size().

Also, you don't need a separate structure for a file path. A simple std::string will suffice. I recommend using forward slash, '/', because it is recognized by both Windows and *nix operating systems and won't be interpreted as an escape character.