login form doesn't redirect

Question

My login from doesn't redirect me on my index page. I need help.

Here is my index.php

<?php
ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL);

include "includes/dbh.inc.php";
include "includes/user.inc.php";
include "includes/login.inc.php";
    session_start();
    $query = new Login();
    $query->userLogin($_POST['name'], $_POST['password']);

    if (isset($_SESSION['loggedin']) && $_SESSION['loggedin'] == true) {

        echo "Welcome to the member's area, " . $_SESSION['email'] . "!";
    } else {
        echo "Please log in first to see this page.";
    }

 ?>
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">

    <title>News | DanneggiastaCraft</title>
    <meta name="description" content="The Danneggisata Craft">
    <meta name="DanneggiastaCraft" content="News">

    <!-- CSS -->
    <link rel="stylesheet" href="assets/css/main.css">

    <!-- Font -->
    <link href='http://fonts.googleapis.com/css?family=Open+Sans|Baumans' rel='stylesheet' type='text/css'>

</head>
<body>


<!-- Site Wrapper -->
<div class="site-wrapper" id="page-top">
    <header class="main-header">

        <div class="header-logo">

            <h1>DanneggiastaCraft</h1>

            <p>World News</p>

        </div>
        <nav>
            <ul>
                <li><a href="index.php" class="current">Home</a></li>
                <li><a href="#">Tech</a></li>
                <li><a href="#">Sport</a></li>
                <li><a href="#">Weather</a></li>
                <li><a href="#">About</a></li>
            </ul>
        </nav>
    </header>

    <!-- Body Wrapper -->
    <div class="body-wrapper" id="main-section">

        <section id="news">
            <div class="fourth">
                <img src="assets/img/news.jpg">

                <h3>Phasellus lorem erat, fringilla vestibulum est sit amet, lobortis tincidunt leo. Nam non
                    posuere lorem.</h3>

                <p>Nulla vitae ultricies metus, sed consequat elit. Suspendisse nisl velit, cursus sed mattis a, varius
                    sit amet nibh. Cras imperdiet nulla vitae euismod blandit. Sed pulvinar nibh ut dolor semper
                    accumsan. Phasellus lorem erat, fringilla vestibulum est sit amet, lobortis tincidunt leo. Nam non
                    posuere lorem. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis
                    egestas. Nunc scelerisque, odio eu efficitur commodo, tortor tellus accumsan magna, ut eleifend sem
                    velit vitae sapien. Donec nec ornare mi, sit amet mollis neque. Donec mattis sapien elit, at
                    hendrerit diam suscipit in. In molestie ut diam vitae luctus. Duis neque lorem, ultricies eu elit
                    vitae, malesuada varius arcu. Suspendisse lobortis blandit orci sit amet mattis.</p>

            </div>

            <div class="fourth">
                <img src="assets/img/news.jpg">

                <h3>Nulla vitae ultricies metus, sed consequat elit. Suspendisse nisl velit, cursus sed mattis a, varius
                    sit amet nibh. Cras imperdiet nulla vitae euismod blandit. Sed pulvinar nibh ut dolor semper
                    accumsan. Phasellus lorem erat, fringilla vestibulum est</h3>

                <p>Nulla vitae ultricies metus, sed consequat elit. Suspendisse nisl velit, cursus sed mattis a, varius
                    sit amet nibh. Cras imperdiet nulla vitae euismod blandit. Sed pulvinar nibh ut dolor semper
                    accumsan. Phasellus lorem erat, fringilla vestibulum est sit amet, lobortis tincidunt leo. Nam non
                    posuere lorem. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis
                    egestas. Nunc scelerisque, odio eu efficitur commodo, tortor tellus accumsan magna, ut eleifend sem
                    velit vitae sapien. Donec nec ornare mi, sit amet mollis neque. Donec mattis sapien elit, at
                    hendrerit diam suscipit in. In molestie ut diam vitae luctus. Duis neque lorem, ultricies eu elit
                    vitae, malesuada varius arcu. Suspendisse lobortis blandit orci sit amet mattis.</p>

            </div>

            <div class="fourth">
                <img src="assets/img/news.jpg">

                <h3>Comtrade prvi na svetu lansirao bankarsku aplikaciju za VIBER!.</h3>

                <p>Nulla vitae ultricies metus, sed consequat elit. Suspendisse nisl velit, cursus sed mattis a, varius
                    sit amet nibh. Cras imperdiet nulla vitae euismod blandit. Sed pulvinar nibh ut dolor semper
                    accumsan. Phasellus lorem erat, fringilla vestibulum est sit amet, lobortis tincidunt leo. Nam non
                    posuere lorem. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis
                    egestas. Nunc scelerisque, odio eu efficitur commodo, tortor tellus accumsan magna, ut eleifend sem
                    velit vitae sapien. Donec nec ornare mi, sit amet mollis neque. Donec mattis sapien elit, at
                    hendrerit diam suscipit in. In molestie ut diam vitae luctus. Duis neque lorem, ultricies eu elit
                    vitae, malesuada varius arcu. Suspendisse lobortis blandit orci sit amet mattis.</p>

            </div>

            <div class="fourth">
                <img src="assets/img/news.jpg">

                <h3>Comtrade prvi na svetu lansirao bankarsku aplikaciju za VIBER!.</h3>

                <p>Nulla vitae ultricies metus, sed consequat elit. Suspendisse nisl velit, cursus sed mattis a, varius
                    sit amet nibh. Cras imperdiet nulla vitae euismod blandit. Sed pulvinar nibh ut dolor semper
                    accumsan. Phasellus lorem erat, fringilla vestibulum est sit amet, lobortis tincidunt leo. Nam non
                    posuere lorem. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis
                    egestas. Nunc scelerisque, odio eu efficitur commodo, tortor tellus accumsan magna, ut eleifend sem
                    velit vitae sapien. Donec nec ornare mi, sit amet mollis neque. Donec mattis sapien elit, at
                    hendrerit diam suscipit in. In molestie ut diam vitae luctus. Duis neque lorem, ultricies eu elit
                    vitae, malesuada varius arcu. Suspendisse lobortis blandit orci sit amet mattis.</p>

            </div>
        </section>

        <aside>
            <div class="form-wrapper">

                <form action="includes/login.inc.php" id="login">

                    <h2>Login</h2>
                    <input type="text" name="name" placeholder="Your Email"><br>
                    <input type="password" name="password" placeholder="Your Password"><br>

                    <input type="submit" value="Log In">
                </form>

                <form id="register">

                    <h2>Register New Account</h2>
                    <input type="text" name="name" placeholder="Your Name"><br>
                    <input type="email" name="email" placeholder="Your Email"><br>
                    <input type="password" name="password" placeholder="Your Password"><br>

                    <input type="submit" value="Register">

                </form>
            </div>
        </aside>
    </div>
    <!-- End Body Wrapper -->

    <footer>

        <p>Copyright &copy; DanneggiastaCraft 2017.</p>

    </footer>
</div>
<!-- End Site Wrapper -->
</body>
</html>

my db connection code:

<?php

class Dbh {

    private $servername;
    private $username;
    private $password;
    private $dbname;

    protected function connect() {

        $this->servername = "localhost";
        $this->username = "danneggiasta";
        $this->password = "";
        $this->dbname = "news";

        $conn = new mysqli($this->servername, $this->username, $this->password, $this->dbname);

        // Check connection
        if ($conn->connect_error) {
            die("Connection failed: " . $conn->connect_error);
        } else {
            echo "Connected successfully";
            return $conn;
        }
    }
}

my login.php:

<?php

require_once('dbh.inc.php');

class Login extends Dbh {

private $email;
private $pass;

public function userLogin($email, $pass) {

    $conn = parent::connect();


    if (isset($_POST['name'])) {
        $email = $_POST['name'];
    }

    if (isset($_POST['password'])) {
        $pass = $_POST['password'];
    }

    $r = mysqli_query($conn, "SELECT * FROM users WHERE email='$email' and pass='$pass'");

    // If result matched $username and $password, table row must be 1 row
    if ($r->num_rows == 1) {
        session_start();
        $_SESSION['loggedin'] = true;
        $_SESSION['email'] = $email;
        header('Location: http://www.google.com');
    }
 }
}

I would really appreciate any help that u can provide. where did I made a mistake? What is wrong? And if you have any suggestion where I should change my code I will be happy to hear it.

Errors? Please enable error reporting so we can diagnose your issue. — Tom Udding, May 17 '17 at 08:44
Ok i see that i haven;t made a call to my Login function, so i have added it and also i deleted strpslashes cause its old. — Nebojsa Zlatanovic, May 17 '17 at 08:46
is this filepath and filename correct? `action="includes/login.inc.php"` — Chinito, May 17 '17 at 08:49
Well, if you didn't invoke `Login()` it won't work (please update your code in the question). See [How do I get PHP errors to display?](https://stackoverflow.com/q/1053424/5914775) to see how you can enable error reporting. — Tom Udding, May 17 '17 at 08:49
@tomudding i got this from errors: Notice: Undefined index: email in C:\xampp\htdocs\vesti\includes\login.inc.php on line 14 Notice: Undefined index: pass in C:\xampp\htdocs\vesti\includes\login.inc.php on line 15 — Nebojsa Zlatanovic, May 17 '17 at 08:55
@NebojsaZlatanovic pass the `$_POST` variables as parameters in the `userLogin()` function. — Tom Udding, May 17 '17 at 08:56
make sure your email and pass is not empty and check if that data is correct in your database. try using `var_dump()` — Chinito, May 17 '17 at 09:21
data is correct in database, and where do u think i should put var_dump()? — Nebojsa Zlatanovic, May 17 '17 at 09:31
@chinito can u connect with teamviewer to see what is going on? — Nebojsa Zlatanovic, May 17 '17 at 09:32
your error should be on the query. you don't have any error right? or anything that printed on your screen? — Chinito, May 17 '17 at 09:44
are you sure you called this `userLogin` function? if yes, then you should have a printed text on the page. either `Connection failed` or `Connected successfully` — Chinito, May 17 '17 at 10:03
userLogin($_POST['name'], $_POST['password']); } else { echo 'ahafffasgsgasdgsagsgss'; } ?> — Nebojsa Zlatanovic, May 17 '17 at 10:12
i have tryed everything i rly dont know what to do. Please help me. — Nebojsa Zlatanovic, May 17 '17 at 10:19
i don't know your filenames. so it's really difficult to determine the error. `
` so the filename should be `login.inc.php` and in your `login.inc.php` file rename `include "includes/login.inc.php";` to ` include "includes/login.php";` to include your `Login` class — Chinito, May 17 '17 at 10:26
i've got index.php -- main page dbh.inc.php --- db connection login.inc.php --- here is class and method userLogin — Nebojsa Zlatanovic, May 17 '17 at 10:36
one weird thing to me -> you include `includes/login.inc.php` on top of index.php then link it in the `form action` ? — OldPadawan, May 17 '17 at 10:48
@chinito hey man i noticed in login.inc.php my $r = mysqli_query($conn, "SELECT * WHERE email='$email' AND pass='$pass' FROM users"); var_dump($r); -- shows bool(false) error — Nebojsa Zlatanovic, May 18 '17 at 03:24
it should be `$r = mysqli_query($conn, "SELECT * FROM users WHERE email='$email' and pass='$pass'");`. did you connect successfully? — Chinito, May 18 '17 at 06:11

score -2 · Answer 1 · answered May 17 '17 at 09:40

-2

<form action="includes/login.php" id="login">

answered May 17 '17 at 09:40

SMK

61
1
5

login form doesn't redirect

1 Answers1