Rails how to make conditional inside iteration?

Question

i'm trying to use a conditional inside a iteration but did not worked so, here the scenario:

in this case if the if the order or the product is present should just show the order and products with the feedback.

but even if is present show the feedback with odata and pdata.

someone know why?

<% @feedbacks.each do |feedback| %>
      <% if order.present?  && product.present?  %>
      <% order = feedback.order %>
      <% product = order.product %>
      <% else %>
<% odata = feedback.odata %>
  <% pdata = odata.pdata %>
  <% end %>

You are missing a `end`. The `each` execute the block between `do` and `end`. — Alejandro Montilla, May 08 '17 at 18:55
thank you Alejandro is not missing is that have more code down so, i just pust that part — bookaka, May 08 '17 at 18:58
Ok, please take a look at @Md. Farhan Memon's asnwer, please pay attention to the indentation of this answer, and edit your Post with all the code with this identation. — Alejandro Montilla, May 08 '17 at 19:02

score 1 · Accepted Answer · edited May 23 '17 at 12:02

1

I guess this is what you are trying to do,

<% @feedbacks.each do |feedback| %>
  <% if (order = feedback.order).present? && (product = feedback.product).present? %>
    <%= order.title %>
    <%= product.title %>
  <% else %>
    <%= (odata = feedback.odata).name %>
    <%= odata.pdata.name %>
  <% end %>
<% end %>

Note: title and name are assumed columns, replace it with your required/respected attribute. Please go through this to understand the difference between various erb tags.

Comparison:

for the if condition you are trying to call order and product directly, which will throw error as they are related to feedback.
<% %> just executes the ruby code, you wanted to print the data so need to use <%= %>.
no need to save them in variable when you are not going to use it. I have saved them while checking the existence of the object in the condition and could use to display without querying the db.

edited May 23 '17 at 12:02

Community

1
1

answered May 08 '17 at 18:55

Md. Farhan Memon

5,727
2
8
35

yes, but this statement is not the same that i did? – bookaka May 08 '17 at 18:59
now shows undefined local variable or method `product' for # – bookaka May 08 '17 at 19:01
@bookaka check the updated answer, and if still there's error, which line? – Md. Farhan Memon May 08 '17 at 19:04
@md-farhan-memon ok. a moment – bookaka May 08 '17 at 19:12
so, what's the difference of your method with mine? seems like the same – bookaka May 08 '17 at 19:14
yes thank you @md-farhan-memon. very well explained. just one thing besides that worked but now shows # # above the feedbacks, maybe this is related with the ()? – bookaka May 08 '17 at 19:57
Nope, it is not because of that, replace `order`, `product`, `odata` n `pdata` with the respected attributes you wanna display. `product.title` for example. Wait, i'll update that in answer. – Md. Farhan Memon May 08 '17 at 21:05

Rails how to make conditional inside iteration?

1 Answers1