Opening file to read structure array

Question

I'm a beginner in computer science learning c++.

Every attempt that I make to open a file in my program and read the information into a structure does not work.

Here is what I have written in the function.

void getMemberInfo(Payment member[])
{
    ifstream file;
    file.open("information.txt", ios::in);
    int i = 0;

    if (!file)
       cout << "\n Error opening file!\n\n";

    else
    {
        while (!file)
        {
            file >> member[i].ID;
            file.getline(member[i].name, 30, '\n');
            member[i].member_name = member[i].name;
            file >> member[i].payment_due;
            i++;

            if (file.eof())
            break;
    }
}

file.close();
}

Any help is appreciated. I'm kind of at a loss of what's wrong.

Debugger. Use a debugger to determine where the program is going wrong. Edit your post with the results of using a debugger. — Thomas Matthews, Apr 25 '17 at 23:41
Post sample file that you are trying to read and your Payment class — Pavel P, Apr 25 '17 at 23:45
Show the definition of `Payment` and the structure of the input data in the file. — Snps, Apr 25 '17 at 23:50
Thank you everyone. I change the while(!file) to while(file) and it works. I'm making simple mistakes. Still, thanks for the quick answers. — j.pebbles, Apr 26 '17 at 00:01
It _appears_ to work - read http://stackoverflow.com/questions/5431941/why-is-while-feof-file-always-wrong and https://latedev.wordpress.com/2012/12/04/all-about-eof/ — , Apr 26 '17 at 00:05

score -3 · Answer 1 · answered Apr 25 '17 at 23:51

-3

The error is in the while condition. Just change the condition and it should work

// Instead of !file, use !file.eof()
while (!file.eof())

answered Apr 25 '17 at 23:51

Nicolas Nascimento

170
5

Better it should be `while (file)` – Pavel P Apr 25 '17 at 23:52
I think i've been looking at the screen for so long i missed it – j.pebbles Apr 25 '17 at 23:58
1

No. http://stackoverflow.com/questions/5605125/why-is-iostreameof-inside-a-loop-condition-considered-wrong?noredirect=1&lq=1 – Snps Apr 26 '17 at 00:05

Opening file to read structure array

1 Answers1