Why when photoURI passed on the onActivity() says null?? what am i doing wrong

Question

This is my MainActivity other functions actually works except for the buttonUpload. The app unfortunately stops when i hit the buttonUpload.

Any insights guys? badly needs. And also my logcat is not working on android studio 2.3.1 idk why

 public class MainActivity extends AppCompatActivity {

private TrackGPS gps;
private Button buttonUpload;
private EditText editTextMessage;
double longitude;
double latitude;

private StorageReference storage;
private static final int CAMERA_REQUEST_CODE = 1;
private ProgressDialog progressDialog;

String mCurrentPhotoPath;

private File createImageFile() throws IOException {
    // Create an image file name
    String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date());
    String imageFileName = "JPEG_" + timeStamp + "_";
    File storageDir = getExternalFilesDir(Environment.DIRECTORY_PICTURES);
    File image = File.createTempFile(
            imageFileName,  /* prefix */
            ".jpg",         /* suffix */
            storageDir      /* directory */
    );

    // Save a file: path for use with ACTION_VIEW intents
    mCurrentPhotoPath = image.getAbsolutePath();
    return image;
}

private void dispatchTakePictureIntent() {
    Intent takePictureIntent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
    // Ensure that there's a camera activity to handle the intent
    if (takePictureIntent.resolveActivity(getPackageManager()) != null) {
        // Create the File where the photo should go
        File photoFile = null;
        try {
            photoFile = createImageFile();
        } catch (IOException ex) {
            // Error occurred while creating the File...
        }
        // Continue only if the File was successfully created
        if (photoFile != null) {
            Uri photoURI = FileProvider.getUriForFile(this,
                    "com.example.android.fileprovider",
                    photoFile);
            takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT, photoURI);
            startActivityForResult(takePictureIntent, CAMERA_REQUEST_CODE);
        }
    }
}

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    buttonUpload = (Button) findViewById(R.id.buttonUpload);
    editTextMessage = (EditText) findViewById(R.id.editTextMessage);
    storage = FirebaseStorage.getInstance().getReference();
    progressDialog = new ProgressDialog(this);


    buttonUpload.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            //Intent intent = new Intent(MediaStore.ACTION_IMAGE_CAPTURE);
            dispatchTakePictureIntent();

        }
    });
}

@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);

    if(requestCode == CAMERA_REQUEST_CODE && resultCode == RESULT_OK){
        progressDialog.setMessage("Uploading...");
        progressDialog.show();
        Uri uri = data.getData();

        StorageReference filepath = storage.child("Photos").child(uri.getLastPathSegment());
        filepath.putFile(uri).addOnSuccessListener(new OnSuccessListener<UploadTask.TaskSnapshot>() {
            @Override
            public void onSuccess(UploadTask.TaskSnapshot taskSnapshot) {
                Toast.makeText(MainActivity.this, "Upload Successful!", Toast.LENGTH_SHORT).show();
                progressDialog.dismiss();
            }
        }).addOnFailureListener(new OnFailureListener() {
            @Override
            public void onFailure(@NonNull Exception e) {
                Toast.makeText(MainActivity.this, "Upload Failed!", Toast.LENGTH_SHORT).show();
            }
        });
    }
}


public void distressMessage(View view){
    gps = new TrackGPS(MainActivity.this);
    String message = "";

    if(view.getId() == R.id.fab){
        message = editTextMessage.getText().toString();
    }else {
        Button sender = (Button) view;
        message = sender.getText().toString();
    }


    SmsManager smsManager = SmsManager.getDefault();

    if(gps.canGetLocation()){


        longitude = gps.getLongitude();
        latitude = gps.getLatitude();

        smsManager.sendTextMessage("+639972301925", null, message + "\n\nLongitude:"+Double.toString(longitude)+"\nLatitude:"+Double.toString(latitude), null, null);
        Toast.makeText(getApplicationContext(),"Longitude:"+Double.toString(longitude)+"\nLatitude:"+Double.toString(latitude),Toast.LENGTH_SHORT).show();
    }
    else
    {

        gps.showSettingsAlert();
    }


}

}

And here is my Logcat

                                             java.lang.RuntimeException: Unable to resume activity {com.example.niki.currentlocation/com.example.niki.currentlocation.MainActivity}: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1, result=-1, data=null} to activity {com.example.niki.currentlocation/com.example.niki.currentlocation.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.net.Uri android.content.Intent.getData()' on a null object reference
                                                 at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2986)
                                                 at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3017)
                                                 at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2392)
                                                 at android.app.ActivityThread.access$800(ActivityThread.java:151)
                                                 at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303)
                                                 at android.os.Handler.dispatchMessage(Handler.java:102)
                                                 at android.os.Looper.loop(Looper.java:135)
                                                 at android.app.ActivityThread.main(ActivityThread.java:5254)
                                                 at java.lang.reflect.Method.invoke(Native Method)
                                                 at java.lang.reflect.Method.invoke(Method.java:372)
                                                 at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
                                                 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
                                              Caused by: java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1, result=-1, data=null} to activity {com.example.niki.currentlocation/com.example.niki.currentlocation.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.net.Uri android.content.Intent.getData()' on a null object reference
                                                 at android.app.ActivityThread.deliverResults(ActivityThread.java:3574)
                                                 at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2972)
                                                 at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3017) 
                                                 at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2392) 
                                                 at android.app.ActivityThread.access$800(ActivityThread.java:151) 
                                                 at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303) 
                                                 at android.os.Handler.dispatchMessage(Handler.java:102) 
                                                 at android.os.Looper.loop(Looper.java:135) 
                                                 at android.app.ActivityThread.main(ActivityThread.java:5254) 
                                                 at java.lang.reflect.Method.invoke(Native Method) 
                                                 at java.lang.reflect.Method.invoke(Method.java:372) 
                                                 at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) 
                                                 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) 
                                              Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.net.Uri android.content.Intent.getData()' on a null object reference
                                                 at com.example.niki.currentlocation.MainActivity.onActivityResult(MainActivity.java:101)
                                                 at android.app.Activity.dispatchActivityResult(Activity.java:6192)
                                                 at android.app.ActivityThread.deliverResults(ActivityThread.java:3570)
                                                 at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2972) 
                                                 at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3017) 
                                                 at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2392) 
                                                 at android.app.ActivityThread.access$800(ActivityThread.java:151) 
                                                 at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1303) 
                                                 at android.os.Handler.dispatchMessage(Handler.java:102) 
                                                 at android.os.Looper.loop(Looper.java:135) 
                                                 at android.app.ActivityThread.main(ActivityThread.java:5254) 
                                                 at java.lang.reflect.Method.invoke(Native Method) 
                                                 at java.lang.reflect.Method.invoke(Method.java:372) 
                                                 at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) 
                                                 at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)

THIS IS THE PROBLEM. help please

  java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1, result=-1, data=null} to activity {com.example.niki.currentlocation/com.example.niki.currentlocation.MainActivity}: java.lang.NullPointerException: 
 Attempt to invoke virtual method 'android.net.Uri android.content.Intent.getData()' on a null object reference

Remove the `@Override` above `public void onClick(View view) {`. You should have used the `onClick` XML attribute in the first place. It's cleaner — Kostas Andrianos, Apr 15 '17 at 13:40
you might be missing permission for camera, for marshmellow onwards you need to ask for permissions and for below devices you just have to declare in manifest. — Muhib Pirani, Apr 15 '17 at 14:05
@Dinos_12345 Thanks man. it works the problem know is when I press the capture button on the camera it crashes. and i don't know why my logcat shows nothing — DarknessNight, Apr 15 '17 at 18:21
@Est When clicking on your logcat window, there's a drop down menu. If I remember correctly, there's an option called "verbose", select that and check again. — Kostas Andrianos, Apr 15 '17 at 22:48
@Dinos_12345 Thanks, by the way I updated android studio to 2.3.1 and it starts working. I already did what you said and remove on Destroy(). Im facing another problem now ill update the code — DarknessNight, Apr 15 '17 at 23:49
I already did , but nothing happend. can you please show me @cricket_007. sorry im a newbie — DarknessNight, Apr 16 '17 at 00:09
I don't see it... `if (data != null) { uri = data.getData() }`? — OneCricketeer, Apr 16 '17 at 00:16

score 0 · Answer 1 · answered Apr 16 '17 at 00:18

Failure delivering result ResultInfo{who=null, request=1, result=-1, data=null}

You are trying to getData() on something that does not exist.

Put some catches in, then figure out otherwise why this code isn't getting the Intent you expected

@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);

    if(requestCode == CAMERA_REQUEST_CODE && resultCode == RESULT_OK 
            && data != null) {

        progressDialog.setMessage("Uploading...");
        progressDialog.show();
        Uri uri = data.getData();

        if (uri != null) {
            StorageReference filepath = storage.child("Photos").child(uri.getLastPathSegment());
            filepath.putFile(uri).addOnSuccessListener

For example, you have a total of three places here that you are ignoring an error...

if (takePictureIntent.resolveActivity(getPackageManager()) != null) {

    File photoFile = null;
    try {
        photoFile = createImageFile();
    } catch (IOException ex) {
        // #1 Error
        ex.printStackTrace();
    }

    if (photoFile != null) {
        Uri photoURI = FileProvider.getUriForFile(this,
                "com.example.android.fileprovider",
                photoFile);
        takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT, photoURI);
        startActivityForResult(takePictureIntent, CAMERA_REQUEST_CODE);
    } else {// No else ... #2 error
        Log.e("Error", "something bad happened");
    }

} else { // No else... #3 error
     Log.e("Error", "something bad happened");
}

Thanks man it works, there's no more problem but the button doesn't do anything even the progress dialog is not showing after the photo was taken. I would like to save it to firebase storage. maybe i am getting to fast here — DarknessNight, Apr 16 '17 at 00:38
Like I said. This only stops the app from crashing. It doesn't make everything magically work — OneCricketeer, Apr 16 '17 at 00:39

Why when photoURI passed on the onActivity() says null?? what am i doing wrong

1 Answers1