why javascript doesnt run

Question

I am learning JavaScript.

I've written this code, but it does not seem to run.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type" />
<script language="javascript" type="text/javascript">
    function nav(){
        try{
            var str="<table border=1>";
            for (var n in navigator){
                str+="<tr><td>" + n + "</td></tr>";
                }
            str+="</table>
            return("jetzt wird das Ding aufgelistet: <br/>" + str);

        }catch(e){return(e);}

    }
    function writeit(){
    document.write(nav());
    }

</script>
<title>for learning purpos</title>
</head>

<body>
<form>
<script>
    document.write(nav());
</script>

<p>press the button to get the properties in navigator</p>
<input type="button" id="btnNavigator" value="get" onclick="writeit();"/>

</form>
</body>

</html>

If you are receiving a runtime error as your tags would indicate, could you please share what it is? — CollinD, Apr 13 '17 at 18:59
What happens when you step through it in a debugger? [Don't know how to use the debugger? Here's a tutorial.](https://developer.chrome.com/extensions/tut_debugging) — amphetamachine, Apr 13 '17 at 19:03
[Why is document.write considered a “bad practice”?](http://stackoverflow.com/questions/802854/why-is-document-write-considered-a-bad-practice) — epascarello, Apr 13 '17 at 19:31

score 2 · Answer 1 · answered Apr 13 '17 at 19:00

2

You haven't closed one string.

 str+="</table>";

answered Apr 13 '17 at 19:00

Alexander Boman Skoug

98
1
1
9

thanks, may be I am tired, so that I couldnt see it. Anyhow, I use Microsoft Expression Software to code. This software runs fast but give no warning about the errors – Ihsan Ahmed Apr 13 '17 at 19:16
@IhsanAhmed Happens the best of us, use JSLint to validate code, it shows most errors! – Alexander Boman Skoug Apr 13 '17 at 19:27

Philipos D. · Answer 2 · 2017-04-13T19:17:50.967

Best practice is to look into the console from developer tab, inspect page. Also on that tab on the bottom, you can try javascript code or even jQuery if you have the library added.

Your code it's wrong at line 13 you have Invalid or unexpected token because you didn't close the string and at line 30 nav it's not defined.

You can use this code:

    function navBuild(n) 
    {
        var tblS = "<table>";
        var tblE = "</table>";
        var strTrTd = "";
           for (i=1; i<=n; i++)
           {
             strTrTd = strTrTd + "<tr><td>" + i + "</td></tr>";
           }

        var strAll = tblS + strTrTd + tblE;

        console.log(strAll);
        document.getElementById("contentBox").innerHTML = strAll;

    }

And in your HTML you could use:

<input type="button" id="btnNavigator" value="get" onclick="navBuild(5);"/>
<div id="contentBox"></div>

why javascript doesnt run

2 Answers2