Java Scanner for ArrayList data

Question

I'm trying to use a do-while loop to get information for an ArrayList, but I get this output:

Please input your number (type a letter to finish): 2

3

Please input your number (type a letter to finish): 4

Please input your number (type a letter to finish): q

But the operation succeeds and ArrayList contains all three numbers (2, 3, 4) as expected even without the prompt having been printed for one of them

    do {
        num = getNumber("Please input your number (type a letter to finish): ");
        data.add(num);
    } while (console.hasNextInt());

and the method getNumber:

public static int getNumber(String prompt) {
    System.out.print(prompt);
    return console.nextInt();
}

How to I get it to print the prompt for all numbers?

`} while (console.hasNextInt());` can return true/false only if there is data in `System.in` which can be evaluated. But when you are using `nextInt()` in first iteration you are consuming provided value and there is nothing left for `hasNextInt` to test so it need to wait for new value. Another problem is that you are testing if user provided proper number after already reading it first time (since condition is tested after first iteration). Maybe you are looking for something like: [How to handle infinite loop caused by invalid input using Scanner](http://stackoverflow.com/q/3572160) — Pshemo, Mar 10 '17 at 20:22

score 1 · Answer 1 · edited May 23 '17 at 10:30

Your main problem is calling `nextInt()` before `hasNextInt()`.

You need to do it the other way around.

Normally, nextInt() simply consumes the data waited for using hasNextInt(), but if no data has been recieved in this way, nextInt() will itself block. This is what is causing your problem.

Look at the control flow of your program:

getNumber is called
prompt is printed
nextInt() blocks for input
input is given and getNumber returns
in the do-while loop, hasNextInt() blocks for input

Here is the problem, your program waits for input again but no new prompt has had a chance to be printed!
In the next iteration, nextInt() simply consumes the int waited for in step 5
Now the usual pattern of hasNextInt() before nextInt() has been restored, and so your program behaves as expected from this point on

Java Scanner for ArrayList data

1 Answers1

Your main problem is calling nextInt() before hasNextInt().

Your main problem is calling `nextInt()` before `hasNextInt()`.