php inline if statement not working

Question

I am not sure what I am doing wrong, but the inline if statement always returns true, even if it is not supposed to.

I have the following statement

<?php echo ($total == 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7'; ?>

Just above this statement, I echo $total and that echoes out 0

At the top of the page I define <?php $total = 0; ?>, so $total is defined as an integer.

The above if statement only returns false if $total > 64 but not when total is 0

Thanks in advance

@MarkBaker, but there is no nested ternaries in the question — Alex Blex, Mar 02 '17 at 09:27
Possible duplicate of [How do the PHP equality (== double equals) and identity (=== triple equals) comparison operators differ?](http://stackoverflow.com/questions/80646/how-do-the-php-equality-double-equals-and-identity-triple-equals-comp) — TZHX, Mar 02 '17 at 09:44

score 6 · Answer 1 · answered Mar 02 '17 at 09:29

6

It's because 0 == 'Scratched'

 // Strict comparison fixes it
 echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7';

answered Mar 02 '17 at 09:29

smarber

score 3 · Accepted Answer · answered Mar 02 '17 at 09:28

3

This is working

<?php 
$total = 0;
echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7';
?>

answered Mar 02 '17 at 09:28

Hossam

score 3 · Answer 3 · answered Mar 02 '17 at 09:32

Base on your given situation. If I understand it quite well. Your state wont accept it as false if its 0.

The above code should work. But try explicitly adding the not equal zero:

echo ($total === 'Scratched' || ($total > 0 && $total < 65 && $total != 0)) ? 'ffefef' : 'f7f7f7';

Also added === to make sure the first statement of type string.

score 1 · Answer 4 · answered Mar 02 '17 at 09:39

1

Use === to compare $total === 'Scratched' and that will fixed

 <?php echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7'; ?>

answered Mar 02 '17 at 09:39

Rafiqul Islam

score 0 · Answer 5 · edited May 23 '17 at 11:46

0

You can try strict comparison:

<?php echo ($total === 'Scratched' || ($total > 0 && $total < 65)) ? 'ffefef' : 'f7f7f7'; ?>

Because of comparing a numeric variable over a string, the string is evaluated in a numeric context and represents 0.

edited May 23 '17 at 11:46

Community

answered Mar 02 '17 at 09:47

5 Answers5