Angular2 shared/core module in lazy

Question

I have 4 feature modules which will be loaded lazy. Have multiple popups components, which is need for the feature modules. Currently i have created a shared module which will export these component and each feature module will import this shared module. The tradeoff for this kind of design is, the shared module will be included in all the feature bundles. The problem is some popup component is not needed in some feature module.

Any ideas?

"The problem is some popup component is not needed in some feature module." why is that a problem? What would you consider a better approach? — Günter Zöchbauer, Feb 22 '17 at 08:37
suppose i had a, b, c components and 1,2,3 feature modules. a and b is needed in 1 module. b and c is needed in 2 module and module 3 need all a,b,c component — user3118041, Feb 22 '17 at 11:42

score 1 · Answer 1 · answered Feb 22 '17 at 08:38

1

Alternatively you can create a module per popup component and then only import the module with the component you actually want to use.

answered Feb 22 '17 at 08:38

Günter Zöchbauer

490,478
163
1,733
1,404

Yes, That's what am thinking of. But I would like to know whether there is any betterb way to do that. – user3118041 Feb 22 '17 at 11:40
No. You can still create a module that exports several other modules. This way you can get a set of modules by one import. – Günter Zöchbauer Feb 22 '17 at 12:54
Then all imports in the module will be added to bundle right? – user3118041 Feb 22 '17 at 15:45
Not sure what you mean with "to bundle". You can than either add the small modules individually, or a set of them at once. – Günter Zöchbauer Feb 22 '17 at 15:46
When i analyzed the bundles it shows these modules will be in all bundles. I think that's normal – user3118041 Mar 03 '17 at 10:21
Webpack bundle I'm guessing – DarkNeuron May 25 '17 at 09:34
Does it Influences on perfomance If we create SharedPopups and CommonShared modules. – Игорь Демянюк Aug 15 '17 at 14:58
@ИгорьДемянюк no, it doesn't have negative impact on performance. Use shared modules wherever you see fit. You might even be able to improve performance by making certain shared modules lazy-loaded. – Günter Zöchbauer Aug 15 '17 at 15:01
"making certain shared modules lazy-loaded." do you mean just import sharedModule in lazyLoadModule or something else? – Игорь Демянюк Aug 16 '17 at 06:42
@ИгорьДемянюк `sharedModule` and `lazyLoadedModule` don't need to be different modules. You can have any number of both and als any number of modules that are both. – Günter Zöchbauer Aug 16 '17 at 06:46

score 0 · Answer 2 · answered Jun 02 '17 at 20:02

According to best practices that I know, SharedModule should have directives, pipes and shared components.

Your question really depends on how frequent of those so-called "widget" components get imported and how big they are.

If they are small and get used frequent by many other modules, sure, put them in the SharedModule. Having components in SharedModule doesn't mean that you should use them in every other module. It's just that they are common "enough" to be put in SharedModule.

If they are big and not imported by majority of other modules, you may want to treat them as "feature" modules and import them when you need to.

Angular2 shared/core module in lazy

2 Answers2