How to stop location manager?

Question

Don't know why, but sometimes LocationManager is still working also after closing application.

I call startGPS() in onCreate-Methode in one Activity (only one, let me call it StartActivity).

protected void startGPS(){    
 try {           
     lmanager = (LocationManager)getSystemService(Context.LOCATION_SERVICE);
     lmanager.requestLocationUpdates(LocationManager.NETWORK_PROVIDER, 0, 0, this);
     lmanager.requestLocationUpdates(LocationManager.GPS_PROVIDER, 0, 0, this);
 } catch(Exception e) {
     e.printStackTrace();
 }
}

And if this activity will be destroyed (so, when application will be closed), I call endGPS()

public void endGPS(){
 try {           
     lmanager.removeUpdates(this);
     lmanager=null;
 } catch(Exception e) {
  e.printStackTrace();
 }
}

Some ideas, some suggestions, what have I done wrong?!

Schwiz's answer seems like the most likely solution. To confirm, add a debug log entry to your endGPS() method and see if they're called when the application is closed by reviewing LogCat in Eclipse. — Brian, Nov 16 '10 at 18:29
How are you determining that "LocationManager is still working also after closing application"? Also, I am nervous about you calling `requestLocationUpdates()` twice for the same listener object. — CommonsWare, Nov 16 '10 at 18:33
@CommonsWare I can see the gps-icon in status-bar. Should I use two different listeners?! I just read "You can also request location updates from both the GPS and the Network Location Provider by calling requestLocationUpdates() twice—once for NETWORK_PROVIDER and once for GPS_PROVIDER." here http://developer.android.com/guide/topics/location/obtaining-user-location.html — Tima, Nov 16 '10 at 22:11

score 31 · Answer 1 · answered Jul 17 '14 at 09:54

31

You should call the method removeUpdates inside the method onPause:

@Override
protected void onPause() {
    super.onPause();
    locationManager.removeUpdates(this);
    Log.i(TAG, "onPause, done");
}

answered Jul 17 '14 at 09:54

bpz

330
1
3
8

removeUpdates is giving error in my case. please help me – Ankit Mishra Jul 04 '20 at 08:36

score 12 · Accepted Answer · edited Dec 17 '12 at 15:09

12

Is it possible your activity isn't being destroyed? i.e.: you hit the home button. Move your gps start/stop to onStart and onPause.

edited Dec 17 '12 at 15:09

Darkhogg

12,286
4
20
24

answered Nov 16 '10 at 18:19

Nathan Schwermann

30,406
15
78
89

I'll check it tomorrow, but I'm prette sure, that activity will be destroyed. Probably CommonsWare is right and I should use two listeners. But I haven't found any example – Tima Nov 16 '10 at 22:16

score 8 · Answer 3 · answered Nov 16 '10 at 22:25

8

The emulator never gets rid of the GPS icon once loaded. Hence, on an emulator, you cannot use the GPS icon as a test as to whether GPS is still running. On a device, though, the icon should vanish.

Should I use two different listeners?

I sure would. I do not know whether removeUpdates() will remove both, or even if both requests are registered with the single listener.

answered Nov 16 '10 at 22:25

CommonsWare

910,778
176
2,215
2,253

that's the problem, I' testing my application on device and the icon doesn't vanish. I try to work with two listeners – Tima Nov 17 '10 at 08:13
1

Good to know. I got really puzzled about this. – Mister Smith May 08 '12 at 14:57

score 5 · Answer 4 · answered Sep 07 '16 at 10:27

I use: locationManager.removeUpdates(locationListener); Its Working

    @Override
protected void onPause() {
    super.onPause();
    if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
        // TODO: Consider calling
        //    ActivityCompat#requestPermissions
        // here to request the missing permissions, and then overriding
        //   public void onRequestPermissionsResult(int requestCode, String[] permissions,
        //                                          int[] grantResults)
        // to handle the case where the user grants the permission. See the documentation
        // for ActivityCompat#requestPermissions for more details.
        return;
    }


    locationManager.removeUpdates(locationListener);
}

score 2 · Answer 5 · answered Aug 17 '11 at 17:58

2

I see it´s been a while since this post, but maybe it would help some body else. I use: removeUpdates(this), because my listener it´s the activity where I implement de location manager, you need to indicate your listener.

answered Aug 17 '11 at 17:58

Alex

121
3

score 0 · Answer 6 · answered May 22 '20 at 23:20

0

Quite an old queerie but this works for me.

       @Override
        public void onStatusChanged(String s, int i, Bundle bundle) {

        mLocationManager.removeUpdates(locationListener);

        }

answered May 22 '20 at 23:20

Leontin Groza

11
2

How to stop location manager?

6 Answers6

Linked