i cant setText in EditText

Question

LOGCAT Erorrّّّ

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String a.thebook.m_Model.new_book1.getnamebook()' on a null object reference

in java Class

package a.thebook;

import android.content.Intent;
import android.os.Bundle;
import android.support.v7.app.AppCompatActivity;
import android.widget.EditText;
import a.thebook.m_Model.new_book1;
....


public class my_book  extends AppCompatActivity {




    private new_book1 model;
    private EditText  bookname1;



    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.my_book_activity);


        EditText bookname1 = (EditText) findViewById(R.id.editTextbookname2);
         bookname1.setText(model.getbookname());
...



}

get values from firebase Database. new_book1

package a.thebook.m_Model;


import java.util.Objects;


public class new_book1 {


    public String author;
    public String bookname;

    public new_book1() {
    }
    public new_book1(String bookname ,String author) {
        this.bookname = bookname;
        this.author = author;

    }
    public String getauthor(int author) {

        return this.author;
    }
    public String getbookname() {

        return this.bookname;
    }

}

your model has empty text, you didnot set bookname and using getbookname directly — Manohar Reddy, Jan 17 '17 at 11:55
you are not initialize the class new_book1, just created the reference — Navas pk, Jan 17 '17 at 11:56

score 3 · Answer 1 · answered Jan 17 '17 at 11:56

3

You have not initialised your model variable. Hence you are getting a null object error.

Initialise your new_book1 variable and your code will work

Hope this helps :)

answered Jan 17 '17 at 11:56

Aradhna

933
9
19

score 1 · Answer 2 · answered Jan 17 '17 at 12:04

1

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.my_book_activity);
    model = new new_book1("abc","xyz");

    EditText bookname1 = (EditText) findViewById(R.id.editTextbookname2);
     bookname1.setText(model.getbookname());

}

This will help you.

answered Jan 17 '17 at 12:04

divyansh ingle

322
1
9

and don't forget to vote answer :) – divyansh ingle Jan 17 '17 at 12:05

W4R10CK · Answer 3 · 2017-01-17T12:20:38.237

0

Use:

private new_book1 model = new new_book1("myBook", "myself");

edited Jan 17 '17 at 12:20

answered Jan 17 '17 at 11:59

W4R10CK

5,300
2
15
28

2

even this may give NPE , he should initialize like `private new_book1 model = new new_book1("bookName","author");` – Manohar Reddy Jan 17 '17 at 12:17

i cant setText in EditText

3 Answers3