181

I'm using Angular2 2.1.0. When I want to display a list of companies, I got this error.

in file.component.ts :

public companies: any[] = [
    { "id": 0, "name": "Available" },
    { "id": 1, "name": "Ready" },
    { "id": 2, "name": "Started" }
];

In file.component.html :

<tbody>
  <tr *ngFor="let item of companies; let i =index">
     <td>{{i}}</td>
     <td>{{item.name}}</td>
  </tr>
</tbody>
Luis Limas
  • 2,118
  • 18
  • 31
Mourad Idrissi
  • 2,655
  • 5
  • 14
  • 27

28 Answers28

294

Add BrowserModule to imports: [] in @NgModule() if it's the root module (AppModule), otherwise the CommonModule.

// older Angular versions
// import {BrowserModule, CommonModule} from '@angular/common';

import { BrowserModule } from '@angular/platform-browser'
..
..
@NgModule({
  imports: [BrowserModule, /* or CommonModule */],
  ..
})
Günter Zöchbauer
  • 490,478
  • 163
  • 1,733
  • 1,404
  • Is it your only module or do you have more than one? `BrowserModule` is only for the root module. – Günter Zöchbauer Oct 30 '16 at 17:23
  • Can you reproduce in a Plunker? (Plunker provides a ready to use Angular2 TS template). – Günter Zöchbauer Oct 30 '16 at 17:23
  • 2
    yes I have multiple Modules. I forgot this. It works now :) thank u – Mourad Idrissi Oct 30 '16 at 17:37
  • 6
    It might be worth mentioning that the CommonModule is located in '@angular/common' so you must make sure to add import {CommonModule} from '@angular/common' – knsheely Jun 12 '17 at 18:02
  • 5
    I had similar issue. my app has multiple modules, the import Browser module statement needs to be added in app module and in another module. – ssmsnet Sep 12 '17 at 14:18
  • @ssmsnet Importing `BrowserModule` in other modules than `AppModule` is invalid. In other modules `CommonModule` needs to be imported. You should get an error message if you import `BrowserModule` in other modules. – Günter Zöchbauer Sep 12 '17 at 14:20
  • I needed to import `BrowserModule` in a child module to get the `*ngFor` directive working, and I had it in the root too. `CommonModule` is the correct one to import tho, but both modules worked in my child module. No compile error (with angular `5.0.5`) – Sean Newell Dec 14 '17 at 15:11
  • I don't think there was a related change. You should get an error https://github.com/angular/angular/blob/5.1.1/packages/platform-browser/src/browser.ts#L95 – Günter Zöchbauer Dec 14 '17 at 15:44
  • 1
    I had multiple modules. That's saved my day. Thanks! – fabricioflores Sep 04 '18 at 19:53
  • 2
    sometimes it can be a simple typo, the same error happens when doing "*ngFor="let passenger or passengers" – michabbb Feb 08 '19 at 10:57
  • 1
    In the new version of Angular the `BrowserModule` is part of `@angular/platform-browser`. Therefor, you must import as: `import { BrowserModule } from '@angular/platform-browser'` – Ramin Ar Oct 27 '19 at 14:36
  • N.b.: If you get that warning in a unit test, even though you have imported the `CommonModule`, check for dynamically loaded components and ensure that those are also added to your test harness. The compiler possibly omits the `CommonModule` when it is only used in a dynamic component (due to tree shaking). – 1FpGLLjZSZMx6k Apr 18 '20 at 15:44
  • 1
    I had similar issue, But even after trying this it was still not working! I have multiple modules, I forgot to import the "other module" into my "root module" and that was breaking a few of my imports including the `CommonModule` and it was giving me this same error. Thanks for you @Günter this helped me narrow it down and find my real problem. Hope this extra info helps some one, I spent hours trying to find the problem, dooh. – brayden Prestwich Feb 16 '21 at 22:08
61

In my case, the issue was that my teammate mentioned *ngfor in templates instead of *ngFor. Strange that there is no correct error to handle this issue (In Angular 4).

Mr_Green
  • 36,985
  • 43
  • 143
  • 241
49

You have to import 'CommonModule' in the module where you are using these in-built directives like ngFor,ngIf etc.

import { CommonModule } from "@angular/common";


@NgModule({
  imports: [
    CommonModule
  ]
})

export class ProductModule { }
Codiee
  • 2,545
  • 2
  • 13
  • 17
17

For me the problem was that I did not import the custom made module HouseModule in my app.module.ts. I had the other imports.

File: app.module.ts

import { HouseModule } from './Modules/house/house.module';

@NgModule({
  imports: [
    HouseModule
  ]
})
Ruben Szekér
  • 570
  • 3
  • 12
16

This can also happen if you don't declare a route component in your feature module. So for example:

feature.routing.module.ts:

...
    {
        path: '',
        component: ViewComponent,
    }
...

feature.module.ts:

     imports: [ FeatureRoutingModule ],
     declarations: [],

Notice the ViewComponent is not in the declarations array, whereas it should be.

Max Mumford
  • 1,982
  • 4
  • 25
  • 39
14

There can be any possible reason:

  1. Your module does not have CommonModule in imports[]
  2. Your component, where you are using *ngFor, is not a part of any module.
  3. You might have typo in *ngFor i.e. **ngFor or *ngfor etc.
  4. If everything seems fine then restart your IDE i.e. VS Code, IntelliJ etc.
WasiF
  • 15,431
  • 9
  • 81
  • 100
13

Things to remember:

When custom modules are used (modules other than AppModule) then it is necessary to import the common module in it.

yourmodule.module.ts

import { CommonModule } from '@angular/common';

@NgModule({
  imports: [
    CommonModule
  ],
  exports:[ ],
  declarations: []
})
Rut Shah
  • 694
  • 6
  • 9
  • Do you know why i would get that error/warning actually in chrome even after i have the commonModule on my child/custom module class? – Ak777 Jul 10 '20 at 09:39
11

Future Readers

Check each of the following:

  1. The component is declared in a SINGLE angular module
  2. Make sure you have import { CommonModule } from '@angular/common';
  3. Restart the IDE/editor
  4. Restart the dev server (ng serve)
Ben Winding
  • 4,538
  • 2
  • 40
  • 43
  • Just adding CommonModule doesn't fixed the issue, restarting Intelij IDE also was needed. – Patzu Sep 15 '20 at 19:00
  • 1
    Also consider relaunching 'ng serve' as sometimes new code additions are not properly picked up. – Jason K. Nov 15 '20 at 18:12
8

If you are making your own module then add CommonModule in imports in your own module

Alok Kamboj
  • 919
  • 10
  • 11
8

I received the error because the component I was using wasn't registered in the declarations: [] section of the module.

After adding the component the error went away. I would have hoped for something less obscure than this error message to indicate the real problem.

Malcolm Swaine
  • 1,071
  • 14
  • 11
  • Oh thanks, I've created an additional component in an existing .ts file and forget to register it because everything worked until I got this error. – svarog Feb 04 '21 at 09:03
6

I was getting the same error, You can fix through one of this method:

  1. If you don't have any nested module

    a. Import the CommonModule in your App module

    b. Import your Component where you are adding the *ngFor in the App Module, define in declarations

// file App.modules.ts
@NgModule({
  declarations: [
    LoginComponent // declarations of your component
  ],
  imports: [
    BrowserModule
    DemoMaterialModule,
    FormsModule,
    HttpClientModule,
    ReactiveFormsModule,
    AppRoutingModule,
    BrowserAnimationsModule,
    ServiceWorkerModule.register('ngsw-worker.js', { enabled: environment.production })
  ],
  providers: [
    ApiService, 
    CookieService, 
    {
      provide: HTTP_INTERCEPTORS,
      useClass: ApiInterceptor,
      multi: true
    }
  ],
  bootstrap: [AppComponent]
})

c. If you are using the separate module file for routing then Import the CommonModule in your Routing module else Import the CommonModule in your App module

// file app.routing.modules.ts
import { LoginComponent } from './login/login.component';
import { CommonModule } from "@angular/common";

const routes: Routes = [
  { path: '', component: LoginComponent },
  { path: 'login', component: LoginComponent }
];

@NgModule({
  imports: [RouterModule,RouterModule.forRoot(routes), CommonModule],
  exports: [RouterModule]
})
  1. If you have nested module then perform the 1st step in that particular module

In my case, the 2nd method solved my issue.
Hope this will help you

Akshay Sharma
  • 916
  • 1
  • 7
  • 19
4

For Angular 10:

  1. Add BrowserModule to the imports of your routes module.
  2. Make sure that you added the component that not working to the app module declarations.

Failing to do step 2 will trigger this error!

Make sure to RESTART ng serve !!!

Ziv Barber
  • 349
  • 6
  • 10
3

Just in case someone still facing an error after trying to import CommonModule, try to restart the server. It surprisingly work

Ahmad Alfy
  • 11,903
  • 6
  • 59
  • 94
2

Custom Module Needs common module

import { CommonModule } from "@angular/common";


@NgModule({
  imports: [
    CommonModule
  ]
})
Ahmad Alfy
  • 11,903
  • 6
  • 59
  • 94
Vinayak Shedgeri
  • 1,746
  • 19
  • 23
2

I had the same error but I had the CommonModule imported. Instead I left a comma where it shouldn't be because of copy/paste when splitting a module:

@NgModule({
    declarations: [
        ShopComponent,
        ShoppingEditComponent
    ],
    imports: [
        CommonModule,
        FormsModule,
        RouterModule.forChild([
            { path: 'shop', component: ShopComponent }, <--- offensive comma
        ])
    ]
})
scsx
  • 21
  • 1
2

app.module.ts fixed and changed to: import the BrowserModule in your app module

import { BrowserModule } from '@angular/platform-browser';

@NgModule({
  declarations: [
    AppComponent    
  ],
  imports: [
    BrowserModule, 
  ],     
  providers: [],
  bootstrap: [AppComponent]
})
Sanjay kumar
  • 1,547
  • 9
  • 18
2

I have encountered a similar error (*ngIf) even if all my imports were OK and the component was rendered without any other error + routing was OK.

In my case AppModule was not including that specific module. The strange thing is that it did not complain about this, but this might be related with how Ivy works with ng serve (kind of loads modules according to routing, but its dependencies are not considered).

Alexei - check Codidact
  • 17,850
  • 12
  • 118
  • 126
2

So please make sure

  1. No syntax error in directives

  2. Browser (in App Module) and Common (in other/child) Modules are imported (Same what Günter Zöchbauer mentioned above)

  3. If you've routes in the application then route module should be imported in App Module

  4. All the routed component's Module are also imported in App Module, for eg: app-routing.module.ts is as follows:

    const routes: Routes = [

    {path: '', component: CustomerComponent},

    {path: 'admin', component: AdminComponent}

    ];

Then App module must imports modules of CustomerComponent and AdminComponent in @NgModule().

Abhinav Saxena
  • 2,038
  • 1
  • 8
  • 7
1

When use "app-routing.module" we forget import "CommonModule". Remember to import!

import { CommonModule } from "@angular/common";
@NgModule({  imports: [ CommonModule]})
1

I am started on Angular8 base live project got the above issue but When use "app-routing.module" we forget import "CommonModule". Remember to import!

import { CommonModule } from '@angular/common';

@NgModule({
  imports: [
    CommonModule
]})

It will solve your error.

Nagnath Mungade
  • 513
  • 5
  • 8
1

I had a problem because of ** instead *

*ngFor="let ingredient of ingredients"

**ngFor="let ingredient of ingredients"
sunleo
  • 8,787
  • 30
  • 98
  • 173
1

A lot of answers seem to converge by importing CommonModule in other(new/custom) modules.
This step only isn't enough in all situations.

The full solution consist in two steps:

  1. Make directives NgIf, NgFor etc visible to your project.
  2. Reassemble everything in a correct way in the main component (app.module.ts)

Point 1
BrowserModule in main module seems to be enough for having access to NgFor. Angular Documentation stands it here: .

CommonModule Exports all the basic Angular directives and pipes, such as NgIf, NgForOf, DecimalPipe, and so on. Re-exported by BrowserModule,

See also accepted answer here: CommonModule vs BrowserModule in angular

Point 2
The only changes needed (in my case) are the followings:

  1. import Module OtherModule
  2. import Component OtherComponent
  3. ng build (important!)
  4. ng serve

app.module.ts

@NgModule({
    imports: [
        BrowserModule,
        OtherModule
    ],
    declarations: [OtherComponent, AppComponent],
    bootstrap: [AppComponent]
})
export class AppModule {
}

other.html

<div *ngFor='let o of others;'> 
</div>

other.component.ts

@Component({
    selector: 'other-component',
    templateUrl: './other.html'
})
export class OtherComponent {
}

app.module.ts

@NgModule({
    imports: [],
    providers: []
})
export class OtherModule{
}
Ermal
  • 381
  • 5
  • 15
1

After using correct syntax in all of your code, please see if you have mentioned your component in the declarations of your angular module. Something like below:

@NgModule({ declarations: [ AppComponent, YourComponent ],

Maddy
  • 356
  • 4
  • 15
1

For me, what solved the problem was to do a git clone of my project and run (as usual):

npm install
Sofia
  • 461
  • 5
  • 15
1

I had the same problem, even though I had imported "BrowserModule" and "CommonModule" in "module.ts" it didn't work, my error was, not adding in "NgModule.declarations" my Component.

@NgModule ({
   declarations: [
     Your_Component // here
   ]
}) 
Yudner
  • 123
  • 1
  • 6
1

Add the component to your app.module

import { ModalComponent } from './modal/modal.component';

@NgModule({
  declarations: [ModalComponent],
  entryComponents: [ModalComponent],
  
  }),
  providers: [
  ],
  bootstrap: [AppComponent]
})
Lokesh G
  • 672
  • 7
  • 18
1

I had a problem because of blank space in the json data.

user3727574
  • 138
  • 1
  • 8
0

This error can also be thrown when the ngFor syntax isn't written correctly, in my case I had:

<ng-template *ngForOf="let key of SomeObject; index as i">

And it got fixed by using the following syntax:

<ng-template ngFor let-key [ngForOf]="SomeObject" let-i="index">
Luis Limas
  • 2,118
  • 18
  • 31