After creating the second object the constructor program wont ask what I use getline for

Question

So I am relatively new to C++ and I was doing a small project where I have the user enter a movie title, rating, and year. For the first run through, the program works well. After the user enters the desired information I print it back to the screen with no problem. However, when I create a second movie object to do the same thing during the same run it skips the section where it asks for the Title and goes directly to the rating. Any ideas? It's most likely a noob error. My Code is below.

MovieProject.cpp

#include "stdafx.h"
#include "Movie.h"
#include <iostream>
#include <string>
using namespace std;

int main()
{
    Movie starwars;
    starwars.MovieTeller(starwars);
    Movie FerrisBueller;
    FerrisBueller.MovieTeller(FerrisBueller);
    Movie TheFoxandTheHound;
    TheFoxandTheHound.MovieTeller(TheFoxandTheHound);
    return 0;
}

Movie.cpp

    #include "stdafx.h"
    #include "Movie.h"
    #include <string>
    #include <iostream>

using namespace std;

Movie::Movie()
{
    cout << "What is the title of your movie:";
    getline(cin,Title);
    cout << "What is the Rating:";
    getline(cin,Rating);
    cout << "What year was it made:";
    cin >> Year;
    cout << "\n" << endl;
    if (Year > 2016) {
        cout << "Comon Dude stop messing around" << endl;
        exit(404);
    }
}

void Movie::MovieTeller(Movie a) {
    cout << "Title:" << Title << "\n" << "Rating:" << Rating << "\n" << "Year:" << Year << "\n" << endl;
}
Movie::~Movie()
{
}

Movie.h

#pragma once
#include <iostream>
using namespace std;
class Movie
{
public:
    Movie();
    ~Movie();
    void MovieTeller(Movie a);
private:
    string Title;
    string Rating;
    int Year;
};

Asking for input from `constructor` is bad. If you want to create an `array` with 1000 items you will have to make input 1000 times. — LibertyPaul, Jul 30 '16 at 12:35
Most likely there's still something in the input buffer from the previous iteration. — Jonathon Reinhart, Jul 30 '16 at 12:35

score 1 · Accepted Answer · answered Jul 30 '16 at 12:40

1

This happens all the time when you use getline following a read of a number with >> operator.

Here is what's happening: the cal cin >> Year reads all digits from user's input, but leaves the trailing \n in place, because it is not part of the number. When getline is called in a constructor of the next object, the \n is still there, so getline counts this input as an empty line.

You can fix this by adding getline after reading the year, and ignoring its result. However, a better approach would be removing input from the constructor altogether, and moving it into a custom input operator for your class. This way your code would be a lot cleaner.

answered Jul 30 '16 at 12:40

Sergey Kalinichenko

675,664
71
998
1,399

We need a canonical dupe for this. Sick of seeing the same Q&A five times a day! Bet you're sick of writing it, too. – Lightness Races in Orbit Jul 30 '16 at 13:16
@LightnessRacesinOrbit I agree - this is a common problem, but it is very hard to search for on SO, because it presents itself differently. I wrote this as an answer (as opposed to a comment) for the last paragraph in an attempt to correct OP's code organization, which to me is a more serious mistake. – Sergey Kalinichenko Jul 30 '16 at 13:22
Well it deffo should not be a comment – Lightness Races in Orbit Jul 30 '16 at 13:26

score 0 · Answer 2 · edited Jul 30 '16 at 14:54

0

There is also another problem with the code: the method MovieTeller is not acting on instance a passed as an argument to this method. It should be

void Movie::MovieTeller(Movie a) {
    cout << "Title:" << a.Title << "\n" << "Rating:" << a.Rating << "\n" << "Year:" << a.Year << "\n" << endl;
}

OR This method should be declared as public method without any input arguments.

edited Jul 30 '16 at 14:54

Aurora0001

10,827
5
47
50

answered Jul 30 '16 at 12:50

Wielki_i_niezlomny

91
5

After creating the second object the constructor program wont ask what I use getline for

2 Answers2