Reset colours for previous CardViews in RecyclerView

Question

I have an onClick method that sets the current CardView to a colour, but then all the previous CardViews that had theironClick method invoked also have their colour changed. What I am trying to do is to reset all the other CardViews to their original colour and set the current CardView to a different colour.

This is my code:

public ViewHolder(View view) {
    super(view);
    cardView = (CardView) view.findViewById(R.id.card_view);
    view.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            cardView.setBackgroundColor(Color.RED);
        }
    });
}

So the above method sets the background colour for that cardview which is great but I want the others to return back to their original colours. How would I go about doing that?

Thanks

Obiviously you should "store" state in view or viewholder but in underlaying data — Selvin, Feb 24 '16 at 16:32
I don't my thing is like for each cardview which is the problem - the way I wrote it is such that it applies only to one cardview — Lukazs Pioetrszci, Feb 24 '16 at 16:37
`setBackgroundColor(Color.RED)` <= is kind of "storing" state in view ... + fact that it is a RecyclerView = problems — Selvin, Feb 24 '16 at 16:43
why whats wrong about using a `cardview` in a `recyclerview`? It works but then all the other `cardviews` that were previously set are of the same colour — Lukazs Pioetrszci, Feb 24 '16 at 16:45
there is nothing wrong ... setting things(like background color) not based on underlaing data **is** ... — Selvin, Feb 24 '16 at 16:46
I think this is the solution you are looking for - http://stackoverflow.com/questions/29983848/how-to-highlight-the-selected-item-of-recycler-view — Inducesmile, Feb 24 '16 at 18:34

score 0 · Answer 1 · answered Feb 24 '16 at 16:37

0

you use simple list view? if so than it is not correct behaviour. why you just do not set list.setOnItemClick where you can set new color into adapter and call onDataSetChanged?

answered Feb 24 '16 at 16:37

Konstantin Volkov

190
9

Sorry its a recyclerview. I just need some help resetting the other colours of the cardview except the selected one – Lukazs Pioetrszci Feb 24 '16 at 16:43
you can do it by updating adapter's items.http://stackoverflow.com/questions/31367599/how-to-update-recyclerview-adapter-data – Konstantin Volkov Feb 24 '16 at 16:47
how? i am talking about the background data here OF THE CARDVIEW – Lukazs Pioetrszci Feb 24 '16 at 16:49
@Override public void onClick(View v) { cardView = (CardView) view.findViewById(R.id.card_view);cardView.setBackgroundColor(Color.RED); } – Konstantin Volkov Feb 24 '16 at 16:55
OMG why do I even bothering posting here. You havent even answered the question. Your code is already in my OP - sorry I don't think you understood my question - never mind – Lukazs Pioetrszci Feb 24 '16 at 16:59

Reset colours for previous CardViews in RecyclerView

1 Answers1