Angular error when injecting service into my directive

Question

I created a simple service and a simple directive that use that service. Here is how it looks like:

angular.module("app",[]);
angular.module("app").factory('dummyService',dummyService);
angular.module("app").directive('dummyDirective', ['dummyService',dummyDirective]);

function dummyService(){
    this.name = "hello";
}

function dummyDirective(dummyService) {
    return {
        link:function(scope){
            console.log(dummyService.name);
        }
    }
}

However, when I run the code I get:

[$injector:undef] http://errors.angularjs.org/1.4.7/$injector/undef?p0=dummyService

Any suggestions?

I will recommend you to read on how to declare a directive and factory before fixing this one — Sajeetharan, Nov 10 '15 at 16:44
Sajeetharan I rad plenty and it seems to be OK, you have any helpful advice? — RiskX, Nov 10 '15 at 17:00

score 4 · Accepted Answer · edited May 23 '17 at 11:44

4

You should use service instead of factory. In your code change

angular.module("app").factory('dummyService',dummyService);

to

angular.module("app").service('dummyService',dummyService);

if you want to use factory, you need to return object in the factory function:

function dummyService(){
   return {
     name : "hello";
   }  
}

Demo on Jsfiddle

See also: confused about service vs factory

edited May 23 '17 at 11:44

Community

1
1

answered Nov 10 '15 at 17:08

giladk

176
6

Damn I can't believe I missed that. Thank you so much! – RiskX Nov 10 '15 at 17:34

score -1 · Answer 2 · answered Nov 10 '15 at 16:43

-1

You don't pass the dependency for the directive:

angular.module("app").directive('dummyDirective', ['dummyService', dummyDirective(dummyService)]);

answered Nov 10 '15 at 16:43

Marios Fakiolas

1,505
1
12
19

You don't pass arguments to a function on that line because we don't execute the function there only passing it as a parameter(Angular suppose to pass the argument when it execute the function). Any way I tried your way just to be safe but it didn't help. Any more ideas? Thanks! – RiskX Nov 10 '15 at 16:58

Angular error when injecting service into my directive

2 Answers2