Reading from file adds extra space

Question

When I'm reading from a file it adds one space at the end. So after, when I need to sort the string, it sorts the extra space too. And is added to the output file.

int main()
{
    int siz=1000000;
    char a[siz];

    ifstream readfile("AllAlpha.txt");
    ofstream outfile("sorted.txt");

    if(!readfile)
    {
        cout << "An error occurred while opening the input data stream file \"AllAlpha.txt\"!" << endl;
        return 1;
    }
    // read file
    int i=0;
    while (!readfile.eof())
    {
        readfile.get(a[i]);
        i++;
    }
    int size=i;

    // sort the array
    //quicksort(a, 0, size-1);

    // output sorted array to file
    for (int num=0;num<size;num++)
    {
        outfile<<a[num];
    }
    return 0;
}

[Why is iostream::eof inside a loop condition considered wrong?](http://stackoverflow.com/questions/5605125/why-is-iostreameof-inside-a-loop-condition-considered-wrong) — πάντα ῥεῖ, Oct 14 '15 at 20:37

score 1 · Answer 1 · answered Oct 14 '15 at 20:45

1

By using:

readfile.get(a[i]);
i++;

You are assuming that readfile.get(a[i]) was successful. That is not true after you have read the last character of the file.

Change your loop to:

char c;
while (readfile.get(c))
{
   a[i] = c;
   ++i;
}

answered Oct 14 '15 at 20:45

R Sahu

196,807
13
136
247

if i do that it makes errors it says i is undeclared at int size=i; – Oct 14 '15 at 20:58
@PolBol, what's the error you are seeing? – R Sahu Oct 14 '15 at 20:59
@R Sahu, nevermind, it looks like it was problem with the compiler, it's sorted now. thanks – Oct 14 '15 at 21:04

cowdrool · Answer 2 · 2015-10-14T21:07:43.013

0

This may be a perfect example of why using readfile.eof () in a while condition is almost always wrong: the eof flag is only set once the end of the file is actually read. So in this case, the end of the file is read and assigned to a[i] then iostream::eof is set, and only then does program execution continue beyond the while loop.

edited Oct 14 '15 at 21:07

answered Oct 14 '15 at 20:48

cowdrool

304
1
6

so simply cutting the last element from the read array would tehnically get rid of the extra space? – Oct 14 '15 at 21:00

Reading from file adds extra space

2 Answers2