iOS 9: Frame no longer set in viewWillAppear after UINavigationController pushViewController

Question

I'm trying to solve a view placement bug that has arisen as of iOS 9. I am instantiating a view controller from a xib file (non-autolayout) and then pushing this onto my UINavigationController.

The problem is that when the view controller's viewWillAppear method is called, its frame has not yet been adjusted to the navigation controller's size and is still what was set in the xib file. It doesn't get set properly now until viewDidAppear.

This is completely screwing up my code. Does anyone know precisely what has changed that is causing this and what is the best way to handle it? I don't want to wait until viewDidAppear because this will look bad and make for a poor user experience.

I am encountering the same issue. Upon further inspection it looks like the child view hasn't even been added to the UINavigationController's view yet (view.superview == nil) — Brody Robertson, Sep 29 '15 at 19:25

score 11 · Accepted Answer · answered Sep 19 '15 at 04:04

11

I am also looking for the best fix.

My temporary one is to call the code that was in "viewDidAppear" in "viewDidLayoutSubviews". That way, my code will get called as soon as the frames are set.

But, make sure to add a boolean or something so that your code doesn't get called every time viewDidLayoutSubviews is called

-(void)viewDidLayoutSubviews{
   if (didLayoutSubviews == NO){
       didLayoutSubviews = YES;
       // perform code that was in viewWillAppear
   }
}

answered Sep 19 '15 at 04:04

NickProvost

357
5
20

Thanks Nick, this did the trick! Unfortunate that this is necessary. `viewWillAppear` was the perfect conceptual place to put this code previously. Now it feels like we have to do a hack to do what came naturally before. :( – devios1 Sep 21 '15 at 17:26

score 0 · Answer 2 · answered Oct 06 '15 at 06:05

0

I occurred this issue too,

try to uncheck option "Resize View From NIB" from storyboard

answered Oct 06 '15 at 06:05

PatrickSCLin

1,307
1
14
43

score 0 · Answer 3 · answered Oct 07 '15 at 06:49

0

Try moving the layout code from viewWillAppear to viewWillLayoutSubviews.

answered Oct 07 '15 at 06:49

Ken

597
4
8
29

score 0 · Answer 4 · answered Feb 21 '17 at 14:30

A little bit updated NickProvost's answer:

private var loadViewToken: dispatch_once_t = 0

override func viewDidLayoutSubviews() {
    super.viewDidLayoutSubviews()
    dispatch_once(&loadViewToken) { [weak self] in
        if let wSelf = self {
            wSelf.setupView()
        }
    }
}

iOS 9: Frame no longer set in viewWillAppear after UINavigationController pushViewController

4 Answers4

Linked

Related