22

This is partly academic, as for my purposes I only need it rounded to two decimal places; but I am keen to know what is going on to produce two slightly different results.

This is the test that I wrote to narrow it to the simplest implementation:

@Test
public void shouldEqual() {
  double expected = 450.00d / (7d * 60);  // 1.0714285714285714
  double actual = 450.00d / 7d / 60;      // 1.0714285714285716

  assertThat(actual).isEqualTo(expected);
}

But it fails with this output:

org.junit.ComparisonFailure: 
Expected :1.0714285714285714
Actual   :1.0714285714285716

Can anyone explain in detail what is going on under the hood to result in the value at 1.000000000000000X being different?

Some of the points I'm looking for in an answer are: Where is the precision lost? Which method is preferred, and why? Which is actually correct? (In pure maths, both can't be right. Perhaps both are wrong?) Is there a better solution or method for these arithmetic operations?

Ben Pearson
  • 6,882
  • 4
  • 28
  • 49
  • Already answered [here](http://stackoverflow.com/questions/5257166/java-floats-and-doubles-how-to-avoid-that-0-0-0-1-0-1-0-9000001). – Uwe Plonus Apr 24 '15 at 08:05
  • 1
    @UwePlonus I don't think so. That question and its answers how to get rid of the effect, not an explanation of what is really going on under the hood. – David Z Apr 24 '15 at 08:06
  • 2
    Because it will actually make a different calculation. The first line gives `450.00d / (420d)` (no loss of precision in the first step which calculates `7d * 60`). The second line calculates `450.00d / 7d` first and stores the result, there's a small amount of precision lost in this step because of the way computers store floating point numbers, and then divides this result of that by 60. You can read up on how floating point numbers work here: http://floating-point-gui.de/formats/fp/ – Nils O Apr 24 '15 at 08:07
  • @DavidZ [One of the answers](http://stackoverflow.com/a/5257208/1813616) has the correct answer in it. – Uwe Plonus Apr 24 '15 at 08:08
  • http://stackoverflow.com/questions/8253789/double-calculation-producing-odd-result also answered here i think – Zelldon Apr 24 '15 at 08:08
  • It's just rounding, man. Can you specify exactly what you're looking for in an answer? – Radiodef Apr 24 '15 at 08:08
  • 1
    @UwePlonus no, I don't think that qualifies as the detailed explanation Ben is asking for here. – David Z Apr 24 '15 at 08:13
  • Not an explanation but `450.00d / 60 / 7d` will give you the expected result. – maba Apr 24 '15 at 08:16
  • The question has been updated to reflect some of the points I was hoping would be addressed in an answer. – Ben Pearson Apr 24 '15 at 08:37
  • 3
    If oddities around how Java does floating point arithmetic interest you, you might want to read my archive of articles here http://blogs.msdn.com/b/ericlippert/archive/tags/floating+point+arithmetic/ and here http://ericlippert.com/tag/floating-point-arithmetic/. Though these are about C# and JavaScript, pretty much all of it applies equally well to Java. – Eric Lippert Apr 24 '15 at 14:50
  • 1
    This should be linked in every question about FP: [What every computer scientist should know about floating-point arithmetic](http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html) – Hong Ooi Apr 24 '15 at 16:01
  • 1
    with limited precision, even decimal faces the same problem. For example with 5 significant digits 8/3/2 = 2.6667/2 = 1.3334, 8/(3*2) = 8/6 = 1.3333 – phuclv Apr 24 '15 at 17:29

5 Answers5

42

I see a bunch of questions that tell you how to work around this problem, but not one that really explains what's going on, other than "floating-point roundoff error is bad, m'kay?" So let me take a shot at it. Let me first point out that nothing in this answer is specific to Java. Roundoff error is a problem inherent to any fixed-precision representation of numbers, so you get the same issues in, say, C.

Roundoff error in a decimal data type

As a simplified example, imagine we have some sort of computer that natively uses an unsigned decimal data type, let's call it float6d. The length of the data type is 6 digits: 4 dedicated to the mantissa, and 2 dedicated to the exponent. For example, the number 3.142 can be expressed as

3.142 x 10^0

which would be stored in 6 digits as

503142

The first two digits are the exponent plus 50, and the last four are the mantissa. This data type can represent any number from 0.001 x 10^-50 to 9.999 x 10^+49.

Actually, that's not true. It can't store any number. What if you want to represent 3.141592? Or 3.1412034? Or 3.141488906? Tough luck, the data type can't store more than four digits of precision, so the compiler has to round anything with more digits to fit into the constraints of the data type. If you write

float6d x = 3.141592;
float6d y = 3.1412034;
float6d z = 3.141488906;

then the compiler converts each of these three values to the same internal representation, 3.142 x 10^0 (which, remember, is stored as 503142), so that x == y == z will hold true.

The point is that there is a whole range of real numbers which all map to the same underlying sequence of digits (or bits, in a real computer). Specifically, any x satisfying 3.1415 <= x <= 3.1425 (assuming half-even rounding) gets converted to the representation 503142 for storage in memory.

This rounding happens every time your program stores a floating-point value in memory. The first time it happens is when you write a constant in your source code, as I did above with x, y, and z. It happens again whenever you do an arithmetic operation that increases the number of digits of precision beyond what the data type can represent. Either of these effects is called roundoff error. There are a few different ways this can happen:

  • Addition and subtraction: if one of the values you're adding has a different exponent from the other, you will wind up with extra digits of precision, and if there are enough of them, the least significant ones will need to be dropped. For example, 2.718 and 121.0 are both values that can be exactly represented in the float6d data type. But if you try to add them together:

       1.210     x 10^2
    +  0.02718   x 10^2
    -------------------
       1.23718   x 10^2
    

    which gets rounded off to 1.237 x 10^2, or 123.7, dropping two digits of precision.

  • Multiplication: the number of digits in the result is approximately the sum of the number of digits in the two operands. This will produce some amount of roundoff error, if your operands already have many significant digits. For example, 121 x 2.718 gives you

       1.210     x 10^2
    x  0.02718   x 10^2
    -------------------
       3.28878   x 10^2
    

    which gets rounded off to 3.289 x 10^2, or 328.9, again dropping two digits of precision.

    However, it's useful to keep in mind that, if your operands are "nice" numbers, without many significant digits, the floating-point format can probably represent the result exactly, so you don't have to deal with roundoff error. For example, 2.3 x 140 gives

       1.40      x 10^2
    x  0.23      x 10^2
    -------------------
       3.22      x 10^2
    

    which has no roundoff problems.

  • Division: this is where things get messy. Division will pretty much always result in some amount of roundoff error unless the number you're dividing by happens to be a power of the base (in which case the division is just a digit shift, or bit shift in binary). As an example, take two very simple numbers, 3 and 7, divide them, and you get

       3.                x 10^0
    /  7.                x 10^0
    ----------------------------
       0.428571428571... x 10^0
    

    The closest value to this number which can be represented as a float6d is 4.286 x 10^-1, or 0.4286, which distinctly differs from the exact result.

As we'll see in the next section, the error introduced by rounding grows with each operation you do. So if you're working with "nice" numbers, as in your example, it's generally best to do the division operations as late as possible because those are the operations most likely to introduce roundoff error into your program where none existed before.

Analysis of roundoff error

In general, if you can't assume your numbers are "nice", roundoff error can be either positive or negative, and it's very difficult to predict which direction it will go just based on the operation. It depends on the specific values involved. Look at this plot of the roundoff error for 2.718 z as a function of z (still using the float6d data type):

roundoff error for multiplication by 2.718

In practice, when you're working with values that use the full precision of your data type, it's often easier to treat roundoff error as a random error. Looking at the plot, you might be able to guess that the magnitude of the error depends on the order of magnitude of the result of the operation. In this particular case, when z is of the order 10-1, 2.718 z is also on the order of 10-1, so it will be a number of the form 0.XXXX. The maximum roundoff error is then half of the last digit of precision; in this case, by "the last digit of precision" I mean 0.0001, so the roundoff error varies between -0.00005 and +0.00005. At the point where 2.718 z jumps up to the next order of magnitude, which is 1/2.718 = 0.3679, you can see that the roundoff error also jumps up by an order of magnitude.

You can use well-known techniques of error analysis to analyze how a random (or unpredictable) error of a certain magnitude affects your result. Specifically, for multiplication or division, the "average" relative error in your result can be approximated by adding the relative error in each of the operands in quadrature - that is, square them, add them, and take the square root. With our float6d data type, the relative error varies between 0.0005 (for a value like 0.101) and 0.00005 (for a value like 0.995).

relative error in values between 0.1 and 1

Let's take 0.0001 as a rough average for the relative error in values x and y. The relative error in x * y or x / y is then given by

sqrt(0.0001^2 + 0.0001^2) = 0.0001414

which is a factor of sqrt(2) larger than the relative error in each of the individual values.

When it comes to combining operations, you can apply this formula multiple times, once for each floating-point operation. So for instance, for z / (x * y), the relative error in x * y is, on average, 0.0001414 (in this decimal example) and then the relative error in z / (x * y) is

sqrt(0.0001^2 + 0.0001414^2) = 0.0001732

Notice that the average relative error grows with each operation, specifically as the square root of the number of multiplications and divisions you do.

Similarly, for z / x * y, the average relative error in z / x is 0.0001414, and the relative error in z / x * y is

sqrt(0.0001414^2 + 0.0001^2) = 0.0001732

So, the same, in this case. This means that for arbitrary values, on average, the two expressions introduce approximately the same error. (In theory, that is. I've seen these operations behave very differently in practice, but that's another story.)

Gory details

You might be curious about the specific calculation you presented in the question, not just an average. For that analysis, let's switch to the real world of binary arithmetic. Floating-point numbers in most systems and languages are represented using IEEE standard 754. For 64-bit numbers, the format specifies 52 bits dedicated to the mantissa, 11 to the exponent, and one to the sign. In other words, when written in base 2, a floating point number is a value of the form

1.1100000000000000000000000000000000000000000000000000 x 2^00000000010
                       52 bits                             11 bits

The leading 1 is not explicitly stored, and constitutes a 53rd bit. Also, you should note that the 11 bits stored to represent the exponent are actually the real exponent plus 1023. For example, this particular value is 7, which is 1.75 x 22. The mantissa is 1.75 in binary, or 1.11, and the exponent is 1023 + 2 = 1025 in binary, or 10000000001, so the content stored in memory is

01000000000111100000000000000000000000000000000000000000000000000
 ^          ^
 exponent   mantissa

but that doesn't really matter.

Your example also involves 450,

1.1100001000000000000000000000000000000000000000000000 x 2^00000001000

and 60,

1.1110000000000000000000000000000000000000000000000000 x 2^00000000101

You can play around with these values using this converter or any of many others on the internet.

When you compute the first expression, 450/(7*60), the processor first does the multiplication, obtaining 420, or

1.1010010000000000000000000000000000000000000000000000 x 2^00000001000

Then it divides 450 by 420. This produces 15/14, which is

1.0001001001001001001001001001001001001001001001001001001001001001001001...

in binary. Now, the Java language specification says that

Inexact results must be rounded to the representable value nearest to the infinitely precise result; if the two nearest representable values are equally near, the one with its least significant bit zero is chosen. This is the IEEE 754 standard's default rounding mode known as round to nearest.

and the nearest representable value to 15/14 in 64-bit IEEE 754 format is

1.0001001001001001001001001001001001001001001001001001 x 2^00000000000

which is approximately 1.0714285714285714 in decimal. (More precisely, this is the least precise decimal value that uniquely specifies this particular binary representation.)

On the other hand, if you compute 450 / 7 first, the result is 64.2857142857..., or in binary,

1000000.01001001001001001001001001001001001001001001001001001001001001001...

for which the nearest representable value is

1.0000000100100100100100100100100100100100100100100101 x 2^00000000110

which is 64.28571428571429180465... Note the change in the last digit of the binary mantissa (compared to the exact value) due to roundoff error. Dividing this by 60 gives you

1.000100100100100100100100100100100100100100100100100110011001100110011...

Look at the end: the pattern is different! It's 0011 that repeats, instead of 001 as in the other case. The closest representable value is

1.0001001001001001001001001001001001001001001001001010 x 2^00000000000

which differs from the other order of operations in the last two bits: they're 10 instead of 01. The decimal equivalent is 1.0714285714285716.

The specific rounding that causes this difference should be clear if you look at the exact binary values:

1.0001001001001001001001001001001001001001001001001001001001001001001001...
1.0001001001001001001001001001001001001001001001001001100110011001100110...
                                                     ^ last bit of mantissa

It works out in this case that the former result, numerically 15/14, happens to be the most accurate representation of the exact value. This is an example of how leaving division until the end benefits you. But again, this rule only holds as long as the values you're working with don't use the full precision of the data type. Once you start working with inexact (rounded) values, you no longer protect yourself from further roundoff errors by doing the multiplications first.

David Z
  • 116,302
  • 26
  • 230
  • 268
5

It has to do with how the double type is implemented and the fact that the floating-point types don't make the same precision guarantees as other simpler numerical types. Although the following answer is more specifically about sums, it also answers your question by explaining how there is no guarantee of infinite precision in floating-point mathematical operations: Why does changing the sum order returns a different result?. Essentially you should never attempt to determine the equality of floating-point values without specifying an acceptable margin of error. Google's Guava library includes DoubleMath.fuzzyEquals(double, double, double) to determine the equality of two double values within a certain precision. If you wish to read up on the specifics of floating-point equality this site is quite useful; the same site also explains floating-point rounding errors. In summation: the expected and actual values of your calculation differ because of the rounding differing between the calculations due to the order of operations.

Community
  • 1
  • 1
Emily Mabrey
  • 1,468
  • 1
  • 12
  • 27
4

Let's simplify things a bit. What you want to know is why 450d / 420 and 450d / 7 / 60 (specifically) give different results.

Let's see how division is performed in IEE double-precision floating point format. Without going deep into implementation details, it's basically XOR-ing the sign bit, subtracting the exponent of the divisor from the exponent of the dividend, dividing the mantissas, and normalizing the result.

First, we should represent our numbers in the proper format for double:

450    is  0 10000000111 1100001000000000000000000000000000000000000000000000

420    is  0 10000000111 1010010000000000000000000000000000000000000000000000

7      is  0 10000000001 1100000000000000000000000000000000000000000000000000

60     is  0 10000000100 1110000000000000000000000000000000000000000000000000

Let's first divide 450 by 420

First comes the sign bit, it's 0 (0 xor 0 == 0).

Then comes the exponent. 10000000111b - 10000000111b + 1023 == 10000000111b - 10000000111b + 01111111111b == 01111111111b

Looking good, now the mantissa:

1.1100001000000000000000000000000000000000000000000000 / 1.1010010000000000000000000000000000000000000000000000 == 1.1100001 / 1.101001. There are a couple of different ways to do this, I'll talk a bit about them later. The result is 1.0(001) (you can verify it here).

Now we should normalize the result. Let's see the guard, round and sticky bit values:

0001001001001001001001001001001001001001001001001001 0 0 1

Guard bit's 0, we don't do any rounding. The result is, in binary:

0 01111111111 0001001001001001001001001001001001001001001001001001

Which gets represented as 1.0714285714285714 in decimal.

Now let's divide 450 by 7 by analogy.

Sign bit = 0

Exponent = 10000000111b - 10000000001b + 01111111111b == -01111111001b + 01111111111b + 01111111111b == 10000000101b

Mantissa = 1.1100001 / 1.11 == 1.00000(001)

Rounding:

0000000100100100100100100100100100100100100100100100 1 0 0

Guard bit is set, round and sticky bits are not. We are rounding to-nearest (default mode for IEEE), and we're stuck right between the two possible values which we could round to. As the lsb is 0, we add 1. This gives us the rounded mantissa:

0000000100100100100100100100100100100100100100100101

The result is

0 10000000101 0000000100100100100100100100100100100100100100100101

Which gets represented as 64.28571428571429 in decimal.

Now we will have to divide it by 60... But you already know that we have lost some precision. Dividing 450 by 420 didn't require rounding at all, but here, we already had to round the result at least once. But, for completeness's sake, let's finish the job:

Dividing 64.28571428571429 by 60

Sign bit = 0

Exponent = 10000000101b - 10000000100b + 01111111111b == 01111111110b

Mantissa = 1.0000000100100100100100100100100100100100100100100101 / 1.111 == 0.10001001001001001001001001001001001001001001001001001100110011

Round and shift:

0.1000100100100100100100100100100100100100100100100100 1 1 0 0

1.0001001001001001001001001001001001001001001001001001 1 0 0

Rounding just as in the previous case, we get the mantissa: 0001001001001001001001001001001001001001001001001010.

As we shifted by 1, we add that to the exponent, getting

Exponent = 01111111111b

So, the result is:

0 01111111111 0001001001001001001001001001001001001001001001001010

Which gets represented as 1.0714285714285716 in decimal.

Tl;dr:

The first division gave us:

0 01111111111 0001001001001001001001001001001001001001001001001001

And the last division gave us:

0 01111111111 0001001001001001001001001001001001001001001001001010

The difference is in the last 2 bits only, but we could have lost more - after all, to get the second result, we had to round two times instead of none!

Now, about mantissa division. Floating-point division is implemented in two major ways.

The way mandated by the IEEE long division (here are some good examples; it's basically the regular long division, but with binary instead of decimal), and it's pretty slow. That is what your computer did.

There is also a faster but less accrate option, multiplication by inverse. First, a reciprocal of the divisor is found, and then multiplication is performed.

Mints97
  • 5,492
  • 4
  • 30
  • 65
1

That's because double division often lead to a loss of precision. Said loss can vary depending on the order of the divisions.

When you divide by 7d, you already lost some precision with the actual result. Then only you divide an erroneous result by 60.

When you divide by 7d * 60, you only have to use division once, thus losing precision only once.

Note that double multiplication can sometimes fail too, but that's much less common.

Bainos
  • 121
  • 3
  • "Note that double multiplication can sometimes fail too, but that's much less common" - it's only less common for integer arguments. It's about as common for non-integers; for example, `0.1*0.1 != 0.01`. – user2357112 supports Monica Apr 24 '15 at 08:26
0

Certainly the order of the operations mixed with the fact that doubles aren't precise :

450.00d / (7d * 60) --> a = 7d * 60 --> result = 450.00d / a

vs

450.00d / 7d / 60 --> a = 450.00d /7d --> result = a / 60
Michael Laffargue
  • 9,799
  • 6
  • 39
  • 74