PHP preg_replace with groups of numbers

Question

Alright here is what I have

$string=Something something 1234-123'; //can be an arbitrary amount of digits on each side of hyphen $numbers=preg_replace("/.*([0-9]*-[0-9]*).*/","$1", $string); echo $numbers;

This is printing out just "-123", it should be printing out 1234-123. I feel like i'm just missing something really simple here.

i tested this out on regex101.com with the expression: ([0-9]*-[0-9]*) and with the test string: Something something 1234-123, the result was that i got: 1234-123 — Giovanni Le Grand, Mar 15 '15 at 01:42
If you only want to **extract** 1234-123 don't use `preg_replace`, use **`preg_match`** — Casimir et Hippolyte, Mar 15 '15 at 02:19

score 1 · Accepted Answer · edited May 23 '17 at 10:24

1

Should be more non-greedy I guess

.*?([0-9]*-[0-9]*).*

edited May 23 '17 at 10:24

Community

1
1

answered Mar 15 '15 at 01:42

Dhiraj

31,130
7
57
77

1

will do, i have to wait 10 more minutes to do so. – dougparker16 Mar 15 '15 at 01:44
sorry, got confused in a hurry. Thanks for pointing out @AvinashRaj – Dhiraj Mar 15 '15 at 01:52

score 0 · Answer 2 · answered Mar 15 '15 at 12:46

0

I'd use preg_match instead:

$string = 'Something something 1234-123';
preg_match('/\d+-\d+/', $string, $match);
echo $match[0],"\n";

Output:

1234-123

answered Mar 15 '15 at 12:46

Toto

83,193
59
77
109

PHP preg_replace with groups of numbers

2 Answers2