Changing text by calling javascript

Question

im trying to change a line of text if a link is clicked, however it doesnt seem to be calling my script to change it.

<script >
         var paragraphToChange = document.getElementById("q1");
         paragraphToChange.innerHTML ="Quotation is by:" + <a href="http://www.quotationspage.com/quote/1463.html">Antole France</a>

</script>


 <div id="body">
       <p>javascript.html - JavaScript page</p>
       <a href id="q1">Quotaion is by:</a>
 </div>

you have to do this after the html has been loaded. and where is your click event? — Daniel A. White, Feb 12 '15 at 18:56
There is so much wrong with this I don't know where to begin. How about: Why do you think this should do anything at all in response to something being clicked? (You also really, really need to open your browsers developer tools and read the error messages on the console) — Quentin, Feb 12 '15 at 18:57
I'm pretty new to this lol, its not showing anything.. im coding it in n++ — Andrew Barsoom, Feb 12 '15 at 18:59
Start by studying the simple example given in: http://www.w3schools.com/jsref/event_onclick.asp — Igor, Feb 12 '15 at 19:06

score 0 · Answer 1 · answered Feb 12 '15 at 19:01

0

Sir you have to set the value of "newValue" to the quotation.

    var newValue = '"Quotation is by:" + <a href="http://www.quotationspage.com/quote/1463.html">Antole France</a>'
    paragraphToChange.innerHTML = newValue;

answered Feb 12 '15 at 19:01

Hassan Al Bourji

183
1
13

Nope, developer tools returns : Uncaught typeError: cannot set property 'innerHTML' of null in the ' paragraphToChange.innerHTML = newValue;' line – Andrew Barsoom Feb 12 '15 at 19:03

namhoaingo · Answer 2 · 2015-02-12T19:24:03.150

0

You are missing the click event on the Html tag. Hence, this paragraphToChange.innerHTML ="Quotation is by:" + <a href="http://www.quotationspage.com/quote/1463.html">Antole France</a>" never gets call.

Why don't you start with this example first:

<p id="display"></p>

<button onclick="displayBob">Bob</button>
<button onclick="displayTom">Tom</button>

<script>
displayBob = function ()
{
document.getElementById("display").innerHTML = "Hello Bob";
}

displayTom = function ()
{ 
document.getElementById("display").innerHTML = "Hello Tom";
}
</script>

edited Feb 12 '15 at 19:24

answered Feb 12 '15 at 19:07

namhoaingo

83
7

That won't work, you're not executing the function in the onClick event. – ksbg Feb 12 '15 at 19:16
That was my bad. I edited the example. I should work now – namhoaingo Feb 12 '15 at 19:24

ksbg · Accepted Answer · 2015-02-12T19:17:12.583

0

What you're trying to accomplish is probably something like this:

HTML

<div id="q1">
<a onClick="javascript:clickFunction()">Quotation is by</a>
</div>

JavaScript

clickFunction = function() {
    document.getElementById("q1").innerHTML = "<a href='http://www.quotationspage.com/quote/1463.html'>Antole France</a>";
}

JSFiddle

edited Feb 12 '15 at 19:17

answered Feb 12 '15 at 19:08

ksbg

2,916
1
19
29

It ends up writing it at the bottom of the original text instead of replacing it. edit: nvm fixed it, Thanks! – Andrew Barsoom Feb 12 '15 at 19:14

Changing text by calling javascript

3 Answers3