C# System.IndexOutOfRangeException Error

Question

Ok so i'm currently building a project where you import a list of proxy's but for some reason I'm getting a System.IndexOutOfRangeException Error which is really bugging me now.

So here is the code it's showing on.

        private void LoadProxies()
    {
        accChecker.Proxies.Clear();

        using (OpenFileDialog ofd = new OpenFileDialog())
        {
            ofd.Title = "Choose a file containing a list of proxies...";
            ofd.Filter = "Text Files (*.txt)|*.txt";

            if (ofd.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                foreach (String line in File.ReadAllLines(ofd.FileName))
                {
                    if (line.Contains(":"))
                    {
                        String[] data = line.Split(':');

                        if (!Properties.Settings.Default.ProxiesLogin)
                            accChecker.QueueProxy(data[0], data[1]);
                        else
                            accChecker.QueueProxy(data[0], data[1], data[2], data[3]);
                    }
                }
                loadProxiesBtn.Text = String.Format("Load Proxies ({0})", accChecker.Proxies.Count);

                if (accChecker.Accounts.Count > 0 && (accChecker.Proxies.Count > 0 || !loadProxiesBtn.Visible))
                    checkBtn.Enabled = true;
                else
                    checkBtn.Enabled = false;

                UpdateInfos(true);
            }
        }
    }

When continue is clicked it then closes the application. I'm not sure if it's a form of my code?

Did you debug it? If not, this is the perfect time to learn how to use a debugger. — nvoigt, Feb 07 '15 at 14:40
So which line do you get the error? what are the values of the variables in that line? If you are indexing an array with a constant, does it actually *have* that many entries? — nvoigt, Feb 07 '15 at 14:43
Here is an image of the exact error I'm getting. http://i.imgur.com/zDyNEIX.png — JohnDueDueDue, Feb 07 '15 at 14:45

score 0 · Accepted Answer · edited May 23 '17 at 12:23

0

You problem persists with following code set [With reference to attached picture]

if (line.Contains(":"))
{
   String[] data = line.Split(':');

     if (!Properties.Settings.Default.ProxiesLogin)
        accChecker.QueueProxy(data[0], data[1]);
     else
         accChecker.QueueProxy(data[0], data[1], data[2], data[3]); // HERE
 }

Here you do not know whethere your string array actually contains data[0], data[1], data[2] or data[3] positions. More about NullReferenceException

Solution :

Check your array's Length property to verify you have data in these potions

So something like

 if (!Properties.Settings.Default.ProxiesLogin){
       if(data.Length > 1){
          accChecker.QueueProxy(data[0], data[1]);
       }
   }
   else{
       if(data.Length > 3){
         accChecker.QueueProxy(data[0], data[1], data[2], data[3]);
       }
   }

This won't solve your application logic. You will have to implement some logic to face this Length condition fails. something like UpdateInfos(false); [Thinking that's what you expect from this function]

edited May 23 '17 at 12:23

Community

1
1

answered Feb 07 '15 at 14:49

Kavindu Dodanduwa

9,413
2
26
40

Sorry I'm really new to this, don't understand much do you have skype or ICQ perhaps? – JohnDueDueDue Feb 07 '15 at 14:56
you could solve the problem with the help provided :) – Kavindu Dodanduwa Feb 07 '15 at 14:56
hmm oke that resolves the error, but then it's not loading the actual proxy list into the program. – JohnDueDueDue Feb 07 '15 at 15:00
Refer the updated answer :) You need to handle that case since your parameters do not match the required conditions – Kavindu Dodanduwa Feb 07 '15 at 15:02
I've tried still no luck into getting the program to load the proxy file to then send requests to the site the program is made for. If you have skype or ICQ I can show you or explain more indepth. – JohnDueDueDue Feb 07 '15 at 16:33

score 0 · Answer 2 · answered Feb 07 '15 at 15:07

0

You should check the length of data result.

  String[] data = line.Split(':');

answered Feb 07 '15 at 15:07

Roman Ambinder

369
3
7

C# System.IndexOutOfRangeException Error

2 Answers2