PHP OOP connection

Question

Hey all attempting to create a small MVC kind of application. Currently working on database class.

I am running a connection to the database every time i call a functions however failing to connect successfully and being able to send the $con variable to the other functions to do whatever with.

class DB {

function __construct() {

 $con = mysqli_connect("localhost","c3337015","c3337015");

 if (mysqli_connect_errno())
  {
  return false;

  }else{

  return $con;
 }

 }



function getAll(){

if(isset($con)){

echo "Connection Successful";
echo "Do MYSQLI stuff   $con = new mysqli etc etc etc";

}else{
echo "Connection Failed";
echo "Leave me alone";
}
}
}

echo $get = DB::getAll();

what about `$db = new DB(); $get = $db->getAll();` ?? you never instanciate the object...instead you are calling `getAll()` as a static method which is wrong — dev7, Sep 07 '14 at 18:12
you probably could adopt [this](http://stackoverflow.com/a/11369679/727208) approach, but .. emm .. what exactly is your question? — tereško, Sep 07 '14 at 18:17

score -6 · Answer 1 · answered Sep 07 '14 at 18:13

-6

First of all. See what is SINGLETON (it`s ideal thing for DB connection). Declare variable with connection and write singleton :) Example of singleton:

final class Singleton
{
    /**
     * class instance
     *
     * @var object
     * @access private
     */
    private static $oInstance = false;
    private $_db;

    /**
     * get instance
     *
     * @return Singleton
     * @access public
     * @static
     */
    public static function getInstance()
    {
        if( self::$oInstance == false )
        {
            self::$oInstance = new Singleton();
        }
        return self::$oInstance;
    }

    private function __construct() {}
}

So declare Your connection, declare method that will allow You to get connection and all done

answered Sep 07 '14 at 18:13

Daimos

1,443
9
25

2

`it is ideal thing for DB connection` - no it's not **ideal**. it depends on application – Marcin Orlowski Sep 07 '14 at 18:15
3

-1: are you even aware that singleton is an anti-pattern and there is **never** a good reason to use it? – tereško Sep 07 '14 at 18:18
1

@MarcinOrlowski , no it does not depend on the application. It's simply wrong **always**. – tereško Sep 07 '14 at 18:19
I bet I will faster defend "depends on application" than "ideal" or "wrong always" anyway – Marcin Orlowski Sep 07 '14 at 18:20
It's a global variable in a pretty (pretty ugly) dress. why defend it? – Benjamin Gruenbaum Sep 07 '14 at 18:24

PHP OOP connection

1 Answers1