146

I have created a custom UICollectionViewCell in Interface Builder, binded views on it to the class, and then when I want to use and set a string to the label on the string, tha label has a nil value.

override func viewDidLoad() {
    super.viewDidLoad()

    // Register cell classes
    self.collectionView.registerClass(LeftMenuCollectionViewCell.self, forCellWithReuseIdentifier: "ls")
}

override func collectionView(collectionView: UICollectionView!, cellForItemAtIndexPath indexPath: NSIndexPath!) -> UICollectionViewCell! {

    var cell: LeftMenuCollectionViewCell
    cell = collectionView.dequeueReusableCellWithReuseIdentifier("ls", forIndexPath: indexPath) as LeftMenuCollectionViewCell
    println(cell.label) // <- this is nil, why??
    cell.label.text = "asd"

    return cell
}

And the subclassed cell:

class LeftMenuCollectionViewCell: UICollectionViewCell {

    @IBOutlet weak var imageView: UIImageView!
    @IBOutlet weak var label: UILabel!
    @IBOutlet weak var activityIndicatorView: UIActivityIndicatorView!
}
János
  • 27,206
  • 24
  • 130
  • 270
  • Is there a reason you're using the explicit "!" in addition to type names everywhere? Seems redundant, esp in the IBOutlets. The only place it might matter is where you dequeue the cell as LeftmenuCollectionViewCell, but you don't do it there.. Can you println or NSLog 'cell' itself? – mc01 Aug 06 '14 at 16:28
  • 1
    If I remove "!" or use "?" in class definition, I get compiler error or crash. "!" is the default when you bind it. – János Aug 06 '14 at 16:32
  • ant the cell itself: > – János Aug 06 '14 at 16:42
  • All outlets hooked up in IB? Do the other outlets work? Don't see any other obvious issues, sorry. – mc01 Aug 06 '14 at 17:19
  • [Basic example for setting up a Collection View](http://stackoverflow.com/a/31735229/3681880) – Suragch Jul 30 '15 at 23:10

8 Answers8

317

I am calling self.collectionView.registerClass(LeftMenuCollectionViewCell.self, forCellWithReuseIdentifier: "ls") again. If you are using a storyboard you don't want to call this. It will overwrite what you have in your storyboard.

If you still have the problem check wether reuseIdentifier is same in dequeueReusableCellWithReuseIdentifier and in storyboard.

János
  • 27,206
  • 24
  • 130
  • 270
55

Just remove this line:

self.collectionView.registerClass(LeftMenuCollectionViewCell.self, forCellWithReuseIdentifier: "ls")
Undo
  • 25,204
  • 37
  • 102
  • 124
能蟹仔
  • 637
  • 5
  • 10
  • 3
    I don't understand why this was down voted. This was the answer to my problem. – Félix Simões Jun 24 '15 at 09:17
  • 1
    This is the correct answer, and should be marked accordingly by the person who asked the question. Would also be great to understand why it works :) – Kiko Lobo Jan 19 '16 at 07:40
  • 3
    Guess it was downvoted cause the question was answered in Aug'14 itself... while this answer just copies the answer again here, after several months. – Nitin Nain Mar 17 '16 at 16:28
  • 1
    But when I don't use it, it gives me error Assertion failure in -[UICollectionView _dequeueReusableViewOfKind:withIdentifier:forIndexPath:viewCategory:] – Shaheera Jun 30 '16 at 11:04
  • An explanation for why this line is not needed would be welcome. It's currently added by the Xcode boilerplate for a new collection view. – pkamb Dec 08 '18 at 03:53
50

If you are using xib, make sure that you have added this line of code to your viewdidload.

Objective C:

[self.collectionView registerNib:[UINib nibWithNibName:@"MyCell" bundle:nil] forCellWithReuseIdentifier:@"MyCellIdentifier"];

Swift:

collectionView.register(UINib(nibName:"MyCell", bundle: nil), forCellWithReuseIdentifier:"MyCellIdentifier")
Vineeth
  • 1,591
  • 1
  • 15
  • 22
  • do you have to register both class and nib, or only nib is enough? – RainCast Jun 15 '16 at 22:13
  • 3
    I just registered the nib and it solved my problems. – Amelia Nov 05 '16 at 20:25
  • Looks like there's two ways to register and I was using the wrong one... collectionView?.register(UINib(nibName: "YourItemClassName", bundle: nil), forCellWithReuseIdentifier: "yourIdentifier") collectionView?.register(YourItemClassName.self, forCellWithReuseIdentifier: "yourIdentifier") – Sergio Jul 25 '19 at 16:05
17

Gotta register that nib guys!

collectionView.register(UINib(nibName: "CustomCell", bundle: nil), forCellWithReuseIdentifier: "CustomCellId")
Michael
  • 8,464
  • 2
  • 59
  • 62
9

Looks like there's two ways to register and I was using the wrong one the first. I have a custom xib view so registered with the second option, and we have data!

1:

collectionView?.register(YourItemClassName.self, forCellWithReuseIdentifier: "yourIdentifier") 

2:

collectionView?.register(UINib(nibName: "YourItemClassName", bundle: nil), forCellWithReuseIdentifier: "yourIdentifier")
Sergio
  • 1,105
  • 1
  • 13
  • 20
0

I had a similar problem, but my mistake was that I didn't delegate CollectionViewCell to be able to change the label text..

justRadojko
  • 239
  • 4
  • 18
0

I think that best solution is to directly use from storyboard where add a CollectionView, in alternative you need to remove a CollectionViewCell from your CollectionView in storyboard and register a cell with the following command:

collectionView?.register(UINib(nibName: "YourItemClassName", bundle: nil), forCellWithReuseIdentifier: "yourIdentifier")

toshiro92
  • 1,149
  • 4
  • 24
  • 38
dgalluccio
  • 11
  • 4
0

You didn't register your cell,

fileprivate let yourIdentifier = ""yourIdentifier"
super.viewDidLoad() { 

//here you need to register cell collectionView?.register(NameOfYourClass.self, forCellWithReuseIdentifier: "yourIdentifier") }