Number format exception

Question

What is wrong with this code? I've got NumberFormatException. Invalid int: "" Everything looks correctly but I don't know am I doing my EditTexts correctly. Any help is welcome.

public class Wyslij extends Activity {

    EditText et_nazwa;
    EditText et_nip;
    EditText et_adres;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        super.onCreate(savedInstanceState);
        setContentView(R.layout.wyslij);

        et_nazwa = (EditText) findViewById(R.id.et_nazwa);
        et_nip = (EditText) findViewById(R.id.et_nip);            
        et_adres = (EditText) findViewById(R.id.et_adres);
        ib_wyslij = (ImageButton) findViewById(R.id.ib_wyslij);

        String nazwa_firmy = et_nazwa.getText().toString();

        String nip_firmowy = et_nip.getText().toString();
        int nip_firmy = Integer.valueOf(nip_firmowy);

        String adres_firmy = et_adres.getText().toString();

        final Zamowienie zam = new Zamowienie();

        zam.klient.nazwa = nazwa_firmy;
        zam.klient.nip = nip_firmy;
        zam.klient.adres = adres_firmy;

        String suma_zamowienia = podaj_sume(TowarZamowienie.towary_zamowione);
        int suma_zam = Integer.valueOf(suma_zamowienia);
        zam.suma=suma_zam;
    }
}

Mayank Saini · Accepted Answer · 2014-02-10T13:18:34.573

1

    public class Wyslij extends Activity {

        EditText et_nazwa;
        EditText et_nip;
        EditText et_adres;
    int suma_zam;
    int nip_firmy;


        @Override
        protected void onCreate(Bundle savedInstanceState) {
            // TODO Auto-generated method stub
            super.onCreate(savedInstanceState);
            setContentView(R.layout.wyslij);

            et_nazwa = (EditText) findViewById(R.id.et_nazwa);
            et_nip = (EditText) findViewById(R.id.et_nip);            
            et_adres = (EditText) findViewById(R.id.et_adres);
            ib_wyslij = (ImageButton) findViewById(R.id.ib_wyslij);

            String nazwa_firmy = et_nazwa.getText().toString();
           String nip_firmowy = et_nip.getText().toString();
     if(nip_firmowy != null && !nip_firmowy.equalsIgnoreCase(""){
           nip_firmy  = Integer.parseInt(nip_firmowy); 
            String adres_firmy = et_adres.getText().toString();

            final Zamowienie zam = new Zamowienie();

            zam.klient.nazwa = nazwa_firmy;
if(nip_firmy != null){
            zam.klient.nip = nip_firmy;
}
if(adres_firmy != null){
            zam.klient.adres = adres_firmy;
    }
        }


            String suma_zamowienia = podaj_sume(TowarZamowienie.towary_zamowione);
            if(suma_zamowienia != null && !suma_zamowienia.equalsIgnoreCase(""){

            suma_zam = Integer.parseInt(suma_zamowienia);
                zam.suma=suma_zam;}


        }
    }

edited Feb 10 '14 at 13:18

answered Feb 10 '14 at 12:50

Mayank Saini

2,957
22
25

I have edited the code check it out you are parsing on two occasions so add a guard there also – Mayank Saini Feb 10 '14 at 12:57
When I commented all int variables the next error was NullPointerExcept.. I don't know what is going on here.. – user2061352 Feb 10 '14 at 12:59
i have edited the code just copy it and paste it in your workspace – Mayank Saini Feb 10 '14 at 13:02
which line? can you tell me – Mayank Saini Feb 10 '14 at 13:06
zam.klient.nazwa = nazwa_firmy; – user2061352 Feb 10 '14 at 13:11
Probably we have to make the same with String – user2061352 Feb 10 '14 at 13:12
Problem lines: zam.klient.nazwa = nazwa_firmy; zam.klient.nip = nip_firmy; zam.klient.adres = adres_firmy; – user2061352 Feb 10 '14 at 13:13

score 0 · Answer 2 · answered Feb 10 '14 at 12:49

0

I believe there is a white space when you are fetching value from EditText. So before you convert the string value to integer you need to trim the white space like below,

String nip_firmowy = et_nip.getText().toString().trim();   // use trim here
int nip_firmy = Integer.parseInt(nip_firmowy);  // use parseInt() method

answered Feb 10 '14 at 12:49

user3291365

445
3
14

could you give me an example ? – user2061352 Feb 10 '14 at 12:52
There is no difference between `Integer.parseInt()` and `Integer.valueOf()`... `Integer.valueOf()` internally uses `Integer.parseInt()`... – Gopal Gopi Feb 10 '14 at 12:54

Number format exception

2 Answers2