8

I want to read a line of integers from the user. I'm not sure how to check to see if the input has ended. For example I want to be able to do something like

int x[MAX_SIZE];
int i = 0;
while(cin.hasNext())
{
  cin >> x[++i];
}

Example input: 2 1 4 -6

how can I check to see if there's any more for cin to take?

Celeritas
  • 12,953
  • 32
  • 95
  • 174
  • 8
    [do *not* try `cin.eof()`](http://stackoverflow.com/questions/5605125/why-is-iostreameof-inside-a-loop-condition-considered-wrong) – WhozCraig Jan 29 '14 at 01:33

6 Answers6

7

Yo have to do the following

int temp;

vector<int> v;
while(cin>>temp){
    v.push_back(temp);
}

also you can check for end of input using

if(cin.eof()){
    //end of input reached
}
0x499602D2
  • 87,005
  • 36
  • 149
  • 233
Miguel Carvajal
  • 1,253
  • 14
  • 18
6

If cin is still interactive, then there's no notion of "no more input" because it will simply wait for the user to provide more input (unless the user has signaled EOF with Ctrl+D or Ctrl+Z as appropriate). If you want to process a line of data, then get a line from the user (with, say, getline) and then deal with that input (by extracting out of a stringstream or similar).

vahid abdi
  • 7,840
  • 4
  • 27
  • 33
tabstop
  • 1,743
  • 10
  • 10
4

It is very straightforward. All you need to do is perform the extraction as the condition:

while (i < MAX_SIZE && std::cin >> x[i++])

if the extraction fails for any reason (no more characters left, invalid input, etc.) the loop will terminate and the failure will be represented in the stream state of the input stream.

Considering best practices, you shouldn't be using static C-arrays. You should be using the compile-time container std::array<T, N> (or std::vector<T> if the former is not supported).

Here is an example using std::vector. It also utilizes iterators which does away with having to explicitly create a copy of the input:

std::vector<int> v{ std::istream_iterator<int>{std::cin},
                    std::istream_iterator<int>{}};
0x499602D2
  • 87,005
  • 36
  • 149
  • 233
1

using fstream you can do something like this

ifstream ifile("input.txt");
while(!ifile.eof())
{
    /* do something */
}

you can also use this

if(!ifile.is_open())
{
   /* do something */
}
Mostafa Wael
  • 127
  • 3
0

The idea is silimar with this code below so you can try :

int tmp;
while(cin >> tmp != NULL){ // C++ or while(scanf("%d", &tmp) != -1) {} for C
     // do something
}
Linh Nguyễn Thành
  • 1
  • 1
  • While this code may solve the question, [including an explanation](//meta.stackexchange.com/q/114762) of how and why this solves the problem would really help to improve the quality of your post, and probably result in more up-votes. Remember that you are answering the question for readers in the future, not just the person asking now. Please [edit] your answer to add explanations and give an indication of what limitations and assumptions apply. – Xnero Aug 13 '20 at 10:05
0

I usually detect end of cpp stream below:

while (cin.peek() != EOF) {
  // To do your stuff...
  // NOTE: peek() will set failbit when peeking end of stream and return EOF(-1).
}
XingmingZ
  • 1
  • 1